New issue
Advanced search Search tips

Issue 889683 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Loading demo resources component never times out if network disconnected

Project Member Reported by agawronska@chromium.org, Sep 27

Issue description

What steps will reproduce the problem?
(1) Start online demo setup flow
(2) Disconnect network immediately when demo setup screen shows up  

What is the expected result?
Demo setup will eventually fail with error.

What happens instead?
Demo setup never fails.
Demo setup fails/succeeds only after reconnecting network.


I tried it with both ethernet and wifi.
I let the demo setup spin for over 5 minutes.

Log example:
[1205:1205:0926/165612.948326:VERBOSE1:wizard_controller.cc(632)] Showing demo mode setup screen.
[1205:1205:0926/165612.948463:VERBOSE1:wizard_controller.cc(1368)] SetCurrentScreenSmooth: demo-setup
[1205:1205:0926/165612.953829:VERBOSE1:demo_setup_controller.cc(192)] Starting demo mode enrollment online
[1205:1205:0926/165614.264816:ERROR:device_event_log_impl.cc(159)] [16:56:14.264] Network: network_state_handler.cc:1770 Default network in unexpected state: Ethernet (/service/1)State: idle
[1205:1205:0926/165614.277348:WARNING:object_proxy.cc(619)] Failed to call method: org.chromium.flimflam.IPConfig.GetProperties: object_path= /ipconfig/eth0_2_ip: org.freedesktop.DBus.Error.UnknownObject: Method "GetProperties" with signature "" on interface "org.chromium.flimflam.IPConfig" doesn't exist

[1205:1205:0926/170012.941627:VERBOSE1:component_updater_service.cc(322)] CheckForUpdates: automatic updatecheck for components.
[1205:1205:0926/170344.027898:VERBOSE1:component_updater_service.cc(409)] Update completed with error 0
[1205:1205:0926/170344.028091:ERROR:demo_setup_controller.cc(429)] Failed to load demo resources CrOS component with error: 4 fatal=0
[1205:1205:0926/170344.034779:VERBOSE1:component_updater_service.cc(409)] Update completed with error 5
[1205:1205:0926/170344.036500:VERBOSE1:component_updater_service.cc(409)] Update completed with error 5
[1205:1205:0926/170355.761801:VERBOSE1:signin_screen_handler.cc(593)] OnNetworkReady() call.

 
anything from imageloader in /var/log/messages?
Cc: xiaochu@chromium.org
I don't see much from image loader in /var/log/messages (drop in attached file).

  
messages.txt
193 KB View Download
CrOSComponentManager::Load checks location at /home/chronos/cros-components/ for the installed components. 

For demo mode resource, if CrOSComponentManager does not find it in the install location. It will try to download it and then fails if disconnected. 
It does not seem to fail if disconnected.
In the logs you see:

* Load called around 16:56:12
* Network disconnected 16:56:14
* Error reported 17:03:44, but that was only after I plugged ethernet cable back

For 7 minutes there was no failure, even though device was disconnected.

I don't see component updater error code. If you file a feedback I can take another look.
Feedback link: https://listnr.corp.google.com/report/85703686277

I also observe this on very slow network (GIN-3g).

Code where we call load: 
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc?rcl=58a957b5daddda1492d9497525eabe34618c0d57&l=221

From logs:
[3532:3532:1004/185326.674880:VERBOSE1:demo_setup_controller.cc(189)] Starting demo mode enrollment online
// Load called 18:53:26
[3532:3532:1004/185326.675004:ERROR:demo_setup_controller.cc(227)] [XXX] Called cros_component_manager->Load
// Network disconnected 18:53:28
[18:53:28.013] Network: network_state_handler.cc:1770 Default network in unexpected state: Ethernet (/service/1)State: idle

// Nothing going on for 4 minutes 
 
// Network reconnected 18:57:32
[3532:3532:1004/185732.994934:VERBOSE1:signin_screen_handler.cc(593)] OnNetworkReady() call.
// Component updater starts doing something 18:59:14 
[3532:3532:1004/185914.993577:VERBOSE1:component_updater_service.cc(322)] CheckForUpdates: automatic updatecheck for components.
[3532:3532:1004/190109.298632:VERBOSE1:component_updater_service.cc(409)] Update completed with error 0
[3532:3532:1004/190109.360536:ERROR:demo_setup_controller.cc(233)] [XXX] OnDemoResourcesCrOSComponentLoaded
i'm confused. you mean component is mounted successfully which is not WAI? can you update the title and description of this bug?
The title of the bug is correct.

What is happening:
1. Call load component
2. Disconnect network
3. Component does not timeout (waited 5 minutes)

What I am expecting:

Component loader returns an error - (timeout/no network connection)     
Cc: waff...@chromium.org
i guess chrome component updater hasn't finished its operation yet.
What shows on chrome://components if you navigate there after disconnecting the network?
I am in OOBE (loading component is a blocking step for demo mode setup).
How to check it while in OOBE or using command line? 
Maybe we should print that info to logs by locally fetching the same data that the WebUI uses.

https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/components_ui.cc?type=cs&q=%22chrome://components%22&sq=package:chromium&g=0&l=175
On the newest build I get timeout after about 8 minutes (which is long timeout in case of disconnected network).

[22839:22839:1024/113132.139982:VERBOSE1:wizard_controller.cc(630)] Showing demo mode setup screen.
[22839:22839:1024/113132.140021:VERBOSE1:wizard_controller.cc(1370)] SetCurrentScreenSmooth: demo-setup
[22839:22839:1024/113132.140956:VERBOSE1:demo_setup_controller.cc(204)] Starting demo setup online
[22839:22839:1024/113132.140982:VERBOSE1:demo_setup_controller.cc(224)] Loading demo resources component
[22839:22839:1024/113132.760092:ERROR:device_event_log_impl.cc(159)] [11:31:32.760] Network: network_state_handler.cc:1770 Default network in unexpected state: Ethernet (/service/1257)State: idle

------------------------------------
[22839:22839:1024/113632.141521:ERROR:demo_setup_controller.cc(136)] [XXX] Printing components
[22839:22839:1024/113632.141779:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "aemomkdncapdnfajjbbcbdebjljbpmpj",
   "name": "MEI Preload",
   "status": "New",
   "version": "1.0.3.0"
}

[22839:22839:1024/113632.141841:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "ckjlcfmdbdglblbjglepgnoekdnkoklc",
   "name": "Adobe Flash Player",
   "status": "New",
   "version": "0.0.0.0"
}

[22839:22839:1024/113632.141888:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "copjbmjbojbakpaedmpkhmiplmmehfck",
   "name": "Intervention Policy Database",
   "status": "New",
   "version": "2018.9.6.0"
}

[22839:22839:1024/113632.141945:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "gcmjkmgdlgnkkcocmoeiminaijmmjnii",
   "name": "Subresource Filter Rules",
   "status": "New",
   "version": "9.0"
}

[22839:22839:1024/113632.142020:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "giekcmmlnklenlaomppkphknjmnnpneh",
   "name": "Certificate Error Assistant",
   "status": "New",
   "version": "4"
}

[22839:22839:1024/113632.142331:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "jdmajdolkmhiifibdijabfojmfjmfkpb",
   "name": "demo-mode-resources",
   "status": "Downloading",
   "version": "0.0.0.0"
}

[22839:22839:1024/113632.142685:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "khaoiebndkojlmppeemjhbpbandiljpe",
   "name": "File Type Policies",
   "status": "New",
   "version": "21"
}

[22839:22839:1024/113632.142787:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "llkgjffcdpffmhiakmfcdcblohccpfmo",
   "name": "Origin Trials",
   "status": "New",
   "version": "0.0.0.0"
}

------------------------------------
[22839:22839:1024/114132.142449:ERROR:demo_setup_controller.cc(136)] [XXX] Printing components
[22839:22839:1024/114132.142723:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "aemomkdncapdnfajjbbcbdebjljbpmpj",
   "name": "MEI Preload",
   "status": "Update error",
   "version": "1.0.3.0"
}

[22839:22839:1024/114132.142784:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "ckjlcfmdbdglblbjglepgnoekdnkoklc",
   "name": "Adobe Flash Player",
   "status": "Update error",
   "version": "0.0.0.0"
}

[22839:22839:1024/114132.142858:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "copjbmjbojbakpaedmpkhmiplmmehfck",
   "name": "Intervention Policy Database",
   "status": "Update error",
   "version": "2018.9.6.0"
}

[22839:22839:1024/114132.142915:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "gcmjkmgdlgnkkcocmoeiminaijmmjnii",
   "name": "Subresource Filter Rules",
   "status": "Update error",
   "version": "9.0"
}

[22839:22839:1024/114132.142954:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "giekcmmlnklenlaomppkphknjmnnpneh",
   "name": "Certificate Error Assistant",
   "status": "Update error",
   "version": "4"
}

[22839:22839:1024/114132.142992:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "jdmajdolkmhiifibdijabfojmfjmfkpb",
   "name": "demo-mode-resources",
   "status": "Update error",
   "version": "0.0.0.0"
}

[22839:22839:1024/114132.143029:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "khaoiebndkojlmppeemjhbpbandiljpe",
   "name": "File Type Policies",
   "status": "Update error",
   "version": "21"
}

[22839:22839:1024/114132.143065:ERROR:demo_setup_controller.cc(143)] [XXX] {
   "id": "llkgjffcdpffmhiakmfcdcblohccpfmo",
   "name": "Origin Trials",
   "status": "Update error",
   "version": "0.0.0.0"
}

Owner: xiaochu@chromium.org
Status: Assigned (was: Untriaged)
xiaochu: looks like the status of demo-mode-resources is stuck at "Downloading". Could you look into why it doesn't fail?
Cc: sorin@chromium.org
If it shows "Downloading" then it's probably still being downloaded by chrome component updater... I'm not the author of chrome component updater so I can't point you immediately the fix. Maybe waffles@ or sorin@ can comment whether this is a bug (if so, what the appropriate fix should be).
Cc: norvez@chromium.org
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment