New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment
link

Issue 889682: Consider moving IPH from Tab to feature-specific classes

Reported by robertogden@chromium.org, Sep 27 Project Member

Issue description

This comes from a comment in https://chromium-review.googlesource.com/c/chromium/src/+/1234637

There's a lot of event notifications and IPH code in Tab.didFinishPageLoad which could be moved to a user data on tab like InfobarContainer.
 

Comment 1 by jinsuk...@chromium.org, Oct 2

Cc: tedc...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by dtrainor@chromium.org, Oct 2

Cc: twelling...@chromium.org mdjones@chromium.org
twellington@ had some thoughts around this as well (they might not necessarily fit as user data if they don't need to have any state on a per-tab basis).  e.g. we could also just be one of those other observers that always watches the current tab displayed to the user.

+some people who might have input.

Comment 3 by jinsuk...@chromium.org, Oct 10

Working on it now.. looks like TabObserver should be enough for this.

Comment 4 by bugdroid1@chromium.org, Nov 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41ee7d38d589f07b27671455fff28041ca32aee7

commit 41ee7d38d589f07b27671455fff28041ca32aee7
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed Nov 21 01:25:13 2018

Android: Factor InProductHelp UI out of Tab

This CL moves the methods handling InProductHelp UI in Tab to
ToolbarButtonInProductHelpController using ActivityLifecycleDispatcher and
Tab page load observing mechanism. Now the methods are handled by
ChromeTabbedActivity only.

Bug: 889682
Change-Id: Idce805f60f32ad90418c0f6e3ded80df6d18f9b1
Reviewed-on: https://chromium-review.googlesource.com/c/1272779
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609881}
[modify] https://crrev.com/41ee7d38d589f07b27671455fff28041ca32aee7/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/41ee7d38d589f07b27671455fff28041ca32aee7/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/41ee7d38d589f07b27671455fff28041ca32aee7/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java

Comment 5 by jinsuk...@chromium.org, Nov 21

Status: Fixed (was: Assigned)

Comment 6 by bugdroid1@chromium.org, Nov 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d436a7a2e33ee105a1d85370970fde3c88255302

commit d436a7a2e33ee105a1d85370970fde3c88255302
Author: Brian Sheedy <bsheedy@chromium.org>
Date: Wed Nov 21 23:21:42 2018

Revert "Android: Factor InProductHelp UI out of Tab"

This reverts commit 41ee7d38d589f07b27671455fff28041ca32aee7.

Reason for revert: Cause of  https://crbug.com/907602 

Original change's description:
> Android: Factor InProductHelp UI out of Tab
> 
> This CL moves the methods handling InProductHelp UI in Tab to
> ToolbarButtonInProductHelpController using ActivityLifecycleDispatcher and
> Tab page load observing mechanism. Now the methods are handled by
> ChromeTabbedActivity only.
> 
> Bug: 889682
> Change-Id: Idce805f60f32ad90418c0f6e3ded80df6d18f9b1
> Reviewed-on: https://chromium-review.googlesource.com/c/1272779
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609881}

TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org,jinsukkim@chromium.org,robertogden@chromium.org

Change-Id: I539d82b07ee8f6a3012ad72e1f2ba35eda613d72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 889682
Reviewed-on: https://chromium-review.googlesource.com/c/1347199
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610258}
[modify] https://crrev.com/d436a7a2e33ee105a1d85370970fde3c88255302/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/d436a7a2e33ee105a1d85370970fde3c88255302/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/d436a7a2e33ee105a1d85370970fde3c88255302/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java

Comment 7 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76d39b3a8d8fbd0e990f92a992d80213724de9bd

commit 76d39b3a8d8fbd0e990f92a992d80213724de9bd
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed Dec 05 23:06:59 2018

Reland "Android: Factor InProductHelp UI out of Tab"


https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple
of bugs in |ToolbarButtonInProductHelpController|:

1) Ignored |profile| passed into |maybeShowDownloadContinuingIPH()| and
   always used Profile.getLastUsedProfile()
2) |OnDismissListener| was instantiated (and menu got highlight for
   the text bubble) every time |setupAndMaybeShowIPHForFeature| is called,
   even when the method doesn't meet the condition for IPH text bubble
   and has to early out.

The CL got reverted due to numerous regressions . This CL fixes them and
relands it.

This reverts commit d436a7a2e33ee105a1d85370970fde3c88255302.

Bug: 889682, 907502, 907503, 907770, 907505,  907602 
Change-Id: Id6de148a9fd4fd91ad7df986ca0ba78ed18e79e4
Reviewed-on: https://chromium-review.googlesource.com/c/1349142
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614161}
[modify] https://crrev.com/76d39b3a8d8fbd0e990f92a992d80213724de9bd/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/76d39b3a8d8fbd0e990f92a992d80213724de9bd/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/76d39b3a8d8fbd0e990f92a992d80213724de9bd/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java

Comment 8 by jinsuk...@chromium.org, Dec 6

Status: Assigned (was: Fixed)
Summary: Consider moving IPH from Tab to feature-specific classes (was: Consider moving Tab.java didFinishPageLoad IPH and event code to a Tab User Data)
Repurposed this bug for tracking the refactoring effort around IPH.

Comment 9 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277

commit fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Thu Dec 06 22:10:37 2018

Revert "Reland "Android: Factor InProductHelp UI out of Tab""

This reverts commit 76d39b3a8d8fbd0e990f92a992d80213724de9bd.

Reason for revert:  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/2097 

 https://crbug.com/907602  doesn't seem to be addressed.

Original change's description:
> Reland "Android: Factor InProductHelp UI out of Tab"
> 
> 
> https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple
> of bugs in |ToolbarButtonInProductHelpController|:
> 
> 1) Ignored |profile| passed into |maybeShowDownloadContinuingIPH()| and
>    always used Profile.getLastUsedProfile()
> 2) |OnDismissListener| was instantiated (and menu got highlight for
>    the text bubble) every time |setupAndMaybeShowIPHForFeature| is called,
>    even when the method doesn't meet the condition for IPH text bubble
>    and has to early out.
> 
> The CL got reverted due to numerous regressions . This CL fixes them and
> relands it.
> 
> This reverts commit d436a7a2e33ee105a1d85370970fde3c88255302.
> 
> Bug: 889682, 907502, 907503, 907770, 907505,  907602 
> Change-Id: Id6de148a9fd4fd91ad7df986ca0ba78ed18e79e4
> Reviewed-on: https://chromium-review.googlesource.com/c/1349142
> Reviewed-by: Theresa <twellington@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614161}

TBR=twellington@chromium.org,jinsukkim@chromium.org

Change-Id: Id92d47e6ac65a0b1a50f4ad4cb1c0b9a11189993
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 889682, 907502, 907503, 907770, 907505,  907602 
Reviewed-on: https://chromium-review.googlesource.com/c/1366456
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614501}
[modify] https://crrev.com/fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java

Comment 10 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b643010d742b1323893685b3ded2250d684882c4

commit b643010d742b1323893685b3ded2250d684882c4
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sat Dec 08 00:06:02 2018

Reland "Android: Factor InProductHelp UI out of Tab" again

This reverts commit fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277.

Reason for revert: Reverted on a false alarm. Landing again.

Original change's description:
> Revert "Reland "Android: Factor InProductHelp UI out of Tab""
> 
> This reverts commit 76d39b3a8d8fbd0e990f92a992d80213724de9bd.
> 
> Reason for revert:  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/2097 
> 
>  https://crbug.com/907602  doesn't seem to be addressed.
> 
> Original change's description:
> > Reland "Android: Factor InProductHelp UI out of Tab"
> > 
> > 
> > https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple
> > of bugs in |ToolbarButtonInProductHelpController|:
> > 
> > 1) Ignored |profile| passed into |maybeShowDownloadContinuingIPH()| and
> >    always used Profile.getLastUsedProfile()
> > 2) |OnDismissListener| was instantiated (and menu got highlight for
> >    the text bubble) every time |setupAndMaybeShowIPHForFeature| is called,
> >    even when the method doesn't meet the condition for IPH text bubble
> >    and has to early out.
> > 
> > The CL got reverted due to numerous regressions . This CL fixes them and
> > relands it.
> > 
> > This reverts commit d436a7a2e33ee105a1d85370970fde3c88255302.
> > 
> > Bug: 889682, 907502, 907503, 907770, 907505,  907602 
> > Change-Id: Id6de148a9fd4fd91ad7df986ca0ba78ed18e79e4
> > Reviewed-on: https://chromium-review.googlesource.com/c/1349142
> > Reviewed-by: Theresa <twellington@chromium.org>
> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#614161}
> 
> TBR=twellington@chromium.org,jinsukkim@chromium.org
> 
> Change-Id: Id92d47e6ac65a0b1a50f4ad4cb1c0b9a11189993
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 889682, 907502, 907503, 907770, 907505,  907602 
> Reviewed-on: https://chromium-review.googlesource.com/c/1366456
> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614501}

TBR=twellington@chromium.org,jinsukkim@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 889682, 907502, 907503, 907770, 907505,  907602 
Change-Id: I1cdb497251b4a1f60f955cc6fd90c2be1eae3e96
Reviewed-on: https://chromium-review.googlesource.com/c/1368844
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614875}
[modify] https://crrev.com/b643010d742b1323893685b3ded2250d684882c4/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/b643010d742b1323893685b3ded2250d684882c4/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/b643010d742b1323893685b3ded2250d684882c4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java

Comment 11 by bugdroid, Feb 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b011f9b2c886d20f519cc2208e3d577a40098d7c

commit b011f9b2c886d20f519cc2208e3d577a40098d7c
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sat Feb 16 00:43:20 2019

Android: Delete in-product help for media download code

In-product help system was determined not to be launched.
This CL reverts https://crrev.com/2943983003 which added
the functionality for media download.

Bug: 715185, 889682
Change-Id: I7478eb2438023febd894560b18b6c380f81577e2
Reviewed-on: https://chromium-review.googlesource.com/c/1367065
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632842}
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/chrome/app/chrome_content_browser_overlay_manifest.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/chrome/browser/android/DEPS
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/chrome/browser/android/tab_android.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/components/feature_engagement/public/feature_constants.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/components/feature_engagement/public/feature_constants.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/components/feature_engagement/public/feature_list.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/components/feature_engagement/public/feature_list.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/content/public/common/web_preferences.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/content/public/common/web_preferences.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/content/renderer/render_view_impl.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/10d316d88a86a65dcd7e5bbe34dd2078f2ea32d8/third_party/blink/public/platform/media_download_in_product_help.mojom
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/public/web/web_settings.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/core/exported/web_settings_impl.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/core/exported/web_settings_impl.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/core/frame/settings.json5
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/BUILD.gn
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/DEPS
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[delete] https://crrev.com/10d316d88a86a65dcd7e5bbe34dd2078f2ea32d8/third_party/blink/renderer/modules/media_controls/media_download_in_product_help_manager.cc
[delete] https://crrev.com/10d316d88a86a65dcd7e5bbe34dd2078f2ea32d8/third_party/blink/renderer/modules/media_controls/media_download_in_product_help_manager.h
[modify] https://crrev.com/b011f9b2c886d20f519cc2208e3d577a40098d7c/tools/metrics/histograms/histograms.xml

Comment 12 by bugdroid, Feb 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b680363a9c009a9c71ecc136acea9eaad346eac

commit 0b680363a9c009a9c71ecc136acea9eaad346eac
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Feb 16 01:31:13 2019

Remove reference to non-existent generated header.

r632842 deleted the .mojom file that generates
media_download_in_product_help.mojom.h, but forgot to remove one
reference to it.

TBR=jinsukkim@chromium.org
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true
BUG=715185,889682

Change-Id: I4eccc4777fd0b00f31673d9cc2ecbbf982e02d7d
Reviewed-on: https://chromium-review.googlesource.com/c/1475668
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632847}
[modify] https://crrev.com/0b680363a9c009a9c71ecc136acea9eaad346eac/chrome/app/chrome_content_browser_overlay_manifest.cc

Comment 13 by bugdroid, Feb 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c34deab83d8eed646bdbd0d9cdd3375037a341

commit 32c34deab83d8eed646bdbd0d9cdd3375037a341
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Feb 16 01:35:38 2019

Revert "Android: Delete in-product help for media download code"

This reverts commit b011f9b2c886d20f519cc2208e3d577a40098d7c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 632842 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IwMTFmOWIyYzg4NmQyMGY1MTljYzIyMDhlM2Q1NzdhNDAwOThkN2MM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-rel/11315

Sample Failed Step: compile

Original change's description:
> Android: Delete in-product help for media download code
> 
> In-product help system was determined not to be launched.
> This CL reverts https://crrev.com/2943983003 which added
> the functionality for media download.
> 
> Bug: 715185, 889682
> Change-Id: I7478eb2438023febd894560b18b6c380f81577e2
> Reviewed-on: https://chromium-review.googlesource.com/c/1367065
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Stephen Chenney <schenney@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632842}

Change-Id: I6af075a801126a11c863f9955105cca0a60e1968
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 715185, 889682
Reviewed-on: https://chromium-review.googlesource.com/c/1476126
Cr-Commit-Position: refs/heads/master@{#632848}
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/chrome/app/chrome_content_browser_overlay_manifest.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/chrome/browser/android/DEPS
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/chrome/browser/android/tab_android.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/components/feature_engagement/public/feature_constants.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/components/feature_engagement/public/feature_constants.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/components/feature_engagement/public/feature_list.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/components/feature_engagement/public/feature_list.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/content/public/common/web_preferences.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/content/public/common/web_preferences.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/content/renderer/render_view_impl.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/public/BUILD.gn
[add] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/public/platform/media_download_in_product_help.mojom
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/public/web/web_settings.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/core/exported/web_settings_impl.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/core/exported/web_settings_impl.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/core/frame/settings.json5
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/BUILD.gn
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/DEPS
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[add] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/media_download_in_product_help_manager.cc
[add] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/media_download_in_product_help_manager.h
[modify] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/tools/metrics/histograms/histograms.xml

Comment 14 by bugdroid, Feb 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8caf17faa39c2f3c962c1af43f08e34c4ff3490e

commit 8caf17faa39c2f3c962c1af43f08e34c4ff3490e
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sat Feb 16 01:47:02 2019

Reland "Android: Delete in-product help for media download code"

This is a reland of b011f9b2c886d20f519cc2208e3d577a40098d7c

FindIt was too aggressive and auto-reverted r632842, as r632848,
which results in a broken tree because it is incompatible with
r632847 which already fixed the build.

TBR=jinsukkim@chromium.org
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true

Original change's description:
> Android: Delete in-product help for media download code
>
> In-product help system was determined not to be launched.
> This CL reverts https://crrev.com/2943983003 which added
> the functionality for media download.
>
> Bug: 715185, 889682
> Change-Id: I7478eb2438023febd894560b18b6c380f81577e2
> Reviewed-on: https://chromium-review.googlesource.com/c/1367065
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Stephen Chenney <schenney@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632842}

Bug: 715185, 889682
Change-Id: I73be467fcb49cb5e08ccf4d35737c6bff9ce9019
Reviewed-on: https://chromium-review.googlesource.com/c/1476083
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632849}
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/chrome/app/chrome_content_browser_overlay_manifest.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/chrome/browser/android/DEPS
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/chrome/browser/android/tab_android.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/components/feature_engagement/public/feature_constants.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/components/feature_engagement/public/feature_constants.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/components/feature_engagement/public/feature_list.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/components/feature_engagement/public/feature_list.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/content/public/common/web_preferences.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/content/public/common/web_preferences.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/content/renderer/render_view_impl.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/public/platform/media_download_in_product_help.mojom
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/public/web/web_settings.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/core/exported/web_settings_impl.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/core/exported/web_settings_impl.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/core/frame/settings.json5
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/BUILD.gn
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/DEPS
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[delete] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/media_download_in_product_help_manager.cc
[delete] https://crrev.com/32c34deab83d8eed646bdbd0d9cdd3375037a341/third_party/blink/renderer/modules/media_controls/media_download_in_product_help_manager.h
[modify] https://crrev.com/8caf17faa39c2f3c962c1af43f08e34c4ff3490e/tools/metrics/histograms/histograms.xml

Sign in to add a comment