The WebAudio spec on resume was updated to move the resume method from BaseAudioContext to AudioContext and OfflineAudioContext. Update our implementation to match. See https://github.com/WebAudio/web-audio-api/issues/1669
Can I take a look at this issue?
Sure. I already have a CL up for this, but you can work on this if you like and I won't use my CL.
Actually, the CL is almost ready to land, so it might be best to continue with it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2b54b08590d71b22bc5f03c445adc1e7fc9577c commit b2b54b08590d71b22bc5f03c445adc1e7fc9577c Author: Raymond Toy <rtoy@chromium.org> Date: Fri Sep 28 21:05:25 2018 Move resume from BaseAudioContext to its subclasses The WebAudio spec moved the resume method from the BaseAudioContext to its subclasses AudioContext and OfflineAudioContext. Update the idl and implementation to reflect this change. This change causes the following tests to fail: AudioContext/audiocontext-properties.html BaseAudioContext/baseaudiocontext-properties.html OfflineAudioContext/offlineaudiocontext-properties.html We remove these tests because they basically duplicate the test in external/wpt/webaudio/idlharness.https.window.html. Bug: 889663 , 888870 Test: already covered by existing tests Change-Id: Ic7ed8a5f950e8d069ac7c916d716526f96bf3c18 Reviewed-on: https://chromium-review.googlesource.com/1247703 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595213} [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/WebKit/LayoutTests/external/wpt/webaudio/idlharness.https.window-expected.txt [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [delete] https://crrev.com/75c86c30a26579aaf1e24e44f27380ce0f2096f6/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-properties.html [delete] https://crrev.com/75c86c30a26579aaf1e24e44f27380ce0f2096f6/third_party/WebKit/LayoutTests/webaudio/BaseAudioContext/baseaudiocontext-properties.html [delete] https://crrev.com/75c86c30a26579aaf1e24e44f27380ce0f2096f6/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-properties.html [delete] https://crrev.com/75c86c30a26579aaf1e24e44f27380ce0f2096f6/third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/blink/renderer/modules/webaudio/audio_context.h [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/blink/renderer/modules/webaudio/audio_context.idl [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/blink/renderer/modules/webaudio/base_audio_context.h [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/blink/renderer/modules/webaudio/base_audio_context.idl [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/blink/renderer/modules/webaudio/offline_audio_context.h [modify] https://crrev.com/b2b54b08590d71b22bc5f03c445adc1e7fc9577c/third_party/blink/renderer/modules/webaudio/offline_audio_context.idl
Comment 1 by donghee....@gmail.com
, Sep 27