Extensions Click-to-Script: Installed extensions metrics |
|||||||
Issue descriptionWe should gather metrics on the number of installed extensions users have that are affected by click to script.
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a9206e22f3734f71fd45b7f976f6c4696b03fa6 commit 9a9206e22f3734f71fd45b7f976f6c4696b03fa6 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Sep 28 23:39:51 2018 [Extensions Click-to-Script] Add metrics for extension permission state Add metrics to record the number of extensions that have withheld host permissions, and, if host permissions are withheld, the number of explicitly granted hosts. Only record these metrics if the RuntimeHostPermissions feature is enabled. Add unittests for the same. Bug: 889659 Change-Id: Ia2ae175ad7116d1aa6665514055a42efeb39f0da Reviewed-on: https://chromium-review.googlesource.com/1249529 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595251} [modify] https://crrev.com/9a9206e22f3734f71fd45b7f976f6c4696b03fa6/chrome/browser/extensions/installed_loader.cc [modify] https://crrev.com/9a9206e22f3734f71fd45b7f976f6c4696b03fa6/chrome/browser/extensions/installed_loader.h [add] https://crrev.com/9a9206e22f3734f71fd45b7f976f6c4696b03fa6/chrome/browser/extensions/installed_loader_unittest.cc [modify] https://crrev.com/9a9206e22f3734f71fd45b7f976f6c4696b03fa6/chrome/test/BUILD.gn [modify] https://crrev.com/9a9206e22f3734f71fd45b7f976f6c4696b03fa6/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9a9206e22f3734f71fd45b7f976f6c4696b03fa6/tools/metrics/histograms/histograms.xml
,
Sep 28
This should be fixed. jawag@, is this something we want to merge to 70 to get better data? (It should be fairly low risk, so might be worth it)
,
Oct 8
Sorry, I lost track of comment #3. Yes, requesting merge.
,
Oct 8
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 8
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7471954e45077c7d9512bdb57fe18e0ab5ca49bc Commit: 7471954e45077c7d9512bdb57fe18e0ab5ca49bc Author: rdevlin.cronin@chromium.org Commiter: rdevlin.cronin@chromium.org Date: 2018-10-08 22:01:16 +0000 UTC [Merge M70][Extensions Click-to-Script] Add metrics for extension permission state Add metrics to record the number of extensions that have withheld host permissions, and, if host permissions are withheld, the number of explicitly granted hosts. Only record these metrics if the RuntimeHostPermissions feature is enabled. Add unittests for the same. Bug: 889659 TBR=karandeepb@chromium.org (cherry picked from commit 9a9206e22f3734f71fd45b7f976f6c4696b03fa6) Reviewed-on: https://chromium-review.googlesource.com/1249529 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595251} Change-Id: Ib02c2a6a5e8f345e0eb7bdf7c029abab4e26fdcb Reviewed-on: https://chromium-review.googlesource.com/c/1269801 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#904} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7471954e45077c7d9512bdb57fe18e0ab5ca49bc commit 7471954e45077c7d9512bdb57fe18e0ab5ca49bc Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Oct 08 22:01:16 2018 [Merge M70][Extensions Click-to-Script] Add metrics for extension permission state Add metrics to record the number of extensions that have withheld host permissions, and, if host permissions are withheld, the number of explicitly granted hosts. Only record these metrics if the RuntimeHostPermissions feature is enabled. Add unittests for the same. Bug: 889659 TBR=karandeepb@chromium.org (cherry picked from commit 9a9206e22f3734f71fd45b7f976f6c4696b03fa6) Reviewed-on: https://chromium-review.googlesource.com/1249529 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595251} Change-Id: Ib02c2a6a5e8f345e0eb7bdf7c029abab4e26fdcb Reviewed-on: https://chromium-review.googlesource.com/c/1269801 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#904} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/7471954e45077c7d9512bdb57fe18e0ab5ca49bc/chrome/browser/extensions/installed_loader.cc [modify] https://crrev.com/7471954e45077c7d9512bdb57fe18e0ab5ca49bc/chrome/browser/extensions/installed_loader.h [add] https://crrev.com/7471954e45077c7d9512bdb57fe18e0ab5ca49bc/chrome/browser/extensions/installed_loader_unittest.cc [modify] https://crrev.com/7471954e45077c7d9512bdb57fe18e0ab5ca49bc/chrome/test/BUILD.gn [modify] https://crrev.com/7471954e45077c7d9512bdb57fe18e0ab5ca49bc/tools/metrics/histograms/enums.xml [modify] https://crrev.com/7471954e45077c7d9512bdb57fe18e0ab5ca49bc/tools/metrics/histograms/histograms.xml
,
Jan 15
The NextAction date has arrived: 2019-01-15 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rdevlin....@chromium.org
, Sep 27