New issue
Advanced search Search tips

Issue 889652 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Requesting super-long task delay period in TabManager::SchedulePerformStateTransitions()

Project Member Reported by thestig@chromium.org, Sep 26

Issue description

Chrome Version: 71.0.3563.0 debug build.
OS: Linux

What steps will reproduce the problem?
(1) Visit https://en.wikipedia.org/wiki/Main_Page
(2) Close the browser
(3) Relaunch the browser
(4) Immediately press ctrl + shift + t to restore the tab in (1)

When I do this, I get:

[$browser_pid:$browser_tid:$date:WARNING:message_loop_task_runner.cc(26)] Requesting super-long task delay period of 99999999 seconds from here: SchedulePerformStateTransitions@../../chrome/browser/resource_coordinator/tab_manager.cc:955
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68749c30427139d1cf43ea79ccfb5e303c5eed13

commit 68749c30427139d1cf43ea79ccfb5e303c5eed13
Author: Francois Doray <fdoray@chromium.org>
Date: Thu Nov 15 23:10:50 2018

RC: Disallow large timeouts in ProactiveTabFreezeAndDiscardParams.

TimeDelta::Max() should be used to express infinite timeouts. A large
timeout that is not TimeDelta::Max() causes MessageLoop to output a
warning.

Bug:  889652 
Change-Id: Ied1dd02cdeaec18e6d00e7fd3023e5ec1ea77826
Reviewed-on: https://chromium-review.googlesource.com/c/1336030
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608569}
[modify] https://crrev.com/68749c30427139d1cf43ea79ccfb5e303c5eed13/chrome/browser/resource_coordinator/tab_manager_features.cc

Status: Fixed (was: Untriaged)
The long delay came from fieldtrial_testing_config.json. It was now removed and DCHECKs were put in place to prevent us from putting them back.

Sign in to add a comment