New issue
Advanced search Search tips

Issue 889651 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Remove compressed tile support functionality

Project Member Reported by piman@chromium.org, Sep 26

Issue description

We don't use compressed tiles any more, and removed support for them a couple revs ago, we should clean up the rest of the infrastructure that is unused now:
- CompressedCopyTextureCHROMIUM
- compressed format GMBs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b13ddd7070c03faf7173bfcb781a4c2caad9a17

commit 0b13ddd7070c03faf7173bfcb781a4c2caad9a17
Author: Antoine Labour <piman@chromium.org>
Date: Thu Sep 27 17:00:21 2018

Remove CompressedCopyTextureCHROMIUM

This is not used anywhere any more. Remove extension, entrypoints,
bindings and tests.

Bug:  889651 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If3e2c95f7531752f2690b1f3e4345620bf4efb2d
Reviewed-on: https://chromium-review.googlesource.com/1247191
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594756}
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/BUILD.gn
[delete] https://crrev.com/6283c799ca8e416c3ee6fb7d195191601bb5663b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_compressed_copy_texture.txt
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/GLES2/gl2extchromium.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/build_raster_cmd_buffer.py
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/raster_cmd_helper_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/raster_implementation_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/raster_implementation_gles.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/raster_implementation_gles.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/raster_implementation_gles_unittest.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/raster_implementation_impl_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/raster_implementation_unittest_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/client/raster_interface_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/common/raster_cmd_format_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/common/raster_cmd_format_test_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/common/raster_cmd_ids_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/gles2_cmd_buffer_functions.txt
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/raster_cmd_buffer_functions.txt
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/gpu/command_buffer/service/raster_decoder_autogen.h
[delete] https://crrev.com/6283c799ca8e416c3ee6fb7d195191601bb5663b/gpu/command_buffer/tests/gl_compressed_copy_texture_CHROMIUM_unittest.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/ui/gl/generate_bindings.py
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/ui/gl/gl_bindings_api_autogen_gl.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/ui/gl/gl_bindings_autogen_gl.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/ui/gl/gl_bindings_autogen_gl.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/ui/gl/gl_bindings_autogen_mock.cc
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/ui/gl/gl_bindings_autogen_mock.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/ui/gl/gl_mock_autogen_gl.h
[modify] https://crrev.com/0b13ddd7070c03faf7173bfcb781a4c2caad9a17/ui/gl/gl_stub_autogen_gl.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0669e1580845cd0ece4539919d3f8835d63344e

commit c0669e1580845cd0ece4539919d3f8835d63344e
Author: Antoine Labour <piman@chromium.org>
Date: Tue Oct 02 23:19:37 2018

Remove compressed GMB formats

They are not used anywhere any more. Some of them never ever were.

Bug:  889651 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I81e4746927dfd763a80b215788e1690a4728ff59
Reviewed-on: https://chromium-review.googlesource.com/c/1252855
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596037}
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/cc/resources/resource_pool_unittest.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/components/exo/buffer.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/components/viz/common/resources/resource_format_utils.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/components/viz/host/host_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/gpu/command_buffer/client/raster_implementation.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/gpu/command_buffer/common/gpu_memory_buffer_support.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gfx/buffer_format_util.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gfx/buffer_types.h
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gfx/mojo/buffer_types.mojom
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gfx/mojo/buffer_types_struct_traits.h
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gl/gl_image_io_surface.mm
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gl/gl_image_io_surface_egl.mm
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gl/gl_image_memory.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gl/gl_image_native_pixmap.cc
[modify] https://crrev.com/c0669e1580845cd0ece4539919d3f8835d63344e/ui/gl/test/gl_image_test_support.cc

Status: Fixed (was: Started)
Thanks
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eafcabace24735450068b5861a4ea4c0ddae2b6

commit 2eafcabace24735450068b5861a4ea4c0ddae2b6
Author: Antoine Labour <piman@chromium.org>
Date: Wed Oct 03 23:33:05 2018

Remove TileDrawInfo::has_compressed_resource

It's always false.

Bug:  889651 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I50e3b03ff3b25bc8759b79463b72e3b63ebbd8a5
Reviewed-on: https://chromium-review.googlesource.com/c/1259944
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596421}
[modify] https://crrev.com/2eafcabace24735450068b5861a4ea4c0ddae2b6/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/2eafcabace24735450068b5861a4ea4c0ddae2b6/cc/tiles/tile_draw_info.h

Sign in to add a comment