Issue metadata
Sign in to add a comment
|
Able to set 'Play Files' root folder as download location |
||||||||||||||||||||
Issue descriptionGoogle Chrome 70.0.3538.34 (Official Build) beta (32-bit) Revision aace6e0c91e8a57c4cb209b798cee4eab9c5b82d-refs/branch-heads/3538@{#675} Platform 11021.28.0 (Official Build) beta-channel kevin What steps will reproduce the problem? 1. Open Settings -> Advanced section -> Downloads 2. Click on 'Change' button to change default download location 3. Click on Play Files volume and click 'OPEN' button What is the expected result? Nothing should happen on clicking OPEN button since saving files to Play Files root volume is not supported. (or) 'OPEN' button should be disabled when Play Files volume is selected. What happens instead? Window is closed and Play Files volume is set as download location. (Please note that even though Play Files volume is set as download location, files are saved in Downloads folder as usual)
,
Oct 1
,
Oct 11
Play Files root is a read-only folder. It is WAI that we can specify read-only folder as download location, since there is no "select a writable folder" dialog in any platforms. There is a "select a folder" dialog and download-location setting uses it. In other platforms like Windows/Mac/Linux, we can specify read-only folder as download location and we'll see error notifications when downloading files. That said, in Chrome OS, we might be able to assume that users don't need to select Play Files root in "select a folder" dialog. Weifang, WDTY? Should we black-list "Play Files" root in "select a folder" dialog.
,
Oct 17
Sorry for the slow response - Yes, let's actually blacklist the Play Files root as an option for a Download destination. To be clear for my understanding, this means that subfolders under the root will also not be available, correct? +mcirimele@ - FYI in case this doesn't seem like a good approach. Also, updating to M-72 as we are past branch.
,
Oct 17
Subfolders under 'Play Files' will be available for 'select a folder' dialog. My suggestion is to blacklist the 'Play Files' root only.
,
Oct 17
Oh I had thought we would not show the root if we blacklist. Does blacklisting the "Play files" root mean it would still appear in the side-nave, but you would disable the "Ok" button?
,
Oct 18
Yes, I would disable "Ok" button when the current folder is "Play files" root. There is a caveat. Let's say a user want to back up all Android files. The user go to drive.google.com and select New->"Folder Upload". The "select a folder" dialog will show up. If we blacklist "Play files" root, the user can't specify "Play files" to upload all of them. The user need to upload each subfolder under "Play files". As it should be rare for a user to try to specify "Play files" root as download location, it might be safer to avoid blacklisting "Play files" root from "select a folder" dialog.
,
Nov 12
Still can reproduce on 72.0.3602.0. Chrome OS version: R72-11235.0.0 BIOS version: Google_Bobba.11210.0.0 EC: bobba_v2.0.256-f420a49e2
,
Dec 12
,
Jan 16
Reassigning to Weifang per offline discussion for more detailed spec. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by slangley@chromium.org
, Sep 27Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)