New issue
Advanced search Search tips

Issue 889642 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-04
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Find-in-page search terms persist across guest user sessions

Reported by dblagent...@gmail.com, Sep 26

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.35 Safari/537.36

Steps to reproduce the problem:
1. Open Chrome window for a user (signed in or not, doesn't matter).
2. Open guest window.
3. Go to google.com in omni-box.
4. Select "Find" in drop-down menu.
5. Enter "google" in find-in-page box and hit enter.
6. Exit guest by going to the profile switcher menu and selecting exit guest.
7. You should now be back to the window for the original user.
8. Open guest window (using profile switcher menu).
9. Select "Find" in drop-down menu.
10. The term "google is highlighted in the find-in-page box.

What is the expected behavior?
At step 10, the find-in-page box should be empty.

What went wrong?
The search term entered in the find-in-page box at step 5 persisted to step 10 even though guest mode was closed at step 6.

Did this work before? N/A 

Chrome version: 70.0.3538.35  Channel: beta
OS Version: 10.0
Flash Version: 

One thing to note is that the find-in-page search term does not persist across different guest sessions if all Chrome windows are closed between sessions. This means that if all Chrome windows are closed when you exit guest mode at step 6, then the search term will not persist across sessions.
 
Labels: Needs-Triage-M70
Cc: vamshi.kommuri@chromium.org
Components: -UI UI>Browser>Search
Labels: Triaged-ET Target-71 M-71 FounIn-71 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Thanks for filing the issue!

Able to reproduce the issue on reported chrome version 70.0.3538.35 and on the latest canary 71.0.3562.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1

As the issue is seen from M60(60.0.3112.0) considering it as Non-Regression and marking it as Untriaged. Requesting someone from "UI>Browser>Search" team to have a look into it.
Components: -UI>Browser>Search UI>Browser>FindInPage Privacy
Labels: -OS-Linux -OS-Windows -OS-Mac OS-Chrome
re-triaging; many applied tags were wrong.

I agree this sounds unexpected.

I see a similar behavior with incognito windows in other platforms (as noted by vamshi); I think that makes more sense there because it's obvious on those platforms the windows are still open.  With "Guest" sessions on ChromeOS, it's less obvious.
NextAction: 2018-10-04
Cc: rhalavati@chromium.org
Given that the description says "Open guest window" rather than "Sign in as guest", I believe the OS labels were actually correct and this is a Desktop, not CrOS bug report.
Labels: -OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
I think the behavior is definitely not as intended, as all navigation history from guest (or incognito) mode should be forgotten after all windows are closed, and search terms are for sure revealing (part of) user navigation history.
Labels: Hotlist-DesktopUIConsider
The NextAction date has arrived: 2018-10-04
Labels: Group-Find
Labels: -Group-Find Group-Toolbar
Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged
Status: Assigned (was: Available)
Redirecting to dfried@ for local triage.
Owner: dfried@chromium.org
Redirecting to dfried@ for local triage.
Status: Started (was: Assigned)
Labels: -Needs-Triage-M70
Labels: -M-71 -Target-71 Target-72 M-72
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcab465b3e9fc00fc7313c36be0cf0151c395004

commit bcab465b3e9fc00fc7313c36be0cf0151c395004
Author: Dana Fried <dfried@chromium.org>
Date: Fri Oct 19 22:34:27 2018

Clear guest find text when guest window closes.

Bug: 889642

Change-Id: I805a78630edc9f0c214e5bd02567439b7406f13d
Reviewed-on: https://chromium-review.googlesource.com/c/1287030
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601326}
[modify] https://crrev.com/bcab465b3e9fc00fc7313c36be0cf0151c395004/chrome/browser/ui/find_bar/find_bar_controller.cc

Labels: Needs-Feedback
Tried checking the issue on chrome version 72.0.3588.0 using Mac 10.13.1 yet we were able to see the content when clicked Cmd+F.

@Dana Fried: Could you please let us know if any more CLs are yet to land here. And requesting you to help us in verifying the fix.

Thanks!
Cc: ellyjo...@chromium.org
I can verify that the issue is fixed on Windows, but it's possible the code path is different on Mac and we're missing something. I'm cc-ing ellyjones@chromium.org to see if she has any insight.
On Mac there's a system-wide "find pasteboard" which find-in-page updates and which Chrome (and other apps) share the current search term in. There's logic to suppress updates to it in *incognito* added by robliao@ here: <https://chromium-review.googlesource.com/c/chromium/src/+/1069424/>

Perhaps that logic should also trigger for Guest sessions. Feel free to assign this bug to me if you'd like.
Labels: Hotlist-DesktopUIChecked
Status: WontFix (was: Started)
** Mass UI Triage **

We were unable to reproduce this bug on chrome #72.0.3610.0. If this bug still reproduces for you, please reopen or file a new issue. Thanks!
kkaluri@,

Does your test cover Mac as well?
Otherwise I think it's better repoen and assign to ellyjones@ as stated in #22.
Cc: -ellyjo...@chromium.org dfried@chromium.org
Owner: ellyjo...@chromium.org
Status: Assigned (was: WontFix)
We didn't fix or otherwise modify the behavior on Mac, so if this is now not reproing, we should probably also investigate *that*. I'll look.
Thank you. :)
Labels: -M-72 -Target-72 M-73 Target-73
Labels: -Group-Toolbar Group-Find

Sign in to add a comment