New issue
Advanced search Search tips

Issue 889640 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AnalyserNode channel count should be 2

Project Member Reported by rtoy@chromium.org, Sep 26

Issue description

According to https://webaudio.github.io/web-audio-api/#analysernode, the channelCount should be 2, not 1.  Fix it.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b91c8719e28a3758785220c66a24bb8682980c52

commit b91c8719e28a3758785220c66a24bb8682980c52
Author: Raymond Toy <rtoy@chromium.org>
Date: Thu Sep 27 21:02:02 2018

AnalyserNode channelCount is 2

The spec says the channelCount should be 2 not 1 for an AnalyserNode.

Remove the test expectations too since we pass the tests now.

Bug:  889640 , 888870
Change-Id: I814fc31d0e15c371f9ae74dd8e3ce2fb0a906197
Reviewed-on: https://chromium-review.googlesource.com/1247241
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594855}
[delete] https://crrev.com/e716f6e83718423d7732fc1a36af5300ee8e61b8/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt
[delete] https://crrev.com/e716f6e83718423d7732fc1a36af5300ee8e61b8/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt
[modify] https://crrev.com/b91c8719e28a3758785220c66a24bb8682980c52/third_party/blink/renderer/modules/webaudio/analyser_node.cc

Status: Fixed (was: Started)

Sign in to add a comment