New issue
Advanced search Search tips

Issue 889637 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
Launcher-Polish


Sign in to add a comment

Close icon is missing in shelf context menu entry for task manager app

Project Member Reported by sdantul...@chromium.org, Sep 26

Issue description

Google Chrome	70.0.3538.34 (Official Build) beta (32-bit)
Revision	aace6e0c91e8a57c4cb209b798cee4eab9c5b82d-refs/branch-heads/3538@{#675}
Platform	11021.28.0 (Official Build) beta-channel kevin

What steps will reproduce the problem?
1. Open taskmanager app using Search + Esc shortcut keys
2. Right-click on the app icon in shelf
3. Observe 'Close' context menu entry

What is the expected result?
Close icon should be present along with the text

What happens instead?
Close icon is missing

Issue not reproducible with other apps like Files, Chrome browser, Keyboard shortcut viewer.

Attached screenshots.
 
Expected.png
150 KB View Download
Actual.png
234 KB View Download
Labels: -Pri-3 -M-70 M-72 Pri-2
Owner: tbuck...@chromium.org
Status: Assigned (was: Untriaged)
Is this a crostini app?
No. Its one of the chrome apps which is available by default.

This app can also be launched from chrome browser. 
Open Chrome browser -> Click on the 3 dot menu -> More tools -> Task manager
Not sure who worked on this app. I would encourage them to subclass here to get the proper icons:

https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/app_context_menu.h?dr=CSs&q=AddContextMenuOption&sq=package:chromium&g=0&l=24
 


Components: UI>TaskManager
Owner: newcomer@chromium.org
This app has existed on Chrome OS for years. I think it needs be handled as part of the shelf redesign as I don't think there's a dedicated owner.
Labels: -Pri-2 Pri-3
Owner: omrilio@chromium.org
Omri, do you know anyone with cycles for this for M-72? I suppose they should also tackle the files app showing the menu option.

Either way, seems pretty low priority so I'll reassign to P-3. 
Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.
Labels: -M-73
Cc: omrilio@chromium.org
Owner: manucornet@chromium.org

Sign in to add a comment