New issue
Advanced search Search tips

Issue 889633 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Check the color space support to determin whether a overlay format is supported

Project Member Reported by magchen@chromium.org, Sep 26

Issue description

Chrome Version: (M71)
OS: (Win10)

According to Intel, the NV12 overlay format should not be enabled if
DXGI_COLOR_SPACE_YCBCR_STUDIO_G22_LEFT_P709 is not supported. At least one Intel
Gen9 SKU will not support NV12 overlay.
This applies to the YUV format too.

Once NV12 can be successfully detected, we can use it as a swap chain format and remove the extra Blt to improve power in video playback.
 
Labels: -Type-Bug Type-Feature
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e57881c2369dc026ef0b24aebd2b494ee51bb4e4

commit e57881c2369dc026ef0b24aebd2b494ee51bb4e4
Author: Maggie Chen <magchen@chromium.org>
Date: Fri Oct 05 02:49:29 2018

Use the NV12 overlay format only if the Rec. 709 Color Space is also supported

According to Intel, the NV12 overlay format should not be used if
DXGI_COLOR_SPACE_YCBCR_STUDIO_G22_LEFT_P709 is not supported. At least one Intel
Gen9 SKU will not support NV12 overlay. This color space info is recorded through
UMA.


BUG= 889633 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0406b833e8cfbe0af0a9a408f8e665e3d6e87d77
Reviewed-on: https://chromium-review.googlesource.com/c/1247183
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596970}
[modify] https://crrev.com/e57881c2369dc026ef0b24aebd2b494ee51bb4e4/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/e57881c2369dc026ef0b24aebd2b494ee51bb4e4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e57881c2369dc026ef0b24aebd2b494ee51bb4e4/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment