The migration dialog has the same issue.

Deleted: Screen Shot 2018-09-26 at 5.51.21 PM.png 362 KB

	Screen Shot 2018-09-26 at 5.51.21 PM.png 362 KB View Download

mac specific bug?

This is affecting the checkbox accessibility for all desktop platforms, and the existing card unmask dialog also subjects to the issue. 

Can we priorities this as the card unmask dialog is already user facing?

Is this somehow specific to those two dialogs? It seems like it should just work based on the code in //ui/views/checkbox.cc. It's hard to find checkboxes on Chrome OS, but the uninstall extension dialog has one, and ChromeVox just reads the label while ignoring the control type (checkbox) or state (unchecked).

Found out in the extension uninstall dialog reads unchecked as well. I guess this should be a general problem at least on Mac

Deleted: Screen Shot 2018-10-02 at 3.59.30 PM.png 701 KB

	Screen Shot 2018-10-02 at 3.59.30 PM.png 701 KB View Download

Hi Aaron, can you ptal at this accessibility issue? It is a bug affecting UX now. Thanks!

Steps:
1. Go to https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html
2. Enter name for "Name on Card" under horizontal line
3. Try to use checkbox with screen reader

Alternate steps:
1. Go to chrome://extensions
2. Click remove on an extension
3. Dialog "Report abuse" shows up

mathp@ found this piece of code that looks suspicious: https://cs.chromium.org/chromium/src/ui/views/controls/button/checkbox.cc?l=90-95

    if (checked()) {
      node_data->SetDefaultActionVerb(ax::mojom::DefaultActionVerb::kUncheck);
    } else {
      node_data->SetDefaultActionVerb(ax::mojom::DefaultActionVerb::kCheck);
    }
  }

It sets default action verb as "uncheck" if checked, and "check" otherwise. Could it be that the way it's announced makes it sound like the state and not the associated action?

The implementation for UI checkbox is only half there. Not sure how that happened!

Fix is up for review: https://chromium-review.googlesource.com/c/chromium/src/+/1264855 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f91f518ad2baa7067f0cce91349c087edfeec73

commit 7f91f518ad2baa7067f0cce91349c087edfeec73
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Tue Oct 09 16:39:55 2018

Implement UI checkbox accessibility for Mac, Win

Bug:  889602 
Change-Id: I2e2685be4b89c0c76d89776b56adc7c0e818be0f
Reviewed-on: https://chromium-review.googlesource.com/c/1264855
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597950}
[modify] https://crrev.com/7f91f518ad2baa7067f0cce91349c087edfeec73/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/7f91f518ad2baa7067f0cce91349c087edfeec73/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/7f91f518ad2baa7067f0cce91349c087edfeec73/ui/views/controls/button/checkbox.cc

Tried checking the issue on reported chrome version 71.0.3559.0 and on the latest canary 71.0.3577.0 using Mac 10.13.1
1. Turned ON VoiceOver in Mac
2. Launched Chrome
3. Navigated to Chrome://extensions
4. Clicked on "Remove" to remove an extension.
In both the above mentioned versions, VoiceOver didn't read the check box. Attaching the screencast of the same for reference from version 71.0.3559.0.

@Aaron Leventhal: Could you please have a look at the screen cast and let us know if we have missed anything in the process. And requesting you to help us in verifying the fix.

Thanks!

Deleted: 889602 CL.mp4 1.1 MB

	889602 CL.mp4 1.1 MB View Download

@vamshi, thanks, here is my feedback on that:
- If we want the checkbox to be read by VoiceOver on mouse click, the checkbox should receive focus when clicked. In most UI's a mouse click on a widget will also focus it, so this is probably a bug, but a separate one, and should be for the general views/UI team, not the a11y team.
- It may also be considered a bug that focus did not go to the first item in the dialog when it opened, as is customary. This helps the screen reader user become immediately aware of the presence of more widgets, as the focused object is read aloud.
- Note that screen reader users would generally tab to a widget to interact with it. Spacebar toggles a checkbox. If you do that, you will note that it works well with VoiceOver now in Canary