New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889584 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug
Build-Toolchain



Sign in to add a comment

informational builders failed BuildPackages

Project Member Reported by minch@chromium.org, Sep 26

Issue description

Many of the informational builders failed at BuildPackages,
example,
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934296654156190592

chromeos-chrome-71.0.3563.0_alpha-r1: ERROR: ld.so: object 'libsandbox.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
chromeos-chrome-71.0.3563.0_alpha-r1: ERROR: ld.so: object 'libsandbox.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
chromeos-chrome-71.0.3563.0_alpha-r1: ERROR: ld.so: object 'libsandbox.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.

 
chromeos-chrome-71.0.3563.0_alpha-r1: FAILED: clang_newlib_arm/liblouis_nacl.nexe clang_newlib_arm/exe.unstripped/liblouis_nacl.nexe 
chromeos-chrome-71.0.3563.0_alpha-r1: python "../../../../../../../home/chrome-bot/chrome_root/src/build/toolchain/gcc_link_wrapper.py" --output="clang_newlib_arm/liblouis_nacl.nexe" --strip="../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/arm-nacl-strip" --unstripped-file="clang_newlib_arm/exe.unstripped/liblouis_nacl.nexe" -- ../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/arm-nacl-clang++ -Wl,--fatal-warnings -Wl,--build-id=sha1 -fuse-ld=gold -B../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin -Wl,--icf=all -Wl,-O2 -Wl,--gc-sections -o "clang_newlib_arm/exe.unstripped/liblouis_nacl.nexe" -Wl,--start-group @"clang_newlib_arm/liblouis_nacl.nexe.rsp"  -Wl,--end-group    
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: skipping incompatible /home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/../arm-nacl/lib/libc.a while searching for c
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: skipping incompatible /usr/lib/libc.a while searching for c
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: error: cannot find -lc
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: error: undefined or discarded symbol _impure_ptr in GOT
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/nacl_wrapper/liblouis_instance.cc:130: error: undefined reference to 'strcmp'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:135: error: undefined reference to 'exit'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:152: error: undefined reference to 'strcpy'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:385: error: undefined reference to 'sprintf'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:525: error: undefined reference to 'fgetc'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:525: error: undefined reference to 'fgetc'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:568: error: undefined reference to 'fgetc'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:561: error: undefined reference to 'fgetc'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4852: error: undefined reference to 'strlen'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4855: error: undefined reference to 'memcmp'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4866: error: undefined reference to 'memcmp'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4794: error: undefined reference to 'strlen'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:748: error: undefined reference to 'malloc'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4739: error: undefined reference to 'free'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:752: error: undefined reference to 'free'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:1333: error: undefined reference to 'free'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:1858: error: undefined reference to 'free'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4884: error: undefined reference to 'malloc'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4950: error: undefined reference to 'malloc'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:5000: error: undefined reference to 'malloc'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:662: error: undefined reference to 'vsnprintf'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:684: error: undefined reference to 'vsnprintf'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4635: error: undefined reference to 'getenv'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4637: error: undefined reference to 'sprintf'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4640: error: undefined reference to 'sprintf'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4647: error: undefined reference to 'sprintf'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4659: error: undefined reference to 'strdup'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4558: error: undefined reference to 'strcpy'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4559: error: undefined reference to 'strlen'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4562: error: undefined reference to 'strcat'
chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/liblouis/src/liblouis/compileTranslationTable.c:4563: error: undefined reference to 'stat'
Cc: dgarr...@chromium.org zamorzaev@chromium.org
Hi zamorzaev@ and dgarrett@, do you have any idea why did this happen? Most of the informational builders failed on BuildPackages step currently.
I believe the most important line is:

chromeos-chrome-71.0.3563.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: skipping incompatible /usr/lib/libc.a while searching for c

But I don't know why that would happen.

Best guess so far is that it's related to new toolchains rolling out.
Cc: cmt...@chromium.org
+cmtice for toochains.
It should not be related to toolchain. It tries to link arm binary with host /usr/lib/libc.a. 
Oh... interesting.

That sounds like a change to the Chrome build files?
Cc: kmarshall@chromium.org
+kmarshall
it might related to this change?
https://chromium-review.googlesource.com/c/chromium/src/+/1241842
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934285971567224656


chromeos-chrome-71.0.3563.0_alpha-r1: [20440/46616] LINK newlib_pnacl/zip_archiver_pnacl.pexe
chromeos-chrome-71.0.3563.0_alpha-r1: FAILED: newlib_pnacl/zip_archiver_pnacl.pexe newlib_pnacl/exe.unstripped/zip_archiver_pnacl.pexe 
chromeos-chrome-71.0.3563.0_alpha-r1: python "../../../../../../../home/chrome-bot/chrome_root/src/build/toolchain/gcc_link_wrapper.py" --output="newlib_pnacl/zip_archiver_pnacl.pexe" --strip="../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-finalize" --unstripped-file="newlib_pnacl/exe.unstripped/zip_archiver_pnacl.pexe" -- ../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-clang++ -Wl,--fatal-warnings -fuse-ld=gold -B../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin -Wl,--icf=all -Wl,-O2 -Wl,--gc-sections -o "newlib_pnacl/exe.unstripped/zip_archiver_pnacl.pexe" -Wl,--start-group @"newlib_pnacl/zip_archiver_pnacl.pexe.rsp"  -Wl,--end-group    
chromeos-chrome-71.0.3563.0_alpha-r1: pnacl-ld: Unrecognized option: --icf=all
Hi,

It looks like this has to do with the nacl libc libraries no longer being valid.

My CL only touches Fuchsia builds, which do not support NaCl. I'd be pretty surprised if they were related...
Cc: goog...@chromium.org
Cc: vapier@chromium.org
+vapier for the cl
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1229238

Hi vapier@, mind help take a quick look? Feel it might related. Thanks.
in general, the "libsandbox.so" warnings cited in comment #0 are a red herring and should have no bearing here

wrt CL:1229238, it should have no bearing here either as it only affects tools that use `dc` which i strongly expect Chrome does not use during build.  don't be distracted by the use of the word "sandbox" in there.
Cc: x...@chromium.org
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934276280613803840

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934314929070195136

Hi zamorzaev, I found the first failed pfq builder and last succeed one have the same chrome version, both are  71.0.3562.0.
I feel it should be the problem of chromeos change, could you please help take a look?thanks
Components: Infra>Client>ChromeOS>Build Tools>ChromeOS-Toolchain
Labels: -Pri-1 OS-Chrome Pri-0
The entire chrome PFQ (in Chrome OS) is currently broken.  It appears that the arm boards are failing building chromeos-chrome, with the incompatible libc.a.  This appears to me to be related to nacl:

1.0.3563.0_rc-r1: [12948/46077] LINK clang_newlib_arm/liblouis_nacl.nexe
chromeos-chrome-71.0.3563.0_rc-r1: FAILED: clang_newlib_arm/liblouis_nacl.nexe clang_newlib_arm/exe.unstripped/liblouis_nacl.nexe 
chromeos-chrome-71.0.3563.0_rc-r1: python "../../../../../../../home/chrome-bot/chrome_root/src/build/toolchain/gcc_link_wrapper.py" --output="clang_newlib_arm/liblouis_nacl.nexe" --strip="../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/arm-nacl-strip" --unstripped-file="clang_newlib_arm/exe.unstripped/liblouis_nacl.nexe" -- ../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/arm-nacl-clang++ -Wl,--fatal-warnings -fuse-ld=gold -B../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin -Wl,--icf=all -Wl,-O2 -Wl,--gc-sections -o "clang_newlib_arm/exe.unstripped/liblouis_nacl.nexe" -Wl,--start-group @"clang_newlib_arm/liblouis_nacl.nexe.rsp"  -Wl,--end-group    
chromeos-chrome-71.0.3563.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: skipping incompatible /home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/../arm-nacl/lib/libc.a while searching for c
chromeos-chrome-71.0.3563.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: skipping incompatible /usr/lib/libc.a while searching for c
chromeos-chrome-71.0.3563.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: error: cannot find -lc


Furthermore, the x86 boards in the chromium PFQ are ALSO failing, also with a nacl build error:

chromeos-chrome-71.0.3563.0_rc-r1: [34024/47190] LINK irt_x64/nacl_irt.nexe
chromeos-chrome-71.0.3563.0_rc-r1: FAILED: irt_x64/nacl_irt.nexe irt_x64/exe.unstripped/nacl_irt.nexe 
chromeos-chrome-71.0.3563.0_rc-r1: python "../../../../../../../home/chrome-bot/chrome_root/src/build/toolchain/gcc_link_wrapper.py" --output="irt_x64/nacl_irt.nexe" --strip="../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/x86_64-nacl-strip" --unstripped-file="irt_x64/exe.unstripped/nacl_irt.nexe" -- python ../../../../../../../home/chrome-bot/chrome_root/src/native_client/build/link_irt.py --tls-edit=host/tls_edit --link-cmd=../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/x86_64-nacl-clang++ --readelf-cmd=../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/x86_64-nacl-readelf -Wl,--fatal-warnings -Wl,--build-id=sha1 -fuse-ld=gold -B../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin -m64 -Wl,--gc-sections -o "irt_x64/exe.unstripped/nacl_irt.nexe" -Wl,--start-group @"irt_x64/nacl_irt.nexe.rsp"  -Wl,--end-group    
chromeos-chrome-71.0.3563.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: error: -Trodata-segment is meaningless without --rosegment
chromeos-chrome-71.0.3563.0_rc-r1: x86_64-nacl-clang++: error: linker command failed with exit code 1 (use -v to see invocation)
chromeos-chrome-71.0.3563.0_rc-r1: Traceback (most recent call last):
chromeos-chrome-71.0.3563.0_rc-r1:   File "../../../../../../../home/chrome-bot/chrome_root/src/native_client/build/link_irt.py", line 236, in <module>
chromeos-chrome-71.0.3563.0_rc-r1:     sys.exit(Main())
chromeos-chrome-71.0.3563.0_rc-r1:   File "../../../../../../../home/chrome-bot/chrome_root/src/native_client/build/link_irt.py", line 229, in Main
chromeos-chrome-71.0.3563.0_rc-r1:     linker.Link(remaining_args)
chromeos-chrome-71.0.3563.0_rc-r1:   File "../../../../../../../home/chrome-bot/chrome_root/src/native_client/build/link_irt.py", line 152, in Link
chromeos-chrome-71.0.3563.0_rc-r1:     self.RunLink(cmd_line, pre_tls_edit_out)
chromeos-chrome-71.0.3563.0_rc-r1:   File "../../../../../../../home/chrome-bot/chrome_root/src/native_client/build/link_irt.py", line 129, in RunLink
chromeos-chrome-71.0.3563.0_rc-r1:     raise Error('FAILED with %d: %s' % (err, ' '.join(cmd_line)))
chromeos-chrome-71.0.3563.0_rc-r1: build_nexe_tools.Error: FAILED with 1: ../../../../../../../home/chrome-bot/chrome_root/src/native_client/toolchain/linux_x86/pnacl_newlib/bin/x86_64-nacl-clang++ -o irt_x64/exe.unstripped/nacl_irt.nexe.raw -Wl,--as-needed -Wl,--fatal-warnings -Wl,--build-id=sha1 -fuse-ld=gold -B../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin -m64 -Wl,--gc-sections -Wl,--start-group @irt_x64/nacl_irt.nexe.rsp -Wl,--end-group -Wl,-Ttext-segment=0xfcb0000 -Wl,-Trodata-segment=0x3efa0000
chromeos-chrome-71.0.3563.0_rc-r1: 

Bumping the priority to p0 since the entire chrome PFQ is broken.
Cc: yunlian@chromium.org
chromeos-chrome-71.0.3563.0_alpha-r1: [2652/2652] SOLINK ./libassistant.so
chromeos-chrome-71.0.3563.0_alpha-r1: ninja: build stopped: subcommand failed.
chromeos-chrome-71.0.3563.0_alpha-r1:  * ERROR: chromeos-base/chromeos-chrome-71.0.3563.0_alpha-r1::chromiumos failed (compile phase):
chromeos-chrome-71.0.3563.0_alpha-r1:  *   (no error message)
chromeos-chrome-71.0.3563.0_alpha-r1:  * 
chromeos-chrome-71.0.3563.0_alpha-r1:  * Call stack:
chromeos-chrome-71.0.3563.0_alpha-r1:  *     ebuild.sh, line  133:  Called src_compile
chromeos-chrome-71.0.3563.0_alpha-r1:  *   environment, line 4320:  Called chrome_make 'chrome_sandbox' 'chrome' 'jpeg_decode_accelerator_unittest' 'ozone_gl_unittests' 'sandbox_linux_unittests' 'video_decode_accelerator_unittest' 'video_encode_accelerator_unittest' 'wayland_client_perftests' 'jpeg_encode_accelerator_unittest' 'ppapi/examples/video_decode' 'bitmaptools' 'clear_system_cache' 'minidump_stackwalk' 'chromedriver' 'nacl_helper_bootstrap' 'nacl_helper'
chromeos-chrome-71.0.3563.0_alpha-r1:  *   environment, line 1270:  Called die
chromeos-chrome-71.0.3563.0_alpha-r1:  * The specific snippet of code:
chromeos-chrome-71.0.3563.0_alpha-r1:  *       [[ "${ret}" -eq 0 ]] || die
chromeos-chrome-71.0.3563.0_alpha-r1:  * 


https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1240816

+yunlian
for libassistant change.
Cc: steve...@chromium.org
Hi Steven, do you have any idea about this, i can't even repro the build packages error in my local.
Maybe this CL is causing the problem. From the errors, NaCl toolchain and gold have some problem together.

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1240816
Yes, #19 makes sense. There is no gold binary under src/native_client/toolchain and because of --fuse-ld=gold, it uses another gold?
I think the right fix should be modifying the gn file for nacl.
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e496c3b99a48d37eb17f6ed7b8e84eccf650ce81

commit e496c3b99a48d37eb17f6ed7b8e84eccf650ce81
Author: Min Chen <minch@chromium.org>
Date: Thu Sep 27 18:34:22 2018

Revert "chromeos-chrome: pass use_gold to gn files"

This reverts commit 5024a05eccf5419bbfba6588d722bf8e7ba45c8f.

Reason for revert: Failed pfq at BuildPackages
                   The gold related flags are passed to nacl and
                    make the chrome PFQ fail. chromium:889584
https://luci-logdog.appspot.com/v/?s=chromeos/buildbucket/cr-buildbucket.appspot.com/8934293443791559424/+/steps/BuildPackages/0/stdout

Original change's description:
> chromeos-chrome: pass use_gold to gn files
>
> libassistant will try to use bfd linker is use_gold and use_lld is
> not set to true. Currently we are using gold to link chrome and we
> should pass use_gold=true to gn file in this case.
>
> BUG= chromium:888710 
> TEST=libassistant is using gold linker.
>
> Change-Id: I76a767f0a7017b8bdb36660c26131b4c19fd3ad8
> Reviewed-on: https://chromium-review.googlesource.com/1240816
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Yunlian Jiang <yunlian@chromium.org>
> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>

Bug:  chromium:889584 , chromium:888710 
Change-Id: I3ee7990e786cb7c5aa6a322fcd14e964c40f7be0
Reviewed-on: https://chromium-review.googlesource.com/1249608
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Tested-by: Min Chen <minch@chromium.org>

[modify] https://crrev.com/e496c3b99a48d37eb17f6ed7b8e84eccf650ce81/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Status: Fixed (was: Untriaged)
marked as fixed, since some of the informational builds turn to green.
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934205145352061904

Sign in to add a comment