New issue
Advanced search Search tips

Issue 889578 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Horizontal Tab Switcher] Assert failed when toggling the incognito button with 0 incognito tab

Project Member Reported by meiliang@google.com, Sep 26

Issue description

Clank have an assertion error, when toggling the incognito button if no incognito tab was opened.

To Reproduce:
1. Build Clank locally
2. Launch Chrome
3. Make sure no incognito tab was opened, click the incognito button.

You should end with an error:

09-26 08:27:16.289 31549 31549 D AndroidRuntime: Shutting down VM
09-26 08:27:16.292 31549 31549 E AndroidRuntime: FATAL EXCEPTION: main
09-26 08:27:16.292 31549 31549 E AndroidRuntime: Process: com.google.android.apps.chrome, PID: 31549
09-26 08:27:16.292 31549 31549 E AndroidRuntime: java.lang.AssertionError
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarModel.getProfile(ToolbarModel.java:274)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarModel.getDisplaySearchTerms(ToolbarModel.java:449)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarModel.shouldDisplaySearchTerms(ToolbarModel.java:429)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.omnibox.LocationBarLayout.setUrlToPageUrl(LocationBarLayout.java:1817)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarManager.updateCurrentTabDisplayStatus(ToolbarManager.java:1641)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarManager.refreshSelectedTab(ToolbarManager.java:1579)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarManager.access$200(ToolbarManager.java:117)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarManager$3.onTabModelSelected(ToolbarManager.java:300)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.tabmodel.TabModelSelectorBase.selectModel(TabModelSelectorBase.java:86)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.selectModel(TabModelSelectorImpl.java:231)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.ChromeTabbedActivity.lambda$initializeUI$3$ChromeTabbedActivity(ChromeTabbedActivity.java:858)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.ChromeTabbedActivity$$Lambda$3.onClick(Unknown Source:2)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarManager.lambda$wrapBottomToolbarClickListenerForIPH$1$ToolbarManager(ToolbarManager.java:714)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at org.chromium.chrome.browser.toolbar.ToolbarManager$$Lambda$1.onClick(Unknown Source:4)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at android.view.View.performClick(View.java:6294)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at android.view.View$PerformClick.run(View.java:24770)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:790)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at android.os.Looper.loop(Looper.java:164)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:6494)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
09-26 08:27:16.292 31549 31549 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
09-26 08:27:16.305  4780  5518 W ActivityManager: Force finishing activity com.google.android.apps.chrome/org.chromium.chrome.browser.ChromeTabbedActivity

 
Cc: yus...@chromium.org
Components: UI>Browser>Mobile>TabSwitcher
Status: Available (was: Untriaged)
Summary: [Horizontal Tab Switcher] Assert failed when toggling the incognito button with 0 incognito tab (was: Clankium crashed when toggling the incognito button with 0 incognito tab)

Sign in to add a comment