New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889572 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-09
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Task



Sign in to add a comment

Update Public Suffix for M-70 before Stable

Project Member Reported by marti...@chromium.org, Sep 26

Issue description

(Reposting explanation from Umbrella Bug, Issue 610495)

Chrome ships a copy of the Public Suffix List ( https://publicsuffix.org ) for a variety of security purposes. Because it's key to web origin security, it needs to be reliably available before any networking, and is thus baked into the binary (rather than a component updater).

The list changes over time, and so this list must be updated every release to include the latest changes.

This is a data file-only change that includes the expressed security policies of domain holders, from the domain holders.

For every release, a bug will be created to track that releases' updates to the PSL.
 
The NextAction date has arrived: 2018-10-09
Labels: ReleaseBlock-Stable OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Cc: abdulsyed@chromium.org
Cc: benmason@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3348aa5da829c3e01489797b688ba72349a4c82b

commit 3348aa5da829c3e01489797b688ba72349a4c82b
Author: Martijn Croonen <martijnc@chromium.org>
Date: Tue Oct 09 18:53:51 2018

Refresh Public Suffix List to the latest version.

This updates from revision
649d6339ff2748e94d076b44e2aecc047795a607 (2018-05-08)

to revision
6f2b9e75eaf65bb75da83677655a59110088ebc5 (2018-10-03)

Bug:  889572 
Change-Id: I1ea5b56e11e0d373d3242769e08e248ea9c99416
Reviewed-on: https://chromium-review.googlesource.com/c/1249149
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598010}
[modify] https://crrev.com/3348aa5da829c3e01489797b688ba72349a4c82b/net/base/registry_controlled_domains/effective_tld_names.dat
[modify] https://crrev.com/3348aa5da829c3e01489797b688ba72349a4c82b/net/base/registry_controlled_domains/effective_tld_names.gperf

Labels: Merge-Request-70
Requesting a merge to M70.

This is a data-only change, issue 610495 has more background info on the PSL updates and a history of previous PSL merges.
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 10

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: Less than 2 days to go before AppStore submit on M70
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved for merge to 70, branch 3538.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96e8bdf45f655e55c44b312d836ddb7ed3782e9d

commit 96e8bdf45f655e55c44b312d836ddb7ed3782e9d
Author: Martijn Croonen <martijnc@chromium.org>
Date: Wed Oct 10 15:49:27 2018

Refresh Public Suffix List to the latest version.

This updates from revision
649d6339ff2748e94d076b44e2aecc047795a607 (2018-05-08)

to revision
6f2b9e75eaf65bb75da83677655a59110088ebc5 (2018-10-03)

Bug:  889572 
Change-Id: I1ea5b56e11e0d373d3242769e08e248ea9c99416
Reviewed-on: https://chromium-review.googlesource.com/c/1249149
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#598010}(cherry picked from commit 3348aa5da829c3e01489797b688ba72349a4c82b)
Reviewed-on: https://chromium-review.googlesource.com/c/1273524
Reviewed-by: Martijn Croonen <martijnc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#947}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/96e8bdf45f655e55c44b312d836ddb7ed3782e9d/net/base/registry_controlled_domains/effective_tld_names.dat
[modify] https://crrev.com/96e8bdf45f655e55c44b312d836ddb7ed3782e9d/net/base/registry_controlled_domains/effective_tld_names.gperf

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/96e8bdf45f655e55c44b312d836ddb7ed3782e9d

Commit: 96e8bdf45f655e55c44b312d836ddb7ed3782e9d
Author: martijnc@chromium.org
Commiter: martijnc@chromium.org
Date: 2018-10-10 15:49:27 +0000 UTC

Refresh Public Suffix List to the latest version.

This updates from revision
649d6339ff2748e94d076b44e2aecc047795a607 (2018-05-08)

to revision
6f2b9e75eaf65bb75da83677655a59110088ebc5 (2018-10-03)

Bug:  889572 
Change-Id: I1ea5b56e11e0d373d3242769e08e248ea9c99416
Reviewed-on: https://chromium-review.googlesource.com/c/1249149
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#598010}(cherry picked from commit 3348aa5da829c3e01489797b688ba72349a4c82b)
Reviewed-on: https://chromium-review.googlesource.com/c/1273524
Reviewed-by: Martijn Croonen <martijnc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#947}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
martijnc@ can we close this out now?
Status: Fixed (was: Assigned)
Blocking: -610495

Sign in to add a comment