New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889568 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Give Chrome Cleanup Tool the ability to disable selected extensions

Project Member Reported by joenotcharles@chromium.org, Sep 26

Issue description

Add a method to the ChromePrompt interface that's used for communication between Chrome and the Chrome Cleanup Tool, allowing the tool to request that Chrome disable a list of extensions that it has determined are unwanted.

The Cleanup Tool should only call this method after the user has consented to remove these extensions.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721

commit 5afe20d8a0ec4fc02652bfb38d34ee2dbc201721
Author: timidger <timidger@google.com>
Date: Thu Sep 27 14:18:17 2018

Added DisableExtension mojo method to the ChromePrompt interface.

This allows the Chrome Cleanup Tool to request Chrome to delete extensions it finds.

This was put in the mojom interface because it's the simplest way to add to the CCT
interface to Chrome. This has no real dependency on the chrome prompt
workflow.

Also changes the chrome cleaner to only build on platforms that support extensions as it was breaking on android (which we don't support).

R=joenotcharles@chromium.org, joenotcharles@google.com, kinuko@chromium.org, reillyg@chromium.org

Bug:  889568 
Change-Id: Idbbebda824e3d7764940773964f50045639617bd
Reviewed-on: https://chromium-review.googlesource.com/1207219
Commit-Queue: Preston Carpenter <timidger@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594711}
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.h
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_controller_win.h
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h
[add] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/safe_browsing/chrome_cleaner/srt_delete_extension_win_unittest.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/chrome_cleaner/ipc/chrome_prompt_ipc_unittest.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/test/BUILD.gn
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/test/base/testing_profile_manager.cc
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/chrome/test/base/testing_profile_manager.h
[modify] https://crrev.com/5afe20d8a0ec4fc02652bfb38d34ee2dbc201721/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom

Labels: SafeBrowsing-Triaged
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a78043deb1840d45ef6a4ee262ad0fc3b223709

commit 0a78043deb1840d45ef6a4ee262ad0fc3b223709
Author: timidger <timidger@google.com>
Date: Wed Oct 03 16:50:13 2018

Use version 3 for DisableExtensions not 2

We already shipped a chrome version with version 2 exposed, so the
Chrome Cleanup Tool will try to use this method when it doesn't exist
unless we bump the minimum version.

Change-Id: I6c0bf1209da85ea54f4e7d2d365d64ac8a98ba66
Bug:  889568 
Reviewed-on: https://chromium-review.googlesource.com/1258296
Commit-Queue: Preston Carpenter <timidger@google.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596254}
[modify] https://crrev.com/0a78043deb1840d45ef6a4ee262ad0fc3b223709/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom

Owner: timidger@google.com
Status: Started (was: Available)
The following revision also refers to this bug: forgot to include the bug ID in the commit message.

https://chromium-review.googlesource.com/c/chromium/src/+/1278852
Status: Fixed (was: Started)
Labels: Merge-Request-71
Requesting a merge to M71:

The first commit came before the branch point and added a DisableExtension interface to the IPC channel used by the Chrome Cleanup Tool.

The remaining two added an important security verification (refusing to delete extensions that have not been displayed to the user when prompting to clean up UwS, to ensure that a compromised Chrome Cleanup Tool can't silently disable extensions). It's important to have this extra validation in the first Chrome version that ships with the new interface (M71).

Test coverage: chrome/browser/safe_browsing/chrome_cleaner/srt_delete_extension_win_unittest.cc
Deployed in canary: since Oct 16
Safe merge: This code is not activated unless the Chrome Cleanup Tool invokes DisableExtensions over IPC, so this will not regress a code path that's already in use.
Labels: OS-Windows
Correction to the merge request: The first TWO commits are already in M71, it's just the last commit that needs merging.
Cc: joenotcharles@chromium.org
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 24

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge you change to M71 branch 3578 ASAP  so we can pick it up for next week beta release. Thank you.
Labels: Merge-Merged
The change was merged as https://crrev.com/6b3fd75a17fe86923f1d31893a09d2ae5bea364f
Labels: -Merge-Approved-71 merge-merged-3578

Sign in to add a comment