Give Chrome Cleanup Tool the ability to disable selected extensions |
||||||||||
Issue descriptionAdd a method to the ChromePrompt interface that's used for communication between Chrome and the Chrome Cleanup Tool, allowing the tool to request that Chrome disable a list of extensions that it has determined are unwanted. The Cleanup Tool should only call this method after the user has consented to remove these extensions.
,
Sep 28
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a78043deb1840d45ef6a4ee262ad0fc3b223709 commit 0a78043deb1840d45ef6a4ee262ad0fc3b223709 Author: timidger <timidger@google.com> Date: Wed Oct 03 16:50:13 2018 Use version 3 for DisableExtensions not 2 We already shipped a chrome version with version 2 exposed, so the Chrome Cleanup Tool will try to use this method when it doesn't exist unless we bump the minimum version. Change-Id: I6c0bf1209da85ea54f4e7d2d365d64ac8a98ba66 Bug: 889568 Reviewed-on: https://chromium-review.googlesource.com/1258296 Commit-Queue: Preston Carpenter <timidger@google.com> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#596254} [modify] https://crrev.com/0a78043deb1840d45ef6a4ee262ad0fc3b223709/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
,
Oct 23
The following revision also refers to this bug: forgot to include the bug ID in the commit message. https://chromium-review.googlesource.com/c/chromium/src/+/1278852
,
Oct 23
,
Oct 23
Requesting a merge to M71: The first commit came before the branch point and added a DisableExtension interface to the IPC channel used by the Chrome Cleanup Tool. The remaining two added an important security verification (refusing to delete extensions that have not been displayed to the user when prompting to clean up UwS, to ensure that a compromised Chrome Cleanup Tool can't silently disable extensions). It's important to have this extra validation in the first Chrome version that ships with the new interface (M71). Test coverage: chrome/browser/safe_browsing/chrome_cleaner/srt_delete_extension_win_unittest.cc Deployed in canary: since Oct 16 Safe merge: This code is not activated unless the Chrome Cleanup Tool invokes DisableExtensions over IPC, so this will not regress a code path that's already in use.
,
Oct 23
,
Oct 23
Correction to the merge request: The first TWO commits are already in M71, it's just the last commit that needs merging.
,
Oct 23
,
Oct 24
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24
Pls merge you change to M71 branch 3578 ASAP so we can pick it up for next week beta release. Thank you.
,
Oct 25
The change was merged as https://crrev.com/6b3fd75a17fe86923f1d31893a09d2ae5bea364f
,
Oct 25
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 27