Change spacing between KSV categories to 8px |
|||
Issue descriptionThe spacing and top margin used on wallpaper picker are 8px.
,
Sep 26
I'm guessing KSH == KSV (Keyboard Shortcut Viewer), what does 'H' stand for? Posting before and after pictures, and a comparison with the wallpaper picker would be nice.
,
Sep 26
,
Sep 26
"H" stands for "helper", which is used by PM and UX. I uploaded two pictures before/after changes and compared with wallpaper picker. But it seems it still do not match exactly after the changes.
,
Sep 26
Uploaded another image to make it more obvious of the misalignment.
,
Sep 26
I changed to spacing 9px, and it is matched. wzang@, could you please double check wallpaper? Thanks!
,
Sep 27
wzang@ will fix the alignment in another bug 889655. I will change the spacing to 8px.
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/423ec1531c590cc828dd43a6a3c36990b857b329 commit 423ec1531c590cc828dd43a6a3c36990b857b329 Author: wutao <wutao@chromium.org> Date: Thu Sep 27 22:27:03 2018 Revise tab spacing in vertical mode This cl revises the tab spacing in vertical mode to match the spacing in the wallpaper picker. Images before and after changes are uploaded in the bug. Bug: 889559 Test: manual. Change-Id: I33a73809a9c674b009c5fdf1f9367645d395af87 Reviewed-on: https://chromium-review.googlesource.com/1249818 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#594896} [modify] https://crrev.com/423ec1531c590cc828dd43a6a3c36990b857b329/ui/views/controls/tabbed_pane/tabbed_pane.cc
,
Sep 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wutao@chromium.org
, Sep 26Components: UI>Input>KeyboardShortcuts
Labels: M-71