New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889505 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: TwoClientDictionarySyncTest.Limit



Sign in to add a comment

TwoClientDictionarySyncTest.Limit is flaky on win7 (dbg) and win-asan

Project Member Reported by Findit, Sep 26

Issue description

Cc: mamir@chromium.org melandory@chromium.org
Components: Services>Sync
Is this a dupe of issue 873573? Note the bot is slightly different, Win7 Tests (dbg)(1)
Labels: FixitSync
Owner: mamir@chromium.org
Status: Assigned (was: Untriaged)
Labels: SyncTriaged
mamir@ - will you be working on this flake shortly? This flaked again in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/71945 - if subsequent flakes continue to happen the test will be disabled. Thanks!
Owner: ----
Yes, the plan is I will work on it.
However, more urgent stuff just fall into my plate.
Since this a P1, I will unassign myself then in case someone else can pick it up!
Summary: TwoClientDictionarySyncTest.Limit is flaky on win7 (dbg) and win-asan (was: TwoClientDictionarySyncTest.Limit is flaky)
Output from failures on win (dbg) (https://chromium-swarm.appspot.com/task?id=40530dced4f84010&refresh=10&show_raw=1):

Received fatal exception EXCEPTION_ACCESS_VIOLATION

Backtrace:

	google::protobuf::io::CodedInputStream::ReadTagWithCutoffNoLastTag [0x6DFB7B15+69]
	sync_pb::ClientToServerMessage::MergePartialFromCodedStream [0x039C2873+147]
	google::protobuf::MessageLite::MergeFromCodedStream [0x6E002FCF+95]
	google::protobuf::MessageLite::ParseFromCodedStream [0x6E0030FF+95]
	google::protobuf::MessageLite::ParseFromString [0x6E003535+165]
	google::protobuf::MessageLite::ParseFromString [0x6E0034D0+64]
	fake_server::FakeServer::HandleCommand [0x043C2CEE+718]

Output from failure on win-asan (https://chromium-swarm.appspot.com/task?id=4052dfc867976c10&refresh=10&show_raw=1)

=================================================================
==3920==ERROR: AddressSanitizer: heap-use-after-free on address 0x1299583aa840 at pc 0x7ff7bfeee016 bp 0x00ac5c9d8a80 sp 0x00ac5c9d8ac8
READ of size 8 at 0x1299583aa840 thread T0
==3920==*** WARNING: Failed to initialize DbgHelp!              ***
==3920==*** Most likely this means that the app is already      ***
==3920==*** using DbgHelp, possibly with incompatible flags.    ***
==3920==*** Due to technical reasons, symbolization might crash ***
==3920==*** or produce wrong results.                           ***
[3920:10144:1003/062732.486:WARNING:syncer_proto_util.cc(338)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: CONNECTION_UNAVAILABLE

[3920:10144:1003/062732.486:ERROR:get_updates_processor.cc(242)] PostClientToServerMessage() failed during GetUpdates

    #0 0x7ff7bfeee015 in google::protobuf::MessageLite::ParseFromString C:\b\swarming\w\ir\cache\builder\src\third_party\protobuf\src\google\protobuf\message_lite.cc:207
    #1 0x7ff7c2352ca8 in fake_server::FakeServer::HandleCommand C:\b\swarming\w\ir\cache\builder\src\components\sync\test\fake_server\fake_server.cc:198
    #2 0x7ff7c5bc7cbb in base::internal::Invoker<base::internal::BindState<void (fake_server::FakeServer::*)(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &, const base::RepeatingCallback<void ()> &, int *, int *, std::basic_string<char,std::char_traits<char>,std::allocator<char> > *),base::WeakPtr<fake_server::FakeServer>,base::internal::ConstRefWrapper<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,base::internal::ConstRefWrapper<base::RepeatingCallback<void ()> >,int *,int *,std::basic_string<char,std::char_traits<char>,std::allocator<char> > *>,void ()>::RunOnce C:\b\swarming\w\ir\cache\builder\src\base\bind_internal.h:658

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746f0fd72aaa18424b374e27c8fa99ed68d494fc

commit 746f0fd72aaa18424b374e27c8fa99ed68d494fc
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Wed Oct 03 15:44:33 2018

[Sheriff] Disable TwoClientDictionarySyncTest.Limit on win dbg + asan

This test has been flake-crashing on these bots.

TBR=mamir@chromium.org

Bug: 889505
Change-Id: If527913f0e15f4d298b81c578d17a762f573be0e
Reviewed-on: https://chromium-review.googlesource.com/c/1258966
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596230}
[modify] https://crrev.com/746f0fd72aaa18424b374e27c8fa99ed68d494fc/chrome/browser/sync/test/integration/two_client_dictionary_sync_test.cc

Labels: -Sheriff-Chromium
Removing from sheriff queue now that the test is disabled
Labels: -Pri-1 Pri-2
Owner: mamir@chromium.org
Triage ping: any progress, mamir@?

Sign in to add a comment