New issue
Advanced search Search tips

Issue 889503 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 828317



Sign in to add a comment

Implement local unique name matching based on CoreText

Project Member Reported by drott@chromium.org, Sep 26

Issue description

To cover local unique font name matching on Mac, implement the functionality using CoreText API.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7001c37626a8498e2845a42ea5ed5f4754bc8b01

commit 7001c37626a8498e2845a42ea5ed5f4754bc8b01
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Oct 11 13:32:20 2018

Implement unique font matching for src: local() on Mac

Use CTFont API to match by font descriptor using the
kCTFontNameAttribute key, which matches full font names as well as
postscript names. Return the the match result only if the font name
matches exactly either full font name or postscript name, to avoid
returning fallback fonts that CoreText may have given us.

Bug:  889503 
Change-Id: I835725249a910c79e93bbe13db130d1950d0b49b
Reviewed-on: https://chromium-review.googlesource.com/c/1213090
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598741}
[modify] https://crrev.com/7001c37626a8498e2845a42ea5ed5f4754bc8b01/content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc
[modify] https://crrev.com/7001c37626a8498e2845a42ea5ed5f4754bc8b01/content/test/data/font_src_local_matching.html
[modify] https://crrev.com/7001c37626a8498e2845a42ea5ed5f4754bc8b01/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/7001c37626a8498e2845a42ea5ed5f4754bc8b01/third_party/blink/renderer/platform/fonts/mac/font_cache_mac.mm
[delete] https://crrev.com/b25f9c35e63146e1270640f1d4902a781c803463/third_party/blink/renderer/platform/fonts/mac/font_family_matcher_mac_test.mm
[rename] https://crrev.com/7001c37626a8498e2845a42ea5ed5f4754bc8b01/third_party/blink/renderer/platform/fonts/mac/font_matcher_mac.h
[rename] https://crrev.com/7001c37626a8498e2845a42ea5ed5f4754bc8b01/third_party/blink/renderer/platform/fonts/mac/font_matcher_mac.mm
[add] https://crrev.com/7001c37626a8498e2845a42ea5ed5f4754bc8b01/third_party/blink/renderer/platform/fonts/mac/font_matcher_mac_test.mm

Status: Fixed (was: Started)
Done, only Windows left. 

Sign in to add a comment