New issue
Advanced search Search tips

Issue 889472 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Remove sign-in vote from Password Manager

Project Member Reported by dvadym@chromium.org, Sep 26

Issue description

Password Manager sends crowdsourcing votes for sign-in forms with labeling of fields with Autofill votes. The idea to use autofill votes in such situation is deprecated now. And moreover on the CL https://chromium-review.googlesource.com/c/chromium/src/+/1219710 it's allowed to send normal Password Manager votes for sign-in forms.

So in order to avoid double vote sending and decrease code complexity it's now time to remove sign-in vote sending.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689

commit 0d7ea51d1fbedb0448ddb4fed1fd92e57b297689
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Thu Sep 27 13:31:22 2018

Remove sending sign-in vote in Password Manager.

Password Manager sends crowdsourcing votes for sign-in forms with labeling of fields
 with Autofill votes. The idea to use autofill votes in such situation is deprecated now.
And moreover on the CL https://chromium-review.googlesource.com/c/chromium/src/+/1219710
 it's allowed to send normal Password Manager votes for sign-in forms.

So in order to avoid double vote sending and decrease code complexity it's now time
 to remove sign-in vote sending.

Bug:  889472 , 875768

Change-Id: Ibad10f13b69776a433f6c0a2e2017f234b85a6ec
Reviewed-on: https://chromium-review.googlesource.com/1248626
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594699}
[modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/password_manager/core/browser/votes_uploader.cc
[modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/password_manager/core/browser/votes_uploader.h

Status: Fixed (was: Started)

Sign in to add a comment