Issue metadata
Sign in to add a comment
|
Table borders render incorrectly with border-collapse:collapse and transform:translateY(0)
Reported by
phil.gen...@blueapron.com,
Sep 26
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36 Example URL: https://jsbin.com/pomedukuwu/edit?html,css,output Steps to reproduce the problem: 1. Visit the JSBin (https://jsbin.com/pomedukuwu/edit?html,css,output) 2. Observe that the table borders are all bunching together in the top-left instead of around the cells, as expected. What is the expected behavior? The borders render around the table's content. What went wrong? It seems that the combination of "border-collapse: collapse" on a table and "transform: translateY(0)" (any value for translateY seems to work, not just 0) causes table borders to all display overlapped at the top, instead of (as expected) continuing to display around the table content. This worked in Chrome 68 and works in Firefox 62 and Safari 11.0.1. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Chrome 68 Does this work in other browsers? Yes Chrome version: 69.0.3497.100 Channel: stable OS Version: OS X 10.13.1 Flash Version:
,
Sep 26
Bisects to https://chromium.googlesource.com/chromium/src/+/ec0af3399deb5ea9ea74fc8108d7743b60f6dcc7 Apparently we still needed some offset for this case.
,
Sep 26
Actually the bug occurs with any valid translateY value (e.g. translateY(1px)). The bug doesn't occur for translateY(1) because "1" is not a valid length so the whole translateY is ignored.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3 commit ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Sep 26 22:12:04 2018 [PE] Create ScopedPaintState in TableRowPainter::PaintCollapsedBorders() In order to handle paint offset translation. Bug: 889463 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee36b15e2b823057af66298d2d13727cce12da06 Reviewed-on: https://chromium-review.googlesource.com/1246957 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594498} [add] https://crrev.com/ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/tables/transformed-tbody-tr-collapsed-border-ref.html [add] https://crrev.com/ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/tables/transformed-tbody-tr-collapsed-border.html [modify] https://crrev.com/ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3/third_party/blink/renderer/core/paint/table_row_painter.cc
,
Sep 27
Removing needs-bisect as its already provided in C#2.
,
Sep 28
Verified the fix on 70.0.3564.0.
,
Sep 28
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 28
Correction to #c6: the version is 71.0.3564.0.
,
Sep 28
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e325cf6cc7e15c44f5904d2e7506f05cfb6e15cb commit e325cf6cc7e15c44f5904d2e7506f05cfb6e15cb Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Sep 28 17:25:14 2018 [PE] Create ScopedPaintState in TableRowPainter::PaintCollapsedBorders() In order to handle paint offset translation. TBR=wangxianzhu@chromium.org (cherry picked from commit ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3) Bug: 889463 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee36b15e2b823057af66298d2d13727cce12da06 Reviewed-on: https://chromium-review.googlesource.com/1246957 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594498} Reviewed-on: https://chromium-review.googlesource.com/1252142 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#737} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [add] https://crrev.com/e325cf6cc7e15c44f5904d2e7506f05cfb6e15cb/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/tables/transformed-tbody-tr-collapsed-border-ref.html [add] https://crrev.com/e325cf6cc7e15c44f5904d2e7506f05cfb6e15cb/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/tables/transformed-tbody-tr-collapsed-border.html [modify] https://crrev.com/e325cf6cc7e15c44f5904d2e7506f05cfb6e15cb/third_party/blink/renderer/core/paint/table_row_painter.cc
,
Sep 28
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e325cf6cc7e15c44f5904d2e7506f05cfb6e15cb Commit: e325cf6cc7e15c44f5904d2e7506f05cfb6e15cb Author: wangxianzhu@chromium.org Commiter: wangxianzhu@chromium.org Date: 2018-09-28 17:25:14 +0000 UTC [PE] Create ScopedPaintState in TableRowPainter::PaintCollapsedBorders() In order to handle paint offset translation. TBR=wangxianzhu@chromium.org (cherry picked from commit ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3) Bug: 889463 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee36b15e2b823057af66298d2d13727cce12da06 Reviewed-on: https://chromium-review.googlesource.com/1246957 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#594498} Reviewed-on: https://chromium-review.googlesource.com/1252142 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#737} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/498f19c4eacf29fe57b8e272ed3af32bf42a2da1 Commit: 498f19c4eacf29fe57b8e272ed3af32bf42a2da1 Author: wangxianzhu@chromium.org Commiter: wangxianzhu@chromium.org Date: 2018-09-28 21:02:37 +0000 UTC Fix build break in M70 branch after https://chromium-review.googlesource.com/1252142 TBR=chrishtr@chromium.org Bug: 889463 ,890447 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfca6c11b6162139101ed7187f1f9b1281c85659 Reviewed-on: https://chromium-review.googlesource.com/1252744 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#751} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/498f19c4eacf29fe57b8e272ed3af32bf42a2da1 commit 498f19c4eacf29fe57b8e272ed3af32bf42a2da1 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Sep 28 21:02:37 2018 Fix build break in M70 branch after https://chromium-review.googlesource.com/1252142 TBR=chrishtr@chromium.org Bug: 889463 ,890447 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfca6c11b6162139101ed7187f1f9b1281c85659 Reviewed-on: https://chromium-review.googlesource.com/1252744 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#751} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/498f19c4eacf29fe57b8e272ed3af32bf42a2da1/third_party/blink/renderer/core/paint/table_row_painter.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vamshi.kommuri@chromium.org
, Sep 26