New issue
Advanced search Search tips

Issue 889461 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Search box alignment in bookmarks is broken on changing the device orientation from landscape to portrait mode

Project Member Reported by pmadalla@chromium.org, Sep 26

Issue description

App Version: 71.0.3561.0 Canary
iOS Version: 10.3.3 only
Device: iPhones only

Precondition:
1- Have some bookmarks saved

Steps to reproduce:
1. Launch Chrome in Landscape mode.
2. Tap on Search
3. Change the device orientation to portrait mode.
4. Tap on Cancel.
5. Tap on Search and Scroll the bookmarks upwards.
  
Observed results: 
Search box alignment in bookmarks is broken. 

Expected results: 
Search box alignment in bookmarks should be in fixed position both in portrait and landscape mode.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA    
Bug reproducible on Dolphin/Safari/Firefox: Safari : NA
Bug reproducible on the current stable channel build : NA New Implementation in  M71
Bug reproducible on the current beta channel build : NA New Implementation in  M71

Link to video/image: 
Video :
https://drive.google.com/file/d/1SmgSkXVJ8oIpPhy73tU2XFvqqGzt-TL3/view?usp=sharing

Image :
https://drive.google.com/file/d/1jYGjp5PTNRZwTE0RdnC530qNxut87Tww/view?usp=sharing

 
Cc: sczs@chromium.org
Components: UI>Browser>Bookmarks
Owner: djean@chromium.org
Status: Assigned (was: Untriaged)
djean@ could you PTAL?
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12234dec99844811341abe269be29519ebab735b

commit 12234dec99844811341abe269be29519ebab735b
Author: David Jean <djean@google.com>
Date: Tue Oct 02 07:32:59 2018

[ios] Fixed history/bookmarks scrim issues

- Resize on rotation.
- Disable scrolling of table when active.

Bug:  889012 ,889506,  889461 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I54d4f41d31a0fb3ec7e248a3cb25bb985e58cf72
Reviewed-on: https://chromium-review.googlesource.com/1249483
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595750}
[modify] https://crrev.com/12234dec99844811341abe269be29519ebab735b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/12234dec99844811341abe269be29519ebab735b/ios/chrome/browser/ui/history/history_table_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified the issue on the build 71.0.3574.0 Canary tested on the device iPhone6(iOS 10)
Search box alignment in bookmarks is in fixed position both in portrait and landscape mode, looks good

Sign in to add a comment