New issue
Advanced search Search tips

Issue 889456 link

Starred by 1 user
Status: Fixed
Owner:
marinaciocea@chromium.org
Closed: Sep 26
Cc:
thestig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Pdf build dependencies cause Win build to intermittently fail to compile

Project Member Reported by marinaciocea@chromium.org, Sep 26 
Soon after [1] landed win bot started to intermittently fail[2][3] to compile, depending on file compile order:

FAILED: obj/pdf/pdf_test_utils/test_document_loader.obj
In file included from ../../pdf/test/test_document_loader.cc:8:
In file included from ../..\base/files/file_util.h:25:
In file included from ../..\base/files/file.h:15:
In file included from ../..\base/files/platform_file.h:12:
In file included from ../..\base/win/scoped_handle.h:12:
../..\base/location.h(14,10):  fatal error: 'base/debug/debugging_buildflags.h' file not found
#include "base/debug/debugging_buildflags.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Reverting the CL for now, please have a look into fixing build dependencies. 

[1] https://crrev.com/5fbe87da9e75d17c9789d27a949f05350aae855a
[2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/3273
[3] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel?limit=50
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e3dbd0d31015b9f931f496c0d771461dc395c1f

commit 7e3dbd0d31015b9f931f496c0d771461dc395c1f
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Wed Sep 26 12:41:55 2018

Revert "Move PDF test classes out of findtext_unittest.cc."

This reverts commit 5fbe87da9e75d17c9789d27a949f05350aae855a.

Reason for revert: causing intermittent win build failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/3273
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel?limit=50
 https://crbug.com/889456 

Original change's description:
> Move PDF test classes out of findtext_unittest.cc.
> 
> Make them available to other unit tests.
> 
> Change-Id: If1166a9611b4b5455440ceb75c449f61e4cbb8ce
> Reviewed-on: https://chromium-review.googlesource.com/1244112
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594139}

TBR=rharrison@chromium.org,thestig@chromium.org,hnakashima@google.com,hnakashima@chromium.org

Bug:  889456 
Change-Id: Ice337c29d02dd4e64e72a743dadb5f2ba675dfbc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1245704
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594290}
[modify] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/pdf/BUILD.gn
[modify] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/pdf/pdfium/findtext_unittest.cc
[delete] https://crrev.com/93ca9993020d49cea34bde56e503726bccada8d2/pdf/pdfium/pdfium_test_base.cc
[delete] https://crrev.com/93ca9993020d49cea34bde56e503726bccada8d2/pdf/pdfium/pdfium_test_base.h
[delete] https://crrev.com/93ca9993020d49cea34bde56e503726bccada8d2/pdf/test/test_client.cc
[delete] https://crrev.com/93ca9993020d49cea34bde56e503726bccada8d2/pdf/test/test_client.h
[delete] https://crrev.com/93ca9993020d49cea34bde56e503726bccada8d2/pdf/test/test_document_loader.cc
[delete] https://crrev.com/93ca9993020d49cea34bde56e503726bccada8d2/pdf/test/test_document_loader.h

Comment 2 by thestig@chromium.org, Sep 26

Cc: -marinaciocea@chromium.org thestig@chromium.org
Components: Internals>Plugins>PDF
Owner: marinaciocea@chromium.org
Status: Fixed (was: Assigned)
Thanks for reverting. I'll try to fix this before relanding.
►

Sign in to add a comment