New issue
Advanced search Search tips

Issue 889435 link

Starred by 1 user
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Sep 26
Cc:
nyerramilli@chromium.org
cbiesin...@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] Weird overlapping is observed after recording activity into 'Coverage' section.

Reported by db...@etouch.net, Sep 26 
Chrome Version:71.0.3562.0 (Official Build)  546b39eb7822fcd38f6c8093cb3ac1a70f8f2dcf-refs/branch-heads/3562@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14). 

What steps will reproduce the problem?
(1) Launch chrome,open NTP and then open devtools window on it.
(2) Press Esc to open Console section then navigate to Coverage section.
(3) Record some activity and observe.

Actual: Weird overlapping is observed after recording activity into 'Coverage' section.

Expected: No such a overlapping should seen.

This is a regression issue, broken in 'M71', will soon update the other info:

Good Build:71.0.3560.0(Revision: 593539)
Bad Build: 71.0.3561.0(Revision: 593801)
Actual_Devtools.mov
8.2 MB View Download
Expected_Devtools.mov
7.8 MB View Download

Comment 1 by db...@etouch.net, Sep 26

Components: Platform>DevTools
Labels: hasbisect
Owner: cbiesin...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 594043 (known good), but no later than 594083 (first known bad).

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/ef3b56e85a9ac946b4d9aba5e113470eedabf684..8d62c04a52d001bf62879a1b0b22e0ba030f9456?pretty=fuller&n=100

Suspecting: https://chromium.googlesource.com/chromium/src/+/d572ce1da8fb90cdbab05eb3d2902af0c0a97d07 ?

@cbiesinger: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Provided suspect through 'Chromium' bisect as unable to perform bisect using 'per-revision' bisect script 
2. Tried performing 'per revision' bisect on multiple Windows,Linux and Mac machines but unable to perform the same since getting error: "RuntimeError: We don't have enough builds to bisect". 

Thank you.

Comment 2 by cbiesin...@chromium.org, Sep 26

Status: Started (was: Assigned)
Confirmed that my change caused this, reverting in https://chromium-review.googlesource.com/c/chromium/src/+/1246291
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82ef33772f758883cda6379610b24f27e7ff3bbe

commit 82ef33772f758883cda6379610b24f27e7ff3bbe
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Wed Sep 26 18:30:55 2018

Revert "[css-flex] Update to newer spec about definite flex item sizes"

This reverts commit d572ce1da8fb90cdbab05eb3d2902af0c0a97d07.

Reason for revert: Caused regression  crbug.com/889435 

Original change's description:
> [css-flex] Update to newer spec about definite flex item sizes
>
> Implements this change:
> https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8
>
> external/wpt/css/css-flexbox/percentage-heights-003.html ostensibly tests
> this, but I don't think the test is correct (and we don't pass it)
>
> TESTED=css3/flexbox/definite-main-size.html
>
> Bug:  784059 
> Change-Id: I8ee0ee797b54a8166849ab6e9b9f019b9e43760b
> Reviewed-on: https://chromium-review.googlesource.com/1240871
> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593707}

TBR=cbiesinger@chromium.org,dgrogan@chromium.org,eae@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  784059 , 889435 
Change-Id: Ia74fb5cf500aebcb876672497cce5295b0959b43
Reviewed-on: https://chromium-review.googlesource.com/1246291
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594399}
[modify] https://crrev.com/82ef33772f758883cda6379610b24f27e7ff3bbe/third_party/WebKit/LayoutTests/css3/flexbox/definite-main-size.html
[modify] https://crrev.com/82ef33772f758883cda6379610b24f27e7ff3bbe/third_party/blink/renderer/core/layout/layout_flexible_box.cc

Comment 4 by cbiesin...@chromium.org, Sep 26

Status: Fixed (was: Started)

Comment 5 by cbiesin...@chromium.org, Sep 27

Cc: cbiesin...@chromium.org
 Issue 889860  has been merged into this issue.
►

Sign in to add a comment