New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 889423 link

Starred by 1 user
Status: Fixed
Owner:
rayankans@chromium.org
Closed: Oct 11
Cc:
█ nancygao@chromium.org
dtrainor@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Paused download notifications don't show up on browser restarts

Project Member Reported by rayankans@chromium.org, Sep 26 
Steps to reproduce:

1. Start a Background Fetch
2. Pause it (Note: this requires the changes in https://chromium-review.googlesource.com/c/chromium/src/+/1241157 to work)
3. Crash chrome
4. Restart it

Expectation: We should see a paused download notification on restart. 
Reality: No notification is shown and the fetch is pending forever.

The notification does still show up if the browser is restarted while the download is in progress, and continues normally.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab12365a90c4ad675152a616462129d411696529

commit ab12365a90c4ad675152a616462129d411696529
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Oct 05 18:23:50 2018

[Background Fetch] Show paused fetches on browser restart.

Paused fetch notifications were not displayed on browser start-up. This
means that the fetch could not be resumed and is forever paused.

The state of the entry needs to be exposed on DS initialization, so
that paused items can notify the OfflineContentAggregator and display a
notification.

Bug:  889423 
Change-Id: Ia61c903f6234264821aad20b7bb93d6a3fdeb447
Reviewed-on: https://chromium-review.googlesource.com/c/1251630
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597204}
[modify] https://crrev.com/ab12365a90c4ad675152a616462129d411696529/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier2.java
[modify] https://crrev.com/ab12365a90c4ad675152a616462129d411696529/chrome/browser/background_fetch/background_fetch_delegate_factory.cc
[modify] https://crrev.com/ab12365a90c4ad675152a616462129d411696529/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/ab12365a90c4ad675152a616462129d411696529/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/ab12365a90c4ad675152a616462129d411696529/chrome/browser/background_fetch/background_fetch_download_client.cc
[modify] https://crrev.com/ab12365a90c4ad675152a616462129d411696529/components/download/internal/background_service/entry_utils.cc
[modify] https://crrev.com/ab12365a90c4ad675152a616462129d411696529/components/download/public/background_service/download_metadata.cc
[modify] https://crrev.com/ab12365a90c4ad675152a616462129d411696529/components/download/public/background_service/download_metadata.h

Comment 2 by dtrainor@chromium.org, Oct 10

Cc: dtrainor@chromium.org nancygao@chromium.org
Owner: rayankans@chromium.org
Status: Assigned (was: Untriaged)
These technically don't reshow for actual downloads.  If the user swipes it away, we leave it in downloads home but don't expose it to the notification layer again until the user triggers some update for it (usually a resume).  If you want this to show again for background fetch, kicking OnItemUpdated() on start should do it :).

Is the notification vanishing when Chrome quits?  It probably shouldn't.

Comment 3 by rayankans@chromium.org, Oct 11

Status: Fixed (was: Assigned)
Thanks David, that's exactly what the submitted CL does, I'll mark this as fixed.

It doesn't, but the notification will disappear if you force-quit the app.
►

Sign in to add a comment