New issue
Advanced search Search tips

Issue 889407 link

Starred by 1 user
Status: Fixed
Owner:
hidehiko@chromium.org
Closed: Dec 2
Cc:
derat@chromium.org
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Translate printer tests into tast.

Project Member Reported by hidehiko@chromium.org, Sep 26 
This is the tracking issue.

Target tests:
platform_CUPSDaemon.
platform_AddPrinter.generic
platform_DebugDaemonCupsAddPrinters

Note:
Need to add SoftwareDependency to look at "CUPS" use flag.
Need to add data file to be printed.
Need to talk to upstart. Some tests checks with systemd instead, but AFAIK, tast didn't run on such devices. I'm planning to just let test fail if systemd is used. If tast starts to support those devices, we need to revisit there anyway, and failure can be the marker for such revisit.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/9cc551c3c75f8a571255236c7ca29d693f10001b

commit 9cc551c3c75f8a571255236c7ca29d693f10001b
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Sep 28 13:26:05 2018

tast-tests: Add printer.CUPSD

This is translated from autotest platform_CUPSDaemon.

BUG= chromium:889407 
TEST=Ran on DUT.
CQ-DEPEND=CL:1245646

Change-Id: I97e83ec7e7ddc725b25cb0981f75896738a169b0
Reviewed-on: https://chromium-review.googlesource.com/1245582
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[modify] https://crrev.com/9cc551c3c75f8a571255236c7ca29d693f10001b/src/chromiumos/tast/local/bundles/cros/main.go
[add] https://crrev.com/9cc551c3c75f8a571255236c7ca29d693f10001b/src/chromiumos/tast/local/bundles/cros/printer/cupsd.go
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8def69f80673603f12a28a140b0480ca81fa5124

commit 8def69f80673603f12a28a140b0480ca81fa5124
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Sep 28 13:26:04 2018

tast-use-flags: Add "cups" USE flag to the tast_use_flags.txt.

BUG= chromium:889407 
TEST=Build and /usr/local/etc/tast_use_flags.txt contains "cups".

Change-Id: I955b076160fd2dcd160d68f54c8e60a254a1d963
Reviewed-on: https://chromium-review.googlesource.com/1246341
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[rename] https://crrev.com/8def69f80673603f12a28a140b0480ca81fa5124/chromeos-base/tast-use-flags/tast-use-flags-0.0.1-r9.ebuild
[modify] https://crrev.com/8def69f80673603f12a28a140b0480ca81fa5124/chromeos-base/tast-use-flags/tast-use-flags-0.0.1.ebuild
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/c9c3413ae38c19fe784d1858617b212de1949df9

commit c9c3413ae38c19fe784d1858617b212de1949df9
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Sep 28 13:26:04 2018

tast: Add "cups" software dependency.

Looks at "cups" USE flag.

BUG= chromium:889407 
TEST=Ran on DUT.
CQ-DEPEND=CL:1246341

Change-Id: I62e4981faad43f91b53af7b3cc06c3cae5d1e0a5
Reviewed-on: https://chromium-review.googlesource.com/1245646
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/c9c3413ae38c19fe784d1858617b212de1949df9/src/chromiumos/cmd/local_test_runner/main.go
[modify] https://crrev.com/c9c3413ae38c19fe784d1858617b212de1949df9/docs/test_dependencies.md

Comment 4 by hidehiko@chromium.org, Oct 1

Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/6650b0a626b8b939765cd10100c360a5e66a9084

commit 6650b0a626b8b939765cd10100c360a5e66a9084
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Oct 02 16:17:18 2018

tast-test: Add debugd.Printer.

This is translated from platform_DebugDaemonCupsAddPrinters autotest.

BUG= chromium:889407 
TEST=Ran on DUT.
CQ-DEPEND=CL:1254701

Change-Id: I3191c15cb874fb205babf7e87d882d4eaef91545
Reviewed-on: https://chromium-review.googlesource.com/1254761
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[add] https://crrev.com/6650b0a626b8b939765cd10100c360a5e66a9084/src/chromiumos/tast/local/debugd/debugd.go
[modify] https://crrev.com/6650b0a626b8b939765cd10100c360a5e66a9084/src/chromiumos/tast/local/bundles/cros/main.go
[add] https://crrev.com/6650b0a626b8b939765cd10100c360a5e66a9084/src/chromiumos/tast/local/bundles/cros/debugd/printer.go
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2b05d9fde5b7fe87873ea909b8d2fd4f9461a02b

commit 2b05d9fde5b7fe87873ea909b8d2fd4f9461a02b
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Oct 02 16:17:18 2018

tast: Add GenericPostScript.ppd.gz data.

The file will be used by debugd CUPS related tests.

BUG= chromium:889407 
TEST=Ran on DUT.

Change-Id: I6d1d9c8251060e919e489ed571385493ec41d93a
Reviewed-on: https://chromium-review.googlesource.com/1254701
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/2b05d9fde5b7fe87873ea909b8d2fd4f9461a02b/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild
[modify] https://crrev.com/2b05d9fde5b7fe87873ea909b8d2fd4f9461a02b/chromeos-base/tast-local-tests-cros/Manifest
[modify] https://crrev.com/2b05d9fde5b7fe87873ea909b8d2fd4f9461a02b/chromeos-base/tast-local-tests-cros/files/external_data.conf
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/b5f7331a31496449e5ead1ea2faee4462d6b7f1e

commit b5f7331a31496449e5ead1ea2faee4462d6b7f1e
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Nov 07 04:19:30 2018

tast: Extract unified diff as a library.

The diff function can be used from tests. This is useful for
the tests taking diff from the golden file.

BUG= chromium:889407 
TEST=Ran ./fast_build -T

Change-Id: I24cac7950947933b694c7fa291d40d6fe59ccc57
Reviewed-on: https://chromium-review.googlesource.com/1309576
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[modify] https://crrev.com/b5f7331a31496449e5ead1ea2faee4462d6b7f1e/src/chromiumos/cmd/tast-lint/check/import_order.go
[add] https://crrev.com/b5f7331a31496449e5ead1ea2faee4462d6b7f1e/src/chromiumos/tast/diff/diff.go
[add] https://crrev.com/b5f7331a31496449e5ead1ea2faee4462d6b7f1e/src/chromiumos/tast/diff/diff_test.go
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/c244a3f70c3da8d3c6611cf2287d0d3cb904221e

commit c244a3f70c3da8d3c6611cf2287d0d3cb904221e
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Nov 09 15:20:03 2018

tast-test: port platform_AddPrinter.generic.

BUG= chromium:889407 
TEST=Ran on DUT.
CQ-DEPEND=CL:1309576, CL:1309793

Change-Id: Ie9253091c79a84e88789c63ed82a92662c2940d8
Reviewed-on: https://chromium-review.googlesource.com/1309442
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[add] https://crrev.com/c244a3f70c3da8d3c6611cf2287d0d3cb904221e/src/chromiumos/tast/local/bundles/cros/printer/add_generic_printer.go
[add] https://crrev.com/c244a3f70c3da8d3c6611cf2287d0d3cb904221e/src/chromiumos/tast/local/bundles/cros/printer/fake/printer.go
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/eeccb314c199ad935234b69b89649cd7b537c976

commit eeccb314c199ad935234b69b89649cd7b537c976
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Nov 15 10:17:06 2018

tast-test: Extract ComponentUpdater D-Bus proxy into struct.

To reuse it from more tests than VM.

BUG= chromium:889407 
TEST=Build.

Change-Id: I217f2944b46188edb7916be831593484eceb703d
Reviewed-on: https://chromium-review.googlesource.com/1333295
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/eeccb314c199ad935234b69b89649cd7b537c976/src/chromiumos/tast/local/vm/termina.go
[add] https://crrev.com/eeccb314c199ad935234b69b89649cd7b537c976/src/chromiumos/tast/local/compupdater/compupdater.go
[modify] https://crrev.com/eeccb314c199ad935234b69b89649cd7b537c976/src/chromiumos/tast/local/vm/util.go

Comment 13 by hidehiko@chromium.org, Dec 2

Status: Fixed (was: Started)
►

Sign in to add a comment