content_browsertests BackgroundTracingManagerBrowserTest.ToggleBlinkScenarios cannot be run with custom blink feature flags |
|||
Issue descriptionThe test fails when being run with custom blink feature flags set, e.g. out/Debug/content_browsertests --enable-blink-features=RandomFeatureFlag --gtest_filter=BackgroundTracingManagerBrowserTest.ToggleBlinkScenarios IIUC, this means that bots that are supposed to test features need to somehow white or blacklist that test.
,
Sep 26
IIUC, then we should not do anything if flags are set explicitly [1]. Looks like the right solution should be an early bail out in this case. [1] https://cs.chromium.org/chromium/src/content/browser/tracing/background_tracing_manager_impl.cc?sq=package:chromium&g=0&l=196
,
Sep 26
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11a17dd74ef21b26e7142fc130bd039bc8c45bce commit 11a17dd74ef21b26e7142fc130bd039bc8c45bce Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Sep 27 13:02:10 2018 [tracing] Fix ToggleBlinkScenarios test when launched with custom flags Tracing bails out when encountering that flags already have been set explicitly. Also make the test bail out in this case. Bug: 889396 Change-Id: Ic438a15f136e964f0c9bd1a123a8ae230ffab850 Reviewed-on: https://chromium-review.googlesource.com/1245367 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594692} [modify] https://crrev.com/11a17dd74ef21b26e7142fc130bd039bc8c45bce/content/browser/tracing/background_tracing_manager_browsertest.cc
,
Sep 27
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/9ba3159e0ec34bfb22ed1053eb455b3c50b8cff6 commit 9ba3159e0ec34bfb22ed1053eb455b3c50b8cff6 Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Oct 01 18:52:36 2018 tracing: Fix Blink metrics and add unified GC total sum - Add missing top-level events for Blink - Replace atomic marking event with general atomic GC phase - Introduce unified GC total sum containing both the V8 and Blink events Bug: chromium:889396 Change-Id: I16c21018c882da84cf79c0c1bce110974507aa26 Reviewed-on: https://chromium-review.googlesource.com/1249148 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> [modify] https://crrev.com/9ba3159e0ec34bfb22ed1053eb455b3c50b8cff6/tracing/tracing/metrics/v8/gc_metric.html [modify] https://crrev.com/9ba3159e0ec34bfb22ed1053eb455b3c50b8cff6/tracing/tracing/metrics/blink/gc_metric.html [modify] https://crrev.com/9ba3159e0ec34bfb22ed1053eb455b3c50b8cff6/tracing/tracing/metrics/v8/utils.html [modify] https://crrev.com/9ba3159e0ec34bfb22ed1053eb455b3c50b8cff6/tracing/tracing/metrics/blink/gc_metric_test.html
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46fd327b669499295800940d58567ec7b5a9a19e commit 46fd327b669499295800940d58567ec7b5a9a19e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Oct 02 01:03:55 2018 Roll src/third_party/catapult 69f64b270397..2ba11d1c2b02 (7 commits) https://chromium.googlesource.com/catapult.git/+log/69f64b270397..2ba11d1c2b02 git log 69f64b270397..2ba11d1c2b02 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 eakuefner@chromium.org [Dashboard] Key histogram uploads by revision timestamp if necessary 2018-10-01 benjhayden@chromium.org Add option-group for v2spa 2018-10-01 sadrul@chromium.org trace-viewer: Add a close-button to hide a process. 2018-10-01 benjhayden@chromium.org Add column-head for v2spa 2018-10-01 simonhatch@chromium.org Dashboard - Add a diagnostic for the build url. 2018-10-01 benjhayden@chromium.org Add cp-toast for v2spa. 2018-10-01 mlippautz@chromium.org tracing: Fix Blink metrics and add unified GC total sum Created with: gclient setdep -r src/third_party/catapult@2ba11d1c2b02 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:884961 , chromium:889396 TBR=sullivan@chromium.org Change-Id: Ica59de5ef959096a97c5d76b961b0bd56d06df0a Reviewed-on: https://chromium-review.googlesource.com/1255570 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595672} [modify] https://crrev.com/46fd327b669499295800940d58567ec7b5a9a19e/DEPS
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a commit 9675cc09e8b35b7c1e2ad15e9827df456c01cb4a Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Oct 02 11:35:50 2018 Replace V8 GC calls with API call Avoid calling the string version of 'gc()'. Bug: 889396 Change-Id: I752b7726d11c748c441cc119d015f21a45529305 Reviewed-on: https://chromium-review.googlesource.com/1254204 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595798} [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/public/web/web_local_frame.h [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/bindings/core/v8/dom_wrapper_world_test.cc [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/bindings/core/v8/script_wrappable_v8_gc_integration_test.cc [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/bindings/core/v8/v8_gc_controller.cc [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/bindings/core/v8/v8_gc_controller.h [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/core/exported/prerendering_test.cc [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/core/frame/web_local_frame_impl.h [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/platform/bindings/dom_wrapper_world.cc [modify] https://crrev.com/9675cc09e8b35b7c1e2ad15e9827df456c01cb4a/third_party/blink/renderer/platform/bindings/dom_wrapper_world.h
,
Oct 2
Ugh, the last two CLs are for issue 843903 and don't have anything to do with this bug. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mlippautz@chromium.org
, Sep 26+oysteine after talking to primiano Failure: ../../content/browser/tracing/background_tracing_manager_browsertest.cc:621: Failure Value of: scenario_activated Actual: false Expected: true Stack trace: #0 0x0000019ee9e0 StackTraceGetter::CurrentStackTrace() #1 0x000001a13c87 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x000001a130ed testing::internal::AssertHelper::operator=() #3 0x0000014df2d2 content::BackgroundTracingManagerBrowserTest_ToggleBlinkScenarios_Test::RunTestOnMainThread() #4 0x0000028f8143 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x000000d0390d _ZN4base8internal13FunctorTraitsIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #6 0x000000d03884 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJPS5_EEEvOT_DpOT0_ #7 0x000000d03835 _ZN4base8internal7InvokerINS0_9BindStateIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #8 0x000000ed4c5c _ZN4base8internal7InvokerINS0_9BindStateIMNS_12MockCallbackINS_17RepeatingCallbackIFvvEEEEEFvvEJNS0_17UnretainedWrapperIS7_EEEEES5_E3RunEPNS0_13BindStateBaseE #9 0x000000baa79d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #10 0x000002b617cd content::ShellBrowserMainParts::PreMainMessageLoopRun() #11 0x7f9ae9fee4cc content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x7f9ae8ce7d5d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #13 0x7f9ae8ce7cd4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_ #14 0x7f9ae8ce7c85 _ZN4base8internal7InvokerINS0_9BindStateIMN7content12ChildProcessEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7f9ae8ceab1c _ZN4base8internal7InvokerINS0_9BindStateIMN7content14ServiceFactoryEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #16 0x7f9ae8bf9f7d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #17 0x7f9aeae0441d content::StartupTaskRunner::RunAllTasksNow() #18 0x7f9ae9fe9b4f content::BrowserMainLoop::CreateStartupTasks() #19 0x7f9ae9ff6761 content::BrowserMainRunnerImpl::Initialize() #20 0x000002b60228 ShellBrowserMain() #21 0x000002a87b9d content::ShellMainDelegate::RunProcess() #22 0x7f9aebeb1d5e content::RunBrowserProcessMain() #23 0x7f9aebeb467b content::ContentMainRunnerImpl::Run() #24 0x7f9aebea957c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #25 0x7f9adfff17fa service_manager::Main() #26 0x7f9aebeaf7d3 content::ContentMain() #27 0x0000028f7658 content::BrowserTestBase::SetUp() #28 0x0000028d8ac8 content::ContentBrowserTest::SetUp() #29 0x000001789bee _ZN7testing8internal12InvokeHelperIvNSt3__15tupleIJEEEE12InvokeMethodIN4base7RunLoopEMS8_FvvEEEvPT_T0_RKS4_ ../../content/browser/tracing/background_tracing_manager_browsertest.cc:632: Failure Expected equality of these values: command_line->GetSwitchValueASCII(switches::kEnableBlinkFeatures) Which is: "HeapIncrementalMarkingStress" "FasterWeb1,FasterWeb2" Stack trace: #0 0x0000019ee9e0 StackTraceGetter::CurrentStackTrace() #1 0x000001a13c87 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x000001a130ed testing::internal::AssertHelper::operator=() #3 0x0000014df685 content::BackgroundTracingManagerBrowserTest_ToggleBlinkScenarios_Test::RunTestOnMainThread() #4 0x0000028f8143 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x000000d0390d _ZN4base8internal13FunctorTraitsIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #6 0x000000d03884 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJPS5_EEEvOT_DpOT0_ #7 0x000000d03835 _ZN4base8internal7InvokerINS0_9BindStateIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #8 0x000000ed4c5c _ZN4base8internal7InvokerINS0_9BindStateIMNS_12MockCallbackINS_17RepeatingCallbackIFvvEEEEEFvvEJNS0_17UnretainedWrapperIS7_EEEEES5_E3RunEPNS0_13BindStateBaseE #9 0x000000baa79d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #10 0x000002b617cd content::ShellBrowserMainParts::PreMainMessageLoopRun() #11 0x7f9ae9fee4cc content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x7f9ae8ce7d5d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #13 0x7f9ae8ce7cd4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_ #14 0x7f9ae8ce7c85 _ZN4base8internal7InvokerINS0_9BindStateIMN7content12ChildProcessEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7f9ae8ceab1c _ZN4base8internal7InvokerINS0_9BindStateIMN7content14ServiceFactoryEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #16 0x7f9ae8bf9f7d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #17 0x7f9aeae0441d content::StartupTaskRunner::RunAllTasksNow() #18 0x7f9ae9fe9b4f content::BrowserMainLoop::CreateStartupTasks() #19 0x7f9ae9ff6761 content::BrowserMainRunnerImpl::Initialize() #20 0x000002b60228 ShellBrowserMain() #21 0x000002a87b9d content::ShellMainDelegate::RunProcess() #22 0x7f9aebeb1d5e content::RunBrowserProcessMain() #23 0x7f9aebeb467b content::ContentMainRunnerImpl::Run() #24 0x7f9aebea957c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #25 0x7f9adfff17fa service_manager::Main() #26 0x7f9aebeaf7d3 content::ContentMain() #27 0x0000028f7658 content::BrowserTestBase::SetUp() #28 0x0000028d8ac8 content::ContentBrowserTest::SetUp() #29 0x000001789bee _ZN7testing8internal12InvokeHelperIvNSt3__15tupleIJEEEE12InvokeMethodIN4base7RunLoopEMS8_FvvEEEvPT_T0_RKS4_