New issue
Advanced search Search tips

Issue 889391 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 888259
Owner: ----
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Run go vet in repo preupload hook.

Project Member Reported by hidehiko@chromium.org, Sep 26

Issue description

Context:
https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1235874/6/src/chromiumos/tast/local/bundles/cros/security/open_fds.go#44

go vet can fail. It will be nice if we can run it in preupload hook, because developers can know the failure quickly.

Local experiment:

cd ${chromeosroot}/platform/tast-tests
GOPATH=${chromeosroot}/chroot/usr/lib/gopath:${chromeosroot}/src/platform/tast:${chromeosroot}/platform/tast-tests go vet chromiumos/tast/local/...

worked successfully on my local dev env at least.
 
Mergedinto: 888259
Status: Duplicate (was: Untriaged)
We can probably continue to use  issue 888259  to track this (since it already has some pre-upload discussion). I'll paste your comment there.

Sign in to add a comment