New issue
Advanced search Search tips

Issue 889390 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 888476



Sign in to add a comment

Clang ToT Android builds failing with "Instruction does not dominate all uses!"

Project Member Reported by h...@chromium.org, Sep 26

Issue description

Looks like all the tot android bots are red with this and have been for a while.

Example from
https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/4843




FAILED: obj/third_party/opus/opus/LPC_analysis_filter.o 
../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/opus/opus/LPC_analysis_filter.o.d -DOPUS_BUILD -DOPUS_EXPORT= -DHAVE_LRINT -DHAVE_LRINTF -DVAR_ARRAYS -DFIXED_POINT -DOPUS_ARM_ASM -DOPUS_ARM_INLINE_ASM -DOPUS_ARM_INLINE_EDSP -DOPUS_ARM_MAY_HAVE_EDSP -DOPUS_ARM_MAY_HAVE_MEDIA -DOPUS_HAVE_RTCD -DOPUS_ARM_MAY_HAVE_NEON -DOPUS_ARM_MAY_HAVE_NEON_INTR -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DSAFE_BROWSING_DB_REMOTE -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_GNU_SOURCE -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION_ROLL=r16_1 -DCR_CLANG_REVISION=\"343072\" -D__GNU_SOURCE=1 -DCHROMIUM_CXX_TWEAK_INLINES -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DOPUS_FIXED_POINT -I../../third_party/opus/src -I../../third_party/opus/src/celt -I../../third_party/opus/src/silk -I../../third_party/opus/src/silk/fixed -I../.. -Igen -I../../third_party/opus/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -ffunction-sections -fno-short-enums --target=arm-linux-androideabi -isystem../../third_party/android_ndk/sysroot/usr/include/arm-linux-androideabi -D__ANDROID_API__=16 -DHAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC=1 -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mfpu=neon -mthumb -fomit-frame-pointer -gdwarf-3 -g1 -fdebug-info-for-profiling -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -O3 -fno-ident -fdata-sections -ffunction-sections -std=c11 --sysroot=../../third_party/android_ndk/sysroot -c ../../third_party/opus/src/silk/LPC_analysis_filter.c -o obj/third_party/opus/opus/LPC_analysis_filter.o
Instruction does not dominate all uses!
  %59 = ashr i32 %56, 16, !dbg !37
  %mul41.us = mul nsw i32 %conv40.us, %59, !dbg !36
in function silk_LPC_analysis_filter
 
The bots were red before due to the thread safety annotation thing ( Issue 887610 ) and then the miscompiled clang problem ( Issue 888061 )

https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/4812

is the first build with this error.
Build 4812 used Clang r342967.

Attaching the repro.
LPC_analysis_filter-f833b3.c
475 KB View Download
LPC_analysis_filter-f833b3.sh
8.9 KB View Download
Shorter invocation

$ clang -cc1 -triple thumbv7-unknown-linux-android -emit-obj -target-cpu generic -O3 -std=c11 -vectorize-loops -x c /tmp/LPC_analysis_filter-f833b3.c
Status: Fixed (was: Assigned)
The culprit was LLVM r342870

Reverted in r343082
This was also affecting the ToTiOSDevice bot. I can't get to the build page due to  Issue 889399  but the logdog link works: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTiOSDevice%2F99%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Sign in to add a comment