New issue
Advanced search Search tips

Issue 889389 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Sep 27
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Spacing between 'Pages' drop down and 'Customized' field is increased after opening/closing drop down.

Reported by db...@etouch.net, Sep 26 
Chrome Version:71.0.3562.0 (Official Build)  546b39eb7822fcd38f6c8093cb3ac1a70f8f2dcf-refs/branch-heads/3562@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14). 

What steps will reproduce the problem?
(1) Launch chrome, open NTP and give print command using Ctrl+P
(2) Click on Pages drop down and select 'Customized' option then type text into it.
(3) Close drop down and open it, observe spacing between text field.

Actual: Spacing between 'Pages' drop down and 'Customized' field is increased.

Expected: Spacing between Pages drop down and 'Customized' field should be proper.

This is regression issue broken in ‘M-71’ and will soon update other info:
Good build: 71.0.3561.0 (Revision: 593802)
Bad build : 71.0.3562.0 (Revision: 594163)

Comment 1 by db...@etouch.net, Sep 26

Labels: hasbisect
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 594043 (known good), but no later than 594083 (first known bad).

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/74c88cc194b8059c8bc5a9286eb89ff7646573ab..7490c3bf3f35a226dae207931c10a00fc82ba839?pretty=fuller&n=50

Suspecting: https://chromium.googlesource.com/chromium/src/+/525b54bb14a47817a32b18a1e0d442e5b77ef0c6

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Provided suspect through 'Chromium' bisect as unable to perform bisect using 'per-revision' bisect script 
2. Tried performing 'per revision' bisect on multiple Windows,Linux and Mac machines but unable to perform the same since getting error: "RuntimeError: We don't have enough builds to bisect". 

Thank you.
Actual_Space.mov
4.3 MB View Download
Expected_Space.mov
3.7 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdc9e1dc60479f88b222394b52f5a196873f9a86

commit bdc9e1dc60479f88b222394b52f5a196873f9a86
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 26 20:25:15 2018

Revert "Print Preview Refresh: Make pages a dropdown"

This reverts commit 525b54bb14a47817a32b18a1e0d442e5b77ef0c6.

Reason for revert: Major changes to input behavior required, pushing
to later milestone.

Original change's description:
> Print Preview Refresh: Make pages a dropdown
>
> Make pages a dropdown, and only show the custom input if "Custom"
> page range is selected
>
> Bug: None
> Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c
> Reviewed-on: https://chromium-review.googlesource.com/1237241
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594076}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Id2bbfedbf7ab5406a7a583c9acaf9fd5eeac930b
No-Presubmit: true
No-Tree-Checks: true
No-Try: false
Bug:  889382 ,  889383 ,  889389 
Reviewed-on: https://chromium-review.googlesource.com/1246407
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594457}
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter

Comment 3 by rbpotter@chromium.org, Sep 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment