Regression:[Print preview]Extra Space is observed between 'Fit to page' option and scale drop down.
Reported by
pranjali...@etouch.net,
Sep 26
|
|||
Issue descriptionChrome Version:71.0.3562.0 (Official Build) 546b39eb7822fcd38f6c8093cb3ac1a70f8f2dcf-refs/branch-heads/3562@{#1}(32/64-bit) OS: Windows(7,8,8.1,10) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14). Test URL: http://unec.edu.az/application/uploads/2014/12/pdf-sample.pdf What steps will reproduce the problem? 1. Launch chrome and navigate to above given URL. 2.Now give print command and click on 'More setting' option on print preview. 3.Observe. Actual Result: Extra Space is observed between 'Fit to page' option and scale drop down on print preview. Expected Result: Extra Space is observed between 'Fit to page' option and scale drop down on print preview. This is regression issue broken in ‘M-71’ and below is bisect info, Good build: 71.0.3559.0 Bad build :71.0.3560.0 Chromium bisect URL: https://chromium.googlesource.com/chromium/src/+log/b522cfef32adcfdedf00a6e03362101db42bd80a..d55cd8aa49c4bc476fae109c709a9f3902c55077 Suspecting: https://chromium.googlesource.com/chromium/src/+/5e659696b565b65c4b89a2d117c8b4dba5cf30f9 @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Tried to perform 'per-revision' bisect but it shows "We don't have enough builds to bisect" error message. 2. Hence providing suspect through 'Chromium bisect'. Kindly review the attached screen-cast for reference. Thank you.
,
Sep 28
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358 commit b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358 Author: rbpotter <rbpotter@chromium.org> Date: Mon Oct 01 22:05:58 2018 Print Preview: Fix scaling and system dialog link issues (1) Fixing attached bug (2) Fixing issue reported by namratakannan@ that system dialog link should be enabled in an error state on non-Windows platforms (3) Fixing issue discovered while testing, that setting an invalid value while fit to page is checked should un-check fit to page, but not result in the preview regenerating with the last valid value. Similarly clearing this invalid value should also not result in a preview regeneration (unless the user blurs the input). Bug: 889386 Change-Id: I1afaafe1f9a13b6ed00be712ae7966ce37d62222 Reviewed-on: https://chromium-review.googlesource.com/1250161 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595559} [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/app.html [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/link_container.html [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/link_container.js [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/other_options_settings.html [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/other_options_settings.js [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/pages_settings.html [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/scaling_settings.html [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/scaling_settings.js [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/browser/resources/print_preview/new/settings_section.html [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/test/data/webui/print_preview/link_container_test.js [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [modify] https://crrev.com/b6f6d9dda4de7e0a0074d80d50a2fac1ea6d9358/chrome/test/data/webui/print_preview/settings_section_test.js
,
Oct 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, Sep 26