New issue
Advanced search Search tips

Issue 889383 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Sep 27
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : [Print Preview]Unable to inspect custom text field under "pages" section.

Reported by rp...@etouch.net, Sep 26 
Chrome version: 71.0.3562.0 (Official Build)  Revision	546b39eb7822fcd38f6c8093cb3ac1a70f8f2dcf-refs/branch-heads/3562@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview
2. Now click on Pages drop down list and select 'Custom'
3. Now right click on 'Custom' text field and select 'Inspect' from contxet menu, observe

Actual Result: Unable to inspect custom text field under "pages" section
Expected Result: Should be able to inspect custom text field under "pages" section

This is regression issue broken in ‘M-71’ and will soon update other info:
Good build: 71.0.3561.0 (Revision: 593802)
Bad build : 71.0.3562.0 (Revision: 594163)
Actual_video.mp4
1.0 MB View Download
Expected_video.mp4
832 KB View Download

Comment 1 by rp...@etouch.net, Sep 26

Labels: hasbisect OS-Linux OS-Mac
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 594043 (known good), but no later than 594083 (first known bad).

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/74c88cc194b8059c8bc5a9286eb89ff7646573ab..7490c3bf3f35a226dae207931c10a00fc82ba839?pretty=fuller&n=50

Suspecting: https://chromium.googlesource.com/chromium/src/+/525b54bb14a47817a32b18a1e0d442e5b77ef0c6

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Provided suspect through 'Chromium' bisect as unable to perform bisect using 'per-revision' bisect script 
2. Tried performing 'per revision' bisect on multiple Windows,Linux and Mac machines but unable to perform the same since getting error: "RuntimeError: We don't have enough builds to bisect". 

Thank you.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdc9e1dc60479f88b222394b52f5a196873f9a86

commit bdc9e1dc60479f88b222394b52f5a196873f9a86
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 26 20:25:15 2018

Revert "Print Preview Refresh: Make pages a dropdown"

This reverts commit 525b54bb14a47817a32b18a1e0d442e5b77ef0c6.

Reason for revert: Major changes to input behavior required, pushing
to later milestone.

Original change's description:
> Print Preview Refresh: Make pages a dropdown
>
> Make pages a dropdown, and only show the custom input if "Custom"
> page range is selected
>
> Bug: None
> Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c
> Reviewed-on: https://chromium-review.googlesource.com/1237241
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594076}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Id2bbfedbf7ab5406a7a583c9acaf9fd5eeac930b
No-Presubmit: true
No-Tree-Checks: true
No-Try: false
Bug:  889382 ,  889383 ,  889389 
Reviewed-on: https://chromium-review.googlesource.com/1246407
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594457}
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter

Comment 3 by rbpotter@chromium.org, Sep 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment