New issue
Advanced search Search tips

Issue 889382 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Sep 27
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Drop down items gets misplaced after clicking on 'Layout' in print preview.

Reported by avsha...@etouch.net, Sep 26 
Chrome Version : 71.0.3562.0 (Official Build) 546b39eb7822fcd38f6c8093cb3ac1a70f8f2dcf-refs/branch-heads/3562@{#1} 32/64 bit
OS : Windows(7, 8, 8.1 ,10)

What steps will reproduce the problem?
1. Launch chrome, open NTP, press 'Ctrl + P' to open print preview and select any available printer from list.
2. In 'pages' drop down select 'Custom' and without entering any input, click on 'Layout' drop down.
3. Observe the drop down options.

Actual Result : Drop down items gets misplaced after clicking on 'Layout' in print preview.

Expected Result : Drop down items should open in it's original position in print preview window.

This is a regression issue broken in ‘M-71’ and will soon update bisect information.
Good Build : 71.0.3561.0 (Revision : 593802)
Bad Build : 71.0.3562.0 (Revision : 594163)
Actual_Result.mp4
638 KB View Download
Expected_Result.mp4
407 KB View Download

Comment 1 by avsha...@etouch.net, Sep 26

Labels: RegressedIn-71 Target-71 FoundIn-71 hasbisect OS-Linux OS-Mac
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue broken in ‘M-71’ and below is the bisect information.
Good Build : 71.0.3561.0 (Revision : 593802)
Bad Build : 71.0.3562.0 (Revision : 594163)

Chromium bisect URL:
https://chromium.googlesource.com/chromium/src/+log/74c88cc194b8059c8bc5a9286eb89ff7646573ab..7490c3bf3f35a226dae207931c10a00fc82ba839?pretty=fuller&n=50

Suspect: r594076

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect. revlist: []" error message.
2. Tried on other machines but still getting the same error again.
3. Hence provided suspect through 'Chromium bisect'

Thank you..!

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdc9e1dc60479f88b222394b52f5a196873f9a86

commit bdc9e1dc60479f88b222394b52f5a196873f9a86
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 26 20:25:15 2018

Revert "Print Preview Refresh: Make pages a dropdown"

This reverts commit 525b54bb14a47817a32b18a1e0d442e5b77ef0c6.

Reason for revert: Major changes to input behavior required, pushing
to later milestone.

Original change's description:
> Print Preview Refresh: Make pages a dropdown
>
> Make pages a dropdown, and only show the custom input if "Custom"
> page range is selected
>
> Bug: None
> Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c
> Reviewed-on: https://chromium-review.googlesource.com/1237241
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594076}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Id2bbfedbf7ab5406a7a583c9acaf9fd5eeac930b
No-Presubmit: true
No-Tree-Checks: true
No-Try: false
Bug:  889382 ,  889383 ,  889389 
Reviewed-on: https://chromium-review.googlesource.com/1246407
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594457}
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/bdc9e1dc60479f88b222394b52f5a196873f9a86/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter

Comment 4 by rbpotter@chromium.org, Sep 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment