Docked magnifier pushes down launcher, icons are partially offscreen, unable to scroll to see them |
|||||||||
Issue descriptionGoogle Chrome 71.0.3554.0 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Steps to repro: # Set the OS Display Size to any size except the very smallest, to change the Display Size, go to Settings App > Under Device, go to Displays > and make sure it is at 60% or above # Enable docked magnifier with ctrl + search + d. Note that the magnification strength doesn't matter. # Open the launcher Expected: icons line up with where the grid breaks visually, all icons are above or below the break Actual: some icons are in the middle of the break. You can't read what their titles are and when you scroll down, they are off the screen entirely Please see screenshot
,
Sep 26
,
Sep 26
,
Sep 26
Assuming docked magnifier modifies the work area bounds, this might be launcher issue since it uses display bounds instead [1]. [1] https://cs.chromium.org/chromium/src/ash/app_list/views/app_list_view.cc?q=app_list_view.cc&dr&l=658 I will take a look.
,
Sep 26
,
Sep 27
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7758b60f99feeaa843419ae9026a74270f4ec7ed commit 7758b60f99feeaa843419ae9026a74270f4ec7ed Author: Weidong Guo <weidongg@chromium.org> Date: Mon Oct 01 22:22:56 2018 Fix app list bounds issue in docked magnifier Changes: Make app list respect work area instead of display bounds. Bug: 889334 Change-Id: I861b2d652ce432dbccb16f36b90aae6cc90e328b Reviewed-on: https://chromium-review.googlesource.com/1255583 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595588} [modify] https://crrev.com/7758b60f99feeaa843419ae9026a74270f4ec7ed/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/7758b60f99feeaa843419ae9026a74270f4ec7ed/ash/app_list/views/app_list_view.h [modify] https://crrev.com/7758b60f99feeaa843419ae9026a74270f4ec7ed/ash/app_list/views/apps_grid_view.cc [modify] https://crrev.com/7758b60f99feeaa843419ae9026a74270f4ec7ed/ash/app_list/views/contents_view.cc [modify] https://crrev.com/7758b60f99feeaa843419ae9026a74270f4ec7ed/ash/app_list/views/contents_view.h
,
Oct 1
,
Nov 27
,
Nov 27
Google Chrome 72.0.3593.0 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 I confirmed that this is fixed. With docked magnifier on, I opened launcher and none of the icons are under the shelf, even if the Display Size is set to maximum. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by leberly@chromium.org
, Sep 26494 KB
494 KB View Download