Null-dereference READ in blink::ComputedStyleBase::ComputedStyleBase |
||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6566511286943744 Fuzzer: mbarbella_js_mutation_layout Job Type: linux_ubsan_vptr_content_shell_drt Platform Id: linux Crash Type: Null-dereference READ Crash Address: 0x000000000000 Crash State: blink::ComputedStyleBase::ComputedStyleBase blink::ComputedStyle::Clone blink::StyleResolver::CreateAnimatableValueSnapshot Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=593288:593289 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6566511286943744 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Sep 26
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/5e79316b17b74975742522fb3f4357d75fc51a09 ([animation-worklet] Enable tests on main thread). If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
,
Sep 28
This issue is known crash which will be fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1249387 Reducing priority since this is only visible when a feature that is disabled by default is used.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d9156323a9b236846a9bfe45643a4c2d39fc988 commit 1d9156323a9b236846a9bfe45643a4c2d39fc988 Author: Majid Valipour <majidvp@chromium.org> Date: Fri Oct 05 18:13:44 2018 [animation-worklet] Fix crash in tests when running on main thread Worklet animation supports invalidation of its compositing state. This patch makes this invalidation process a no-op for animations that are running on main (i.e., |compositor_animation_| is null). This means we no longer try to read/modify the non-existent |compositor_animation_| which was causing the crash. Note that in some situations, even for currently main thread animaiton, we may actually want to create and start the |compositor_animation_| but this is a separate issue that can be fixed as a follow up. The added DCHECK uncovered a bug where we were attaching the worklet animation to early even if play was failing. This is also fixed. Bug: 887659 , 889330 Change-Id: I4a89de6632e053f68beafb810355c25e4bfba0e3 Reviewed-on: https://chromium-review.googlesource.com/c/1249387 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597199} [modify] https://crrev.com/1d9156323a9b236846a9bfe45643a4c2d39fc988/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/1d9156323a9b236846a9bfe45643a4c2d39fc988/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
,
Oct 6
ClusterFuzz has detected this issue as fixed in range 597198:597199. Detailed report: https://clusterfuzz.com/testcase?key=6566511286943744 Fuzzer: mbarbella_js_mutation_layout Job Type: linux_ubsan_vptr_content_shell_drt Platform Id: linux Crash Type: Null-dereference READ Crash Address: 0x000000000000 Crash State: blink::ComputedStyleBase::ComputedStyleBase blink::ComputedStyle::Clone blink::StyleResolver::CreateAnimatableValueSnapshot Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=593288:593289 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=597198:597199 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6566511286943744 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Oct 6
ClusterFuzz testcase 6566511286943744 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ClusterFuzz
, Sep 26Labels: Test-Predator-Auto-Components