New issue
Advanced search Search tips

Issue 889307 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-redirect.https.html



Sign in to add a comment

virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-redirect.https.html?* is flaky

Project Member Reported by Findit, Sep 26

Issue description


Flaky test: virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-redirect.https.html?client
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=402962ba3bbee410
Test output log: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/71796
Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I08387e96a97df4656d800637862b67b7c8466e14
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVykQILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLaAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcxNzk2L3dlYmtpdF9sYXlvdXRfdGVzdHMgKGV4cGVyaW1lbnRhbCkvZG1seWRIVmhiQzl2ZFhSdlptSnNhVzVyTFdOdmNuTXRibk12WlhoMFpYSnVZV3d2ZDNCMEwzTmxjblpwWTJVdGQyOXlhMlZ5Y3k5elpYSjJhV05sTFhkdmNtdGxjaTl1WVhacFoyRjBhVzl1TFhKbFpHbHlaV04wTG1oMGRIQnpMbWgwYld3X1kyeHBaVzUwDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-redirect.https.html?client&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVykQILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLaAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcxNzk2L3dlYmtpdF9sYXlvdXRfdGVzdHMgKGV4cGVyaW1lbnRhbCkvZG1seWRIVmhiQzl2ZFhSdlptSnNhVzVyTFdOdmNuTXRibk12WlhoMFpYSnVZV3d2ZDNCMEwzTmxjblpwWTJVdGQyOXlhMlZ5Y3k5elpYSjJhV05sTFhkdmNtdGxjaTl1WVhacFoyRjBhVzl1TFhKbFpHbHlaV04wTG1oMGRIQnpMbWgwYld3X1kyeHBaVzUwDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2

commit 0d8287d0d1002fc3cbb9a66d3039eecda6d151e2
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Sep 26 02:38:15 2018

Revert "service worker: Add WPT tests for resultingClientId."

This reverts commit 398ba6bd4e98ca437d05274df6bd6ac5deb87276.

Reason for revert: Flakily times out.

Original change's description:
> service worker: Add WPT tests for resultingClientId.
> 
> This adds a ?client variant to navigation-redirect.https.html, which
> does a lot of redirect tests. This tests the following:
> - resultingClientId is the id of the client, if one was created via
>   that request.
> - get(resultingClientId) for requests that did not create a client
>   resolves with undefined.
> - resultingClientId is reset on cross-origin redirects.
> - Client.url is the creation URL.
> 
> Bug:  778497 
> Change-Id: I08387e96a97df4656d800637862b67b7c8466e14
> Reviewed-on: https://chromium-review.googlesource.com/1206054
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592363}

TBR=falken@chromium.org,shimazu@chromium.org,wanderview@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  778497 ,  889307 
Change-Id: I21b3d7fd684c879f4f8f11d5b8fb9b69d8bba3a6
Reviewed-on: https://chromium-review.googlesource.com/1244178
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594193}
[modify] https://crrev.com/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[modify] https://crrev.com/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[delete] https://crrev.com/50670cfe6b0cb951a65e5dc58daf9c165fcf9911/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https_client-expected.txt
[modify] https://crrev.com/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-other-origin.html
[modify] https://crrev.com/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Labels: -Sheriff-Chromium
Owner: falken@chromium.org
Status: Assigned (was: Untriaged)
Matt, please have a look. If the flake is unrelated to your changes, please add the sheriff-chromium label back.

The flake might be a duplicate of https://crbug.com/844048.
Status: Fixed (was: Assigned)
I reverted the CL so I suspect this is fixed now.

Sign in to add a comment