HasBeforeUnloadHandlerTest.NonEmptyBeforeUnloadDetected flaky on linux_chromium_rel_ng |
||
Issue descriptionThe browser test HasBeforeUnloadHandlerTest.NonEmptyBeforeUnloadDetected is flaky on linux_chromium_rel_ng. This isn't affecting most CLs since the retry without the patch catches and ignores the failure. However, it is blocking CLs that can't retry without the patch, such as those that change build configs. Sample failed build: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/195078
,
Sep 26
Assigning to chrisha@ since they were the last one to touch the test's file. Feel free to reassign to a more suitable owner, just didn't want this to get lost.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fc21e7d83245f7445f09256dd30a2db951ce805 commit 8fc21e7d83245f7445f09256dd30a2db951ce805 Author: bsheedy <bsheedy@chromium.org> Date: Wed Sep 26 01:17:14 2018 Disable two flaky browser tests Disables SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest and HasBeforeUnloadHandlerTest.NonEmptyBeforeUnloadDetected, as they're flaking on the CQ and preventing some CLs from landing. TBR=oysteine@chromium.org Bug: 889301 , 889304 Change-Id: I7b0c64135eede3a85877d718268e6b047ef57340 Reviewed-on: https://chromium-review.googlesource.com/1244887 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594173} [modify] https://crrev.com/8fc21e7d83245f7445f09256dd30a2db951ce805/chrome/browser/resource_coordinator/discard_before_unload_helper_browsertest.cc [modify] https://crrev.com/8fc21e7d83245f7445f09256dd30a2db951ce805/content/browser/site_per_process_browsertest.cc
,
Sep 26
Note that failures in SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest are being taken care of in issue 889301 . |
||
►
Sign in to add a comment |
||
Comment 1 by bsheedy@chromium.org
, Sep 26