NetworkFileShares UI: Switch drop-down to using windows format |
|||||||
Issue descriptionSince most users are more familiar with the windows URL format, \\server\share, we should use that instead of the smb://server/share format in the discovery dropdown
,
Sep 28
,
Sep 28
,
Sep 28
,
Oct 2
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e756eda1d880f2481c88b1e599963e8f46b8b485 commit e756eda1d880f2481c88b1e599963e8f46b8b485 Author: Bailey Berro <baileyberro@chromium.org> Date: Wed Oct 03 19:46:30 2018 Add SmbUrl::GetWindowsUNCString method This change adds a GetWindowsUNCString method to the SmbUrl class so that Windows style UNC can be displayed rather than the smb:// style URL. Bug: chromium:889289 Change-Id: If7f9d3235a7cd38ac854d6bd186ea4af257de6be Reviewed-on: https://chromium-review.googlesource.com/c/1256107 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#596330} [modify] https://crrev.com/e756eda1d880f2481c88b1e599963e8f46b8b485/chrome/browser/chromeos/smb_client/smb_url.cc [modify] https://crrev.com/e756eda1d880f2481c88b1e599963e8f46b8b485/chrome/browser/chromeos/smb_client/smb_url.h [modify] https://crrev.com/e756eda1d880f2481c88b1e599963e8f46b8b485/chrome/browser/chromeos/smb_client/smb_url_unittest.cc
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bac34eaeae32219a32c64c8c10767456f5bd6934 commit bac34eaeae32219a32c64c8c10767456f5bd6934 Author: Bailey Berro <baileyberro@chromium.org> Date: Wed Oct 03 21:53:31 2018 Use windows format in discovery results Switches to using the windows format of the smb url (\\server\share) rather than the smb://server/share format since it's more familiar to users. Bug: chromium:889289 Change-Id: Ic9118980e05cf367b4049b426313408316472006 Reviewed-on: https://chromium-review.googlesource.com/c/1256112 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596385} [modify] https://crrev.com/bac34eaeae32219a32c64c8c10767456f5bd6934/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
,
Oct 5
,
Oct 5
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by baileyberro@chromium.org
, Sep 25