New issue
Advanced search Search tips

Issue 889287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 889289



Sign in to add a comment

NetworkFileShares UI: add hint text to dropdown

Project Member Reported by baileyberro@chromium.org, Sep 25

Issue description

Add hint text to the add share dialog drop-down to demonstrate the valid formats 
 
sharon
Blockedon: 889289
Labels: M-70
Components: Platform>Apps>FileManager
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0352334e82148d070aeac9726157ae4b0b8eab

commit fa0352334e82148d070aeac9726157ae4b0b8eab
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Oct 04 22:00:08 2018

Add placeholder text to File share URL field

- Adds support for placeholder text to cr-searchable-drop-down
- Adds example share path \\server\share to File share URL field in the
add share dialog.

Bug:  chromium:889287 
Change-Id: I0ee1bc39e10acec419e4ec8935e6a45caa790a18
Reviewed-on: https://chromium-review.googlesource.com/c/1258309
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596874}
[modify] https://crrev.com/fa0352334e82148d070aeac9726157ae4b0b8eab/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/fa0352334e82148d070aeac9726157ae4b0b8eab/ui/webui/resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.html
[modify] https://crrev.com/fa0352334e82148d070aeac9726157ae4b0b8eab/ui/webui/resources/cr_elements/cr_searchable_drop_down/cr_searchable_drop_down.js

Labels: -M-70 M-71
Status: Fixed (was: Started)

Sign in to add a comment