The initial plan is to move these representative branches.

  firmware-nami-10775.B:     A current, but non-critical branch.
  firmware-skate-3824.129.B: An older branch.
  firmware-veyron-6588.B:    A non-critical branch with many boards.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/04aed4393680999e8c738cced434ab16736689da

commit 04aed4393680999e8c738cced434ab16736689da
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 26 17:54:50 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e9033939bd493f151a303f89dccc0ff109eee802

commit e9033939bd493f151a303f89dccc0ff109eee802
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 26 18:04:51 2018

chromeos_config: Create firmwarebranch builders.

This CL defines build configs for firmware branch builders for all
existing firmware branches/boards. The list of branches and boards is
taken directly from the chromeos.branch waterfall configuration.

BUG= chromium:889286 
TEST=run_tests

Change-Id: Iac02b8f3dc800e683e2791d1b548a19b02a5ab86
Reviewed-on: https://chromium-review.googlesource.com/1244405
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-by: YH Lin <yueherngl@chromium.org>

[modify] https://crrev.com/e9033939bd493f151a303f89dccc0ff109eee802/config/chromeos_config.py
[modify] https://crrev.com/e9033939bd493f151a303f89dccc0ff109eee802/config/waterfall_layout_dump.txt
[modify] https://crrev.com/e9033939bd493f151a303f89dccc0ff109eee802/config/config_dump.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/baa481d6a093834df32f7db2874b0d549d49fdf6

commit baa481d6a093834df32f7db2874b0d549d49fdf6
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 26 18:04:52 2018

chromeos_config: Mark initial firmwarebranch builds active.

These marks these builds active firmware branch builders with
infrequent build schedules.

  firmware-nami-10775.B
  firmware-skate-3824.129.B
  firmware-veyron-6588.B

BUG= chromium:889286 
TEST=run_tests

Change-Id: Ie80e93e8a4f25e9eb9625f73e66dfbfe4e0704fe
Reviewed-on: https://chromium-review.googlesource.com/1244757
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: YH Lin <yueherngl@chromium.org>

[modify] https://crrev.com/baa481d6a093834df32f7db2874b0d549d49fdf6/config/chromeos_config.py
[modify] https://crrev.com/baa481d6a093834df32f7db2874b0d549d49fdf6/config/waterfall_layout_dump.txt
[modify] https://crrev.com/baa481d6a093834df32f7db2874b0d549d49fdf6/config/config_dump.json
[modify] https://crrev.com/baa481d6a093834df32f7db2874b0d549d49fdf6/config/luci-scheduler.cfg

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/0159852b19390ae4db3c6d815a0c1c3026902905

commit 0159852b19390ae4db3c6d815a0c1c3026902905
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 26 21:07:25 2018

The initial builds are running, and can be seen here:

https://cros-goldeneye.corp.google.com/chromeos/legoland/builderSummary?builderGroups=firmware&limit=3&buildBranch=master

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a42c3f899d049ef91d1dde251dbe1ea3056c49d8

commit a42c3f899d049ef91d1dde251dbe1ea3056c49d8
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 26 21:35:57 2018

chromeos_config: Schedule with hours not days.

LUCI Scheduler doesn't support scheculing with day long intervals, so
use hours.

Also, switch the 'nami' branch to ACTIVE from INACTIVE, just because
it's a current branch.

BUG= chromium:889286 
TEST=chromeos_config_unittest

Change-Id: I89196bc98d9fb4e40d96d24ac62c23f6ffe9500e
Reviewed-on: https://chromium-review.googlesource.com/1246963
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/a42c3f899d049ef91d1dde251dbe1ea3056c49d8/config/chromeos_config.py
[modify] https://crrev.com/a42c3f899d049ef91d1dde251dbe1ea3056c49d8/config/config_dump.json
[modify] https://crrev.com/a42c3f899d049ef91d1dde251dbe1ea3056c49d8/config/luci-scheduler.cfg

All three firmware branch builds failed.

1 for a flake reason.
2 because of issues related to the TOT ebuild uprev script running against an older branch.

Seems this is not yet prime time.

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934283928951480160

nami got past the flake ( https://crbug.com/889622 ) on the second run, but failed to compile with:

coreboot-0.0.1-r2618: cc1: error: unrecognized command line option '-Wno-packed-not-aligned' [-Werror]


Is this a real branch issue, or a problem with the workspace builder?

> unrecognized command line option '-Wno-packed-not-aligned'

Looks like a likely coreboot toolchain issue.

A tryjob with an old style build confirms. This is a legit problem on the branch, not a failure of the firmwarebranch builder.

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934277185118688192

Using this spreadsheet to track the ability to build each branch.

go/firmwarebranch-build-status

Nami was fixed by the firmware team, thanks!

Tryjobs show that all firmwarebranch builders appear to be working, other then the 7 oldest branches (https://crbug.com/893285)

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/20cd744c0d3381e1b094a097da136ac7455e8682

commit 20cd744c0d3381e1b094a097da136ac7455e8682
Author: Don Garrett <dgarrett@google.com>
Date: Mon Oct 15 22:50:40 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/079a94f7aec00248c614806ba2dd99ab1073bd41

commit 079a94f7aec00248c614806ba2dd99ab1073bd41
Author: Don Garrett <dgarrett@google.com>
Date: Tue Oct 16 00:18:20 2018

chromeos_config: Enable all firmwarebranch builders.

Enable all firmwarebranch builders. All of them are INACTIVE (build
once every 30 days, except for 'name', 'nocturne', and 'grunt', which
are ACTIVE (build once a day).

BUG= chromium:889286 
TEST=chromeos_config_unittest

Change-Id: I92dc2a36f13116915356e1c556f1f5d1e5387661
Reviewed-on: https://chromium-review.googlesource.com/1281828
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/079a94f7aec00248c614806ba2dd99ab1073bd41/config/chromeos_config.py
[modify] https://crrev.com/079a94f7aec00248c614806ba2dd99ab1073bd41/config/waterfall_layout_dump.txt
[modify] https://crrev.com/079a94f7aec00248c614806ba2dd99ab1073bd41/config/config_dump.json
[modify] https://crrev.com/079a94f7aec00248c614806ba2dd99ab1073bd41/config/luci-scheduler.cfg

Rolling nocturne and grunt back to the waterfall until http://b/117812180 is resolved.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/26892dab85a8f0ab6a72f08938668945c8ecc07f

commit 26892dab85a8f0ab6a72f08938668945c8ecc07f
Author: Don Garrett <dgarrett@google.com>
Date: Tue Oct 16 15:51:52 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f903d5c90da10b36d3f09a77b201066f239f9269

commit f903d5c90da10b36d3f09a77b201066f239f9269
Author: Don Garrett <dgarrett@google.com>
Date: Tue Oct 16 16:32:01 2018

chromeos_config: Remove nocturne / grunt firmwarebranch.

This CL removes (for temp return to waterfall) the two most recent
firmware branches because of signing problems.

BUG= chromium:889286  b:117812180
TEST=chromeos_config_unittest

Change-Id: I0347f6ae9f7791c578f3504ecbd3371673830960
Reviewed-on: https://chromium-review.googlesource.com/1283590
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Alec Thilenius <athilenius@google.com>

[modify] https://crrev.com/f903d5c90da10b36d3f09a77b201066f239f9269/config/chromeos_config.py
[modify] https://crrev.com/f903d5c90da10b36d3f09a77b201066f239f9269/config/waterfall_layout_dump.txt
[modify] https://crrev.com/f903d5c90da10b36d3f09a77b201066f239f9269/config/config_dump.json
[modify] https://crrev.com/f903d5c90da10b36d3f09a77b201066f239f9269/config/luci-scheduler.cfg