New issue
Advanced search Search tips

Issue 889239 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec-devutils: files shouldn't be installed into /usr/bin/lib/

Project Member Reported by vapier@chromium.org, Sep 25

Issue description

ec-devutils is installing random files into /usr/bin/lib/:
lm4_chip.cfg  lm4x_cmds.tcl  npcx.cfg  npcx_chip.cfg  npcx_cmds.tcl  nrf51_chip.cfg  nrf51_cmds.tcl  servo.cfg

it looks like these should be in /usr/share/ec-devutils/ or something instead.

over to Stefan to find an owner as i have no idea who would be best to manage/decide this.
 
Owner: gkihumba@chromium.org
Status: Assigned (was: Unconfirmed)
Grace, can you look into this?
Owner: campello@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/368d1eb5564a891c0f4cc3ae0983a3430075369a

commit 368d1eb5564a891c0f4cc3ae0983a3430075369a
Author: Daniel Campello <campello@chromium.org>
Date: Fri Dec 07 06:06:27 2018

ec-devutils: install config files in a better place

Move config files from /usr/bin/lib to /usr/share/ec-devutils

BRANCH=None
BUG= chromium:889239 
TEST=Run flash_ec with the files moved and confirmed it did not die
CQ-DEPEND=CL:1361575

Change-Id: Ifaf3bb31e6096d038f6a9ae9a62c71fe064eedb7
Signed-off-by: Daniel Campello <campello@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1362204
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>

[modify] https://crrev.com/368d1eb5564a891c0f4cc3ae0983a3430075369a/util/flash_ec

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/002aca16e38bda64a542fa7ab17b919cb0de8ebb

commit 002aca16e38bda64a542fa7ab17b919cb0de8ebb
Author: Daniel Campello <campello@chromium.org>
Date: Fri Dec 07 06:06:27 2018

ec-devutils: install config files in a better place

Move config files from /usr/bin/lib to /usr/share/ec-devutils

BUG= chromium:889239 
TEST=Run flash-ec with the files moved and confirmed it did not die
CQ-DEPEND=CL:1362204

Change-Id: Ie7c284d95691a6a78e2be7ba4be1f99d87f91661
Reviewed-on: https://chromium-review.googlesource.com/1361575
Commit-Ready: Daniel Campello <campello@chromium.org>
Tested-by: Daniel Campello <campello@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>

[modify] https://crrev.com/002aca16e38bda64a542fa7ab17b919cb0de8ebb/chromeos-base/ec-devutils/ec-devutils-9999.ebuild

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 18

Labels: merge-merged-firmware-octopus-11297.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/4b8d440d9c74401ed65224004f8cad4df2ce3b06

commit 4b8d440d9c74401ed65224004f8cad4df2ce3b06
Author: Daniel Campello <campello@chromium.org>
Date: Tue Dec 18 21:09:07 2018

ec-devutils: install config files in a better place

Move config files from /usr/bin/lib to /usr/share/ec-devutils

BRANCH=None
BUG= chromium:889239 
TEST=Run flash_ec with the files moved and confirmed it did not die
CQ-DEPEND=CL:1361575

Change-Id: Ifaf3bb31e6096d038f6a9ae9a62c71fe064eedb7
Signed-off-by: Daniel Campello <campello@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1362204
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1383205
Commit-Queue: Jett Rink <jettrink@chromium.org>
Tested-by: Jett Rink <jettrink@chromium.org>
Trybot-Ready: Jett Rink <jettrink@chromium.org>

[modify] https://crrev.com/4b8d440d9c74401ed65224004f8cad4df2ce3b06/util/flash_ec

Sign in to add a comment