New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889223 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 889220



Sign in to add a comment

Track user input to first contentful paint for back/forward navigations

Project Member Reported by sullivan@chromium.org, Sep 25

Issue description

Digging into bug 889220, somewhere between 15 and 35% of our untracked user-initiated input to FCP come from back/forward navigations. We should plumb the timings from input events leading to back/forward navigations through to CommonNavigationParams so that we get data. There may be different implementations needed on Android vs Desktop.

Several examples of doing this are on    bug 750639   .
 
Description: Show this description
Description: Show this description
Owner: tommckee@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by sullivan@chromium.org, Jan 19 (4 days ago)

Owner: sullivan@chromium.org
Reassigning to myself since this also blocks getting good stats on whether navigations come from user input.

The callstack to do a back navigation from the browser back button looks like this (similar stack for keypress):

content::NavigationControllerImpl::NavigateToExistingPendingEntry()
content::NavigationControllerImpl::GotToIndex()
content::NavigationControllerImpl::GoBack()
chrome::GoBack()
chrome::BrowserCommandController::ExecuteCommandWithDisposition()
views::Button::OnMouseReleased()

The input timestamp is known in OnMouseReleased(). But ExecuteCommandWithDisposition, GoBack, and NavigationController::GoBack() are all public methods with no arguments to pass an input timestamp through.

This is different from the omnibox in  bug 750639 , where I was able to cache the timestamp of the input and pass it in as an argument in NavigationControllerImpl::LoadURLWithParams().

Anyone have good ideas on how to plumb a timestamp through?

Comment 5 by sullivan@chromium.org, Today (17 hours ago)

Cc: bmcquade@chromium.org dgozman@chromium.org tdres...@chromium.org
+dgozman, you've helped me with plumbing data through navigation before, do you have ideas here, or thoughts on who would be good to ask? I'd want to be able to do something really similar on toolbar button click, keypress, and context menu for back, forward, reload, and home.

Comment 6 by dgozman@chromium.org, Today (15 hours ago)

Cc: nasko@chromium.org
+nasko, who is more familiar with NavigationController.

Sign in to add a comment