- remove IPH bubble - get app list from C++ via loadTimeData - make bookmarks update live.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bde83f9e9897d442894d32f4695aa994672cb80 commit 3bde83f9e9897d442894d32f4695aa994672cb80 Author: Hector Carmona <hcarmona@chromium.org> Date: Sat Oct 13 01:03:07 2018 Navi: Cleanup Google Apps NUX by removing IPH Bug: 889222 Change-Id: I12ee30ac415e9f4501af53ef420d86d535012bfc Reviewed-on: https://chromium-review.googlesource.com/c/1272126 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#599456} [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/views/bookmarks/bookmark_bar_view_observer.h [delete] https://crrev.com/528c9645a940b33b2e6a9912fd99214b5173699c/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_bubble_view.cc [delete] https://crrev.com/528c9645a940b33b2e6a9912fd99214b5173699c/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_bubble_view.h [delete] https://crrev.com/528c9645a940b33b2e6a9912fd99214b5173699c/chrome/browser/ui/views/feature_promos/bookmark_bar_promo_dialog_browsertest.cc [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/views/frame/browser_view_browsertest.cc [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/webui/welcome/nux/email_handler.cc [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h [delete] https://crrev.com/528c9645a940b33b2e6a9912fd99214b5173699c/chrome/browser/ui/webui/welcome/nux/show_promo_delegate.h [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/browser/ui/webui/welcome/welcome_ui.cc [modify] https://crrev.com/3bde83f9e9897d442894d32f4695aa994672cb80/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/104147fd418f98a13abdb7588c32cc2dbba78012 commit 104147fd418f98a13abdb7588c32cc2dbba78012 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Oct 16 03:32:05 2018 Navi: Get list of Google apps from browser. Bug: 889222 Change-Id: I666bb92178d2e5236143656f9b96180df8fd133c Reviewed-on: https://chromium-review.googlesource.com/c/1266202 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#599834} [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.html [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps_proxy.html [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps_proxy.js [add] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/shared/BUILD.gn [add] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/resources/welcome/onboarding_welcome/shared/nux_types.js [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/ui/webui/welcome/nux/BUILD.gn [add] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/ui/webui/welcome/nux/bookmark_item.cc [add] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/ui/webui/welcome/nux/bookmark_item.h [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/ui/webui/welcome/nux/email_handler.cc [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/ui/webui/welcome/nux/email_handler.h [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h [modify] https://crrev.com/104147fd418f98a13abdb7588c32cc2dbba78012/chrome/browser/ui/webui/welcome/welcome_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/207744f40b63d3ff758d8bfa8f319419e5f4d1c0 commit 207744f40b63d3ff758d8bfa8f319419e5f4d1c0 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Oct 25 23:49:54 2018 Navi: Refactor bookmarking code so Google Apps can add dynamically. Bug: 889222 Change-Id: I3d6fbbef53796aac52dde832ed47a0ead12787ca Reviewed-on: https://chromium-review.googlesource.com/c/1285691 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602930} [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/shared/BUILD.gn [add] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/shared/bookmark_proxy.html [add] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/resources/welcome/onboarding_welcome/shared/bookmark_proxy.js [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/webui/welcome/nux/BUILD.gn [add] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/webui/welcome/nux/bookmark_handler.cc [add] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/webui/welcome/nux/bookmark_handler.h [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/webui/welcome/nux/email_handler.cc [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/webui/welcome/nux/email_handler.h [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h [modify] https://crrev.com/207744f40b63d3ff758d8bfa8f319419e5f4d1c0/chrome/browser/ui/webui/welcome/welcome_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf48cde887e7610b35b09dc38a9594dba992287c commit bf48cde887e7610b35b09dc38a9594dba992287c Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Oct 26 01:42:10 2018 Navi: Cache Google Apps bookmark icons from web ui. Bug: 889222 Change-Id: I5af4c643bd14e3e52b37a931eb04b7d3c533c6f1 Reviewed-on: https://chromium-review.googlesource.com/c/1287437 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602971} [modify] https://crrev.com/bf48cde887e7610b35b09dc38a9594dba992287c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js [modify] https://crrev.com/bf48cde887e7610b35b09dc38a9594dba992287c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js [modify] https://crrev.com/bf48cde887e7610b35b09dc38a9594dba992287c/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps_proxy.js [modify] https://crrev.com/bf48cde887e7610b35b09dc38a9594dba992287c/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [modify] https://crrev.com/bf48cde887e7610b35b09dc38a9594dba992287c/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a3f86677e6654ca22c3a827868abab7b7c679df commit 8a3f86677e6654ca22c3a827868abab7b7c679df Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Nov 02 01:10:32 2018 Navi: Remove bookmarks when moving back/forward through history. Bug: 889222 Change-Id: I718533eef1b76bdee504b678038e598f79146e5f Reviewed-on: https://chromium-review.googlesource.com/c/1311806 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604793} [modify] https://crrev.com/8a3f86677e6654ca22c3a827868abab7b7c679df/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [modify] https://crrev.com/8a3f86677e6654ca22c3a827868abab7b7c679df/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.js [modify] https://crrev.com/8a3f86677e6654ca22c3a827868abab7b7c679df/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js [modify] https://crrev.com/8a3f86677e6654ca22c3a827868abab7b7c679df/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js
Comment 1 by hcarmona@chromium.org
, Oct 5