New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889221 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Task



Sign in to add a comment

Decouple the sheriff rotation from master1 - master.chromium

Project Member Reported by hinoka@chromium.org, Sep 25

Issue description

Context:  crbug.com/855093 

Currently master.chromium needs to be running in order for the sheirffing rotation endpoints to work.  Explanation:

"apache2 does serve this static file, but it was "bundled" with master.chromium in some kind of parasitic way.  Now that the host has finally died, the parasite is no longer with us, only if we put the host on some kind of life support will it work."

Thus, we can't turn down master.chromium until the rotation files are decoupled.  A quick fix would be to dump the files onto some google storage bucket.
 
Cc: amcrae@chromium.org
Labels: -Type-Bug -Pri-3 LUCI-ChromeInternal Pri-1 Type-Task
Owner: seanmccullough@chromium.org
Status: Assigned (was: Unconfirmed)
Assigned to Sean to prioritize and triage further within SoM team. 

This needs to be completed before end of Q4

master.chromium builder is currently running without any builders specified and needs to be turned down ASAP. 

CCing amcrae. 
Labels: LUCI-Blocker-ChromeInternal
Cc: zhangtiff@chromium.org olakar@chromium.org
+zhangtiff, olakar who can update with info about remaining work on the new rotation tool, which IIUC obviates this static json file.

Will be sure to bring this up when we meet to discuss OKRs for Q4.
Hi Sean. 

Feel free to assign this bug to me, I'll work on moving this over next week.
Cc: -olakar@chromium.org seanmccullough@chromium.org
Owner: olakar@chromium.org
A status update and a question. 

=== Status 
- CLs are out for review to move this over to the new service.
https://chromium-review.googlesource.com/c/infra/infra/+/1270318 - Trooper.
https://chromium-review.googlesource.com/c/infra/infra/+/1272740 - Sheriff files.
https://chromium-review.googlesource.com/c/infra/infra/+/1275245 - All rotations.

https://rota-ng.appspot.com/ is serving the files under the `/legacy` 

Eg. https://rota-ng.appspot.com/legacy/sheriff.js

With go/chromecals being just static page i moved that one over too. 

https://rota-ng.appspot.com/static/cc/rotations.html


== Question

The question I've got here is for the current `master.chromium` files , who can access that page?
Presuming this is not the Public Internet I'd set something similar for the new location.

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1

commit d8c81605ee1cb8b3bb6915f7e480560363d5b4c1
Author: Ola Karlsson <olakar@chromium.org>
Date: Fri Oct 12 00:31:27 2018

[rotang] This CL adds in serving the trooper files from the RotaNG service.

Remaining cron created files coming in following changes.

Can be tried out on:

https://rota-ng.appspot.com/legacy/trooper.js , current_trooper.json, current_trooper.txt

Bug: 889221
Change-Id: Ieaa99bb9900feb14bb0e04e58b337dc51986c8c4
Reviewed-on: https://chromium-review.googlesource.com/c/1270318
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18268}
[add] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/handlers/job_legacy_test.go
[add] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/handlers/job_legacy.go
[modify] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go
[modify] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/rotang.go
[add] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/app/cron.yaml
[add] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy.go
[add] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy_test.go
[modify] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport.go
[modify] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/app/app_local.yaml
[modify] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/pkg/calendar/calendar_test.go
[modify] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/pkg/calendar/calendar.go
[modify] https://crrev.com/d8c81605ee1cb8b3bb6915f7e480560363d5b4c1/go/src/infra/appengine/rotang/cmd/app/app.go

re #6: it's the public internet.

Eg. https://build.chromium.org/p/chromium/sheriff.json
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 15

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b

commit c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b
Author: Ola Karlsson <olakar@chromium.org>
Date: Mon Oct 15 01:42:03 2018

[rotang] Add in a handler for the `all_rotations.js` file.

Also copied the go/chromcals webpage in here too..

Check out: https://rota-ng.appspot.com/static/cc/rotations.html

Bug: 889221
Change-Id: I6691ab34caae96f1b778f5351b1805f6e55bd2d5
Reviewed-on: https://chromium-review.googlesource.com/c/1275245
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18306}
[add] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/app/static/cc/rotations.js
[modify] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy.go
[add] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/app/static/cc/jquery.cookie.js
[modify] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/rotang.go
[add] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/app/static/cc/rotations.css
[modify] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy_test.go
[modify] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[add] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/app/static/cc/rotations.html
[modify] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/pkg/calendar/calendar_test.go
[modify] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/pkg/calendar/calendar.go
[modify] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/handlers/job_schedule_test.go
[modify] https://crrev.com/c8c52f1bc405f71d219bbd4e526a96d4aa1acc5b/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9

commit e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Nov 13 06:22:14 2018

[rotang] Link changes to the chromium_infra repository.

This CL changes the links from the deprecated https://build.chromium.org/deprecated/chromium/ to the new appengine service at rota-ng.appspot.com.


Bug: 889221
Change-Id: Ie91d031b5c5e5b929e858bff034bfa9c9cabcb4f
Reviewed-on: https://chromium-review.googlesource.com/c/1279984
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18950}
[modify] https://crrev.com/e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-drawer-test.html
[modify] https://crrev.com/e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
[modify] https://crrev.com/e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9/appengine/chromium_build/static/rotations.js
[modify] https://crrev.com/e84fe7ba34a6c10bcede04a2e1b5f73a4124bfc9/appengine/findit/common/rotations.py

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18cdf7a7ef75e2e9283c04bc2282d34ff97c5b71

commit 18cdf7a7ef75e2e9283c04bc2282d34ff97c5b71
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Nov 21 19:13:13 2018

Update sheriff rotation URLs to rota-ng

Bug: 889221
Change-Id: Ie26aca388f600ee6a0983ee378c9b5b70e5efba6
Reviewed-on: https://chromium-review.googlesource.com/c/1342400
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610125}
[modify] https://crrev.com/18cdf7a7ef75e2e9283c04bc2282d34ff97c5b71/infra/config/global/luci-milo.cfg

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/697be8891fbe2114bec785318664e1e7c248b700

commit 697be8891fbe2114bec785318664e1e7c248b700
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Dec 04 22:17:32 2018

[rotang] Changing the all_rotations.js from the deprecated link to the new rota-ng service.

Bug: 889221
Change-Id: I5fc264fa1f884e312f49fd456797389932b75837
Reviewed-on: https://chromium-review.googlesource.com/c/1280084
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613724}
[modify] https://crrev.com/697be8891fbe2114bec785318664e1e7c248b700/third_party/blink/tools/blinkpy/w3c/test_importer.py

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/22b425722e0e0eb64ec928ed4ef81a456f4ccb03

commit 22b425722e0e0eb64ec928ed4ef81a456f4ccb03
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Dec 06 23:09:04 2018

After a long while hunting down the references I think I've gotten them all . 

Is there a way to see how many hits those js/json files get on the master? 

If that looks all right we should be go to kill those cron jobs. 

With those turned down I'll enable emailing from the new service.
You can hop on master1.golo and check out ~/buildbot/build/masters/master.chromium/http.log

It looks like SoM is still hitting it, as well as Milo.

For Milo, just have to make sure the luci-milo.cfg no longer references build.chromium.org.
For SoM, I'm not sure.
Thx. for checking. 

Cl out for the LUCI config.

https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/727454

Prodding the Sheriff-o-matic people to push a new release.


Project Member

Comment 18 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/7f98851124b4cc4764276f55893918adaef51567

commit 7f98851124b4cc4764276f55893918adaef51567
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Dec 11 00:00:42 2018

CL for the Sheriff-o-Matic release.

https://chromium-review.googlesource.com/c/infra/infra/+/1370559
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caaa683015faaf885bee462ad07e43063bb8b421

commit caaa683015faaf885bee462ad07e43063bb8b421
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Tue Dec 11 02:27:22 2018

Roll src-internal ddee6ce9c58a..7f98851124b4 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddee6ce9c58a..7f98851124b4


Created with:
  gclient setdep -r src-internal@7f98851124b4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:889221
TBR=mmoss@chromium.org

Change-Id: Id4d6a4f17c58d47d1568e5a7ebb3f3d4d37cbac0
Reviewed-on: https://chromium-review.googlesource.com/c/1371184
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615390}
[modify] https://crrev.com/caaa683015faaf885bee462ad07e43063bb8b421/DEPS

Been messing around with getting access to the master1.golo machine but so far it just hangs trying to connect. 

Got the group access in but maybe it takes a bit of time before I can use it .. 

Still no luck to get into that master1.golo .. 

Ssh just hangs forever.
Changed the go/chromecals link, the original html was changed quite a while a go but looks like it wasn't pushed. 

Still can't access master1.golo to see if there's any stragglers left.

Comment 24 by olakar@chromium.org, Jan 21 (2 days ago)

Components: Infra>ProdTech>Rotation
ProdTech in Syd is responsible for rotations.

Moving bugs to the new component

Sign in to add a comment