Investigate why InputToFirstContentfulPaint metric has fewer samples than PageLoad.PaintTiming.NavigationToFirstContentfulPaint.UserInitiated |
|||||||||
Issue descriptionWe expect there would be fewer samples for InputToFirstContentfulPaint than for PageLoad.PaintTiming.NavigationToFirstContentfulPaint.UserInitiated because there are a long tail of input types that aren't wired up (like right click to open in a new window). But looking at the first canary data coming in, the data volume is about half. We need to understand the difference, and implement tracking for the input types that account for the largest parts of it. Doc with numbers: https://docs.google.com/document/d/1opfo_0SmrIFcLS5W0Cm3aNgQErytReU648C4N2EJpow/edit# ⛆ |
|
|
,
Sep 25
,
Sep 28
Wrote up a doc on how I might get a breakdown of the different places navigations are initiated from the renderer, feedback welcome: https://docs.google.com/document/d/1x63w2i7isjCu0XuJs7fpS1ob0_sFeViJTSyhmyA8pf8/edit#
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25eea466a443db6890068656cbd9418e21ef9704 commit 25eea466a443db6890068656cbd9418e21ef9704 Author: Annie Sullivan <sullivan@chromium.org> Date: Sat Sep 29 00:26:08 2018 Add an enum which breaks down FCP counts by initiating process. This will be used to guide the investigation into why not all user-initiated navigations are tied to input events (see linked bug). The metric will be re-evaluated at its expiration date at end of year to see if it could be useful for anything else, and removed if not. Bug: 889220 Change-Id: I992e6ada4f892603b672daa812e80b69bc901678 Reviewed-on: https://chromium-review.googlesource.com/1246903 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595268} [modify] https://crrev.com/25eea466a443db6890068656cbd9418e21ef9704/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/25eea466a443db6890068656cbd9418e21ef9704/tools/metrics/histograms/histograms.xml
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e463483d770050298c40f7510899eb847fc9bd05 commit e463483d770050298c40f7510899eb847fc9bd05 Author: Annie Sullivan <sullivan@chromium.org> Date: Thu Oct 04 02:29:31 2018 Add input timestamps to scheduled reload, redirect and form submit. This will ensure that the InputToFirstContentfulPaint metric tracks the full latency when these navigations are initiated via user input. This will also make it easier to debug which types of loads from the renderer are NOT counted as being from user input in a follow up CL. Bug: 889220 Change-Id: I2ae48b5ca9d6230c15a4291d03b64945d312f802 Reviewed-on: https://chromium-review.googlesource.com/c/1258242 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596481} [modify] https://crrev.com/e463483d770050298c40f7510899eb847fc9bd05/third_party/blink/renderer/core/loader/navigation_scheduler.cc [modify] https://crrev.com/e463483d770050298c40f7510899eb847fc9bd05/third_party/blink/renderer/core/loader/navigation_scheduler.h [modify] https://crrev.com/e463483d770050298c40f7510899eb847fc9bd05/third_party/blink/renderer/core/loader/scheduled_navigation.cc [modify] https://crrev.com/e463483d770050298c40f7510899eb847fc9bd05/third_party/blink/renderer/core/loader/scheduled_navigation.h
,
Oct 8
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c98fff0fa13ebe5ddea73888264c772334b8cb88 commit c98fff0fa13ebe5ddea73888264c772334b8cb88 Author: Annie Sullivan <sullivan@chromium.org> Date: Tue Oct 09 21:59:36 2018 Fix typo in InitiatingProcess histogram name Bug: 889220 Change-Id: I30136149cd59ef2e2f7600dae5f445da51578a45 Reviewed-on: https://chromium-review.googlesource.com/c/1268659 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#598097} [modify] https://crrev.com/c98fff0fa13ebe5ddea73888264c772334b8cb88/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0d114d7d793cfc772b32ebf60d501609bc6f689 commit b0d114d7d793cfc772b32ebf60d501609bc6f689 Author: Annie Sullivan <sullivan@chromium.org> Date: Thu Oct 11 17:31:30 2018 Record input start time in LocalFrame::Reload and CreateWindowForRequest I found these additional cases in an audit of the code for bug 889220. Bug: 889220 Change-Id: I649200d91625c2a47848132b79a846174fa4a3e1 Reviewed-on: https://chromium-review.googlesource.com/c/1276551 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#598820} [modify] https://crrev.com/b0d114d7d793cfc772b32ebf60d501609bc6f689/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/b0d114d7d793cfc772b32ebf60d501609bc6f689/third_party/blink/renderer/core/page/create_window.cc
,
Oct 12
,
Oct 22
,
Oct 22
|
||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sullivan@chromium.org
, Sep 25