New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889186 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

vr_pixeltests failing on chromium.memory/Linux MSan Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 25

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of jbroman@chromium.org

vr_pixeltests failing on chromium.memory/Linux MSan Tests

Builders failed on: 
- Linux MSan Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests


 
Components: UI>Browser>VR
Labels: -Sheriff-Chromium
Owner: acondor@chromium.org
Status: Assigned (was: Available)
The following tests have been flakily failing on MSAN for some time, and now fail much more frequently:

UiPixelTest.DrawVrBrowsingMode
GlTestEnvironmentTest.InitializeAndCleanup

acondor, you've touched both of these quite recently; could you triage this?
I'll take a look. Feel free to disable for this bot if it keeps failing.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f0cf176c1afa1eb27314f0b62ad579b0b13f309

commit 1f0cf176c1afa1eb27314f0b62ad579b0b13f309
Author: Jeremy Roman <jbroman@chromium.org>
Date: Tue Sep 25 20:24:30 2018

sheriffing: disable vr_pixeltests:UiPixelTest.DrawVrBrowsingMode,GlTestEnvironmentTest.InitializeAndCleanup in msan builds

Bug:  889186 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I673acc7c696802c8c5b29b9e9f4b279c12e0b858
Tbr: acondor@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1244364
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594080}
[modify] https://crrev.com/1f0cf176c1afa1eb27314f0b62ad579b0b13f309/chrome/browser/vr/test/gl_test_environment_unittest.cc
[modify] https://crrev.com/1f0cf176c1afa1eb27314f0b62ad579b0b13f309/chrome/browser/vr/ui_pixeltest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/859f36dfddbe9ca934d2fe6dbcfe130330e9ebca

commit 859f36dfddbe9ca934d2fe6dbcfe130330e9ebca
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Wed Sep 26 18:46:39 2018

[VR GL tests] Leave GL implementation undefined

The default implementation supports the GL tests to run on MSan successfully.

Bug:  889186 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6d0f7bef6ddba8a2b508d1fd0c732dac1fb31205
Reviewed-on: https://chromium-review.googlesource.com/1246292
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594411}
[modify] https://crrev.com/859f36dfddbe9ca934d2fe6dbcfe130330e9ebca/chrome/browser/vr/test/gl_test_environment_unittest.cc
[modify] https://crrev.com/859f36dfddbe9ca934d2fe6dbcfe130330e9ebca/chrome/browser/vr/test/vr_gl_test_suite.cc
[modify] https://crrev.com/859f36dfddbe9ca934d2fe6dbcfe130330e9ebca/chrome/browser/vr/ui_pixeltest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment