New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 889185 link

Starred by 1 user
Status: Fixed
Owner:
█ loonyb...@chromium.org
Last visit > 30 days ago
Closed: Nov 6
Cc:
iclell...@chromium.org
ojan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Implement violation enforcement for feature policy optimized image policies

Project Member Reported by loonyb...@chromium.org, Sep 25 
The current behaviour is inverting image colors.

However, we'd like to potentially:
a. early abort image loading
b. render with broken image icon or placeholder image
c. load image with user gesture (e.g click)

Currently we still need to do UX research to determine the final behaviour.

Comment 1 by loonyb...@chromium.org, Sep 25 

For now, we'd like to render the image with "placeholder image" and treat policy violation irreversible.

Comment 2 by loonyb...@chromium.org, Sep 25

Components: Internals>FeatureControl Blink>FeaturePolicy
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44b6f14778bac6c27b737e95a710a0919a97ecb9

commit 44b6f14778bac6c27b737e95a710a0919a97ecb9
Author: Luna Lu <loonybear@chromium.org>
Date: Thu Oct 25 02:28:55 2018

Feature Policy Image Policies: replace invert color logic by placeholder

The current violation enforcement is to render images with inverted
colors.

However, we'd like to potentially:
a. early abort image loading
b. render with broken image icon or placeholder image
c. load image with user gesture (e.g click)

This CL make the enforcement to be rendering with irreversible
placeholder image.

Bug:  889185 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1ba6aedb11ebffcde6a983239f666a8abbd1416d
Reviewed-on: https://chromium-review.googlesource.com/c/1244111
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#602585}
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-compression-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-policies-with-border-radius-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-legacy-formats-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-expected.png
[delete] https://crrev.com/96cbc77493177bfad48d6d4281c94d94e4e7bfd1/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-forced-layout-expected.html
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[delete] https://crrev.com/96cbc77493177bfad48d6d4281c94d94e4e7bfd1/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-responsive-image-expected.html
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-styles-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/http/tests/images/feature-policy-image-compression-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/http/tests/images/feature-policy-image-policies-with-border-radius-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/http/tests/images/feature-policy-legacy-formats-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-styles-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-styles-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/http/tests/images/feature-policy-image-compression-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/http/tests/images/feature-policy-image-policies-with-border-radius-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/http/tests/images/feature-policy-legacy-formats-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/images/feature-policy-max-downscaling-image-styles-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-styles-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-edge-cases-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-forced-layout-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-responsive-image-expected.png
[add] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-styles-expected.png
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/blink/renderer/core/layout/layout_image.h
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/blink/renderer/core/paint/image_painter.cc
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/44b6f14778bac6c27b737e95a710a0919a97ecb9/third_party/blink/renderer/core/paint/replaced_painter.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f47ac33d534432c316427bfc3a75fb0ea5a57ebf

commit f47ac33d534432c316427bfc3a75fb0ea5a57ebf
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Oct 25 05:19:05 2018

Mark image downscaling tests on Windows 10 as failing

The following tests started failing after
https://chromium-review.googlesource.com/c/chromium/src/+/1244111.
* http/tests/images/feature-policy-image-compression.html
* http/tests/images/feature-policy-image-policies-with-border-radius.html
* http/tests/images/feature-policy-legacy-formats.html
* images/feature-policy-max-downscaling-image-edge-cases.html
* images/feature-policy-max-downscaling-image-forced-layout.html
* images/feature-policy-max-downscaling-image-responsive-image.html
* images/feature-policy-max-downscaling-image-styles.html
* images/feature-policy-max-downscaling-image.html
* virtual/exotic-color-space/images/feature-policy-max-downscaling-image-edge-cases.html
* virtual/exotic-color-space/images/feature-policy-max-downscaling-image-forced-layout.html
* virtual/exotic-color-space/images/feature-policy-max-downscaling-image-responsive-image.html
* virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles.html
* virtual/exotic-color-space/images/feature-policy-max-downscaling-image.html
* virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-edge-cases.html
* virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-forced-layout.html
* virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-responsive-image.html
* virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-styles.html
* virtual/gpu-rasterization/images/feature-policy-max-downscaling-image.html

This is probably because they weren't rebased for Windows 10.

TBR=loonybear@chromium.org

Bug:  889185 
Change-Id: Iaba87ee5d62eba1c41abf7befabdb09b0069166a
Reviewed-on: https://chromium-review.googlesource.com/c/1298523
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602618}
[modify] https://crrev.com/f47ac33d534432c316427bfc3a75fb0ea5a57ebf/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6

commit f91910eba0d6f1d81dc2ec39255b5ad348b39dc6
Author: Luna Lu <loonybear@chromium.org>
Date: Mon Nov 05 16:57:10 2018

Rename Image Policies

This CL renames the following feature policy features:
image-compression > unoptimized-images
max-downscaling-image > oversized-images

Change-Id: I4a4a8e96e4a422087a4ef51f57ff70bc5c3ac745

BUG:  899761 ,  889185 
Change-Id: I4a4a8e96e4a422087a4ef51f57ff70bc5c3ac745
Reviewed-on: https://chromium-review.googlesource.com/c/1308533
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605360}
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-compression-cached-image-expected.png
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-compression-cached-image.html
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-policies-with-border-radius.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-unoptimized-images-cached-image.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-unoptimized-images.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-edge-cases.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-forced-layout.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-resize.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-responsive-image.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-styles.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-edge-cases.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-forced-layout.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-resize.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-responsive-image.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images-styles.html
[add] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/feature-policy-oversized-images.html
[delete] https://crrev.com/9a9ed89bd6a884157aaa81337a6e62683dce9adf/third_party/WebKit/LayoutTests/images/resources/frame-with-max-downscaling-image-responsive-images-expected.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-edge-cases.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-forced-layout.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-resize.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-responsive-images.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images-styles.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/images/resources/frame-with-oversized-images.html
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/http/tests/images/feature-policy-unoptimized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/http/tests/images/feature-policy-unoptimized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-resize-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-resize-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/http/tests/images/feature-policy-unoptimized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-resize-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-resize-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/feature-policy-oversized-images-styles-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-edge-cases-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-forced-layout-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-responsive-image-expected.png
[rename] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/feature-policy-oversized-images-styles-expected.png
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/public/mojom/feature_policy/feature_policy.mojom
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/renderer/core/feature_policy/feature_policy.cc
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/third_party/blink/renderer/core/layout/layout_image.h
[modify] https://crrev.com/f91910eba0d6f1d81dc2ec39255b5ad348b39dc6/tools/metrics/histograms/enums.xml

Comment 6 by loonyb...@chromium.org, Nov 6

Labels: M-72
Status: Fixed (was: Assigned)
Tests re-enabled in https://chromium-review.googlesource.com/c/chromium/src/+/1318372 and the CL above.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d379ad4ba93ec65932d87238ddc3bb75abf714fa

commit d379ad4ba93ec65932d87238ddc3bb75abf714fa
Author: Luna Lu <loonybear@chromium.org>
Date: Tue Nov 06 18:15:05 2018

re-enabling feature policy layout tests

moved current test expects to platform/linux
added new test expects to platform/win

Bug:  889185 
Change-Id: Ifdd0e9c4f0389967756e5dcc2fe3512da40e8e41
Reviewed-on: https://chromium-review.googlesource.com/c/1318375
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605740}
[modify] https://crrev.com/d379ad4ba93ec65932d87238ddc3bb75abf714fa/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/d379ad4ba93ec65932d87238ddc3bb75abf714fa/third_party/WebKit/LayoutTests/platform/linux/http/tests/images/feature-policy-image-policies-with-border-radius-expected.png
[rename] https://crrev.com/d379ad4ba93ec65932d87238ddc3bb75abf714fa/third_party/WebKit/LayoutTests/platform/linux/http/tests/images/feature-policy-legacy-formats-expected.png
[rename] https://crrev.com/d379ad4ba93ec65932d87238ddc3bb75abf714fa/third_party/WebKit/LayoutTests/platform/win/http/tests/images/feature-policy-image-policies-with-border-radius-expected.png
[rename] https://crrev.com/d379ad4ba93ec65932d87238ddc3bb75abf714fa/third_party/WebKit/LayoutTests/platform/win/http/tests/images/feature-policy-legacy-formats-expected.png
►

Sign in to add a comment