Current SkiaRenderer's overdraw has its own canvas and flush that at the end of frame. This doesn't work with SkDDL because we won't have context the thread that SkiaRenderer is on.
Hi, I am willing to help on this and change this to Started.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b3c5cb709257afacc429ce94bea5cd8a2356493 commit 0b3c5cb709257afacc429ce94bea5cd8a2356493 Author: Xu Xing <xing.xu@intel.com> Date: Fri Oct 19 23:03:13 2018 Change the overdraw color to a GPU friendly color When skia works in CPU mode, color should be 0x00000000, 0x00000000,0x2f0000ff, 0x2f00ff00, 0x3fff0000, 0x7fff0000. When it turns to GPU, the R and B should be swapped. Skia mainly works in GPU mode, so change this color to a GPU friendly color. However, the best solution is to support both CPU mode and GPU mode. Add TODO for this. Bug: 889122 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I71aa1d2ae34ab10a41ba5d58e1e2cbb6867bec6b Reviewed-on: https://chromium-review.googlesource.com/c/1253407 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#601344} [modify] https://crrev.com/0b3c5cb709257afacc429ce94bea5cd8a2356493/components/viz/service/display/skia_renderer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23350d9645003f5c9999b3d8270d2303c8ec239e commit 23350d9645003f5c9999b3d8270d2303c8ec239e Author: Xu Xing <xing.xu@intel.com> Date: Fri Oct 26 00:54:51 2018 CopyDrawnRenderPass should not copy from overdraw surface The only case to use current surface is CopyDrawnRenderPass. No matter overdraw or not, this should copy from the current surface. Bug:889122 Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9ff3cb901a7060a3324659d65b354020a26ba27b Reviewed-on: https://chromium-review.googlesource.com/c/1286195 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#602955} [modify] https://crrev.com/23350d9645003f5c9999b3d8270d2303c8ec239e/components/viz/service/display/renderer_pixeltest.cc [modify] https://crrev.com/23350d9645003f5c9999b3d8270d2303c8ec239e/components/viz/service/display/skia_renderer.cc [add] https://crrev.com/23350d9645003f5c9999b3d8270d2303c8ec239e/components/viz/test/data/skia_translucent_rectangles.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cdc7234bfaf82cb7977c39de5d329589eeee38c commit 4cdc7234bfaf82cb7977c39de5d329589eeee38c Author: Xu Xing <xing.xu@intel.com> Date: Thu Nov 29 03:41:48 2018 Enable overdraw feedback in DDL mode Bug: 889122 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I797dab237ccf1629fe0c7d0e1152ecac1d00c8d4 Reviewed-on: https://chromium-review.googlesource.com/c/1286198 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by: enne <enne@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612018} [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/cc/test/pixel_test.cc [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/cc/test/pixel_test.h [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/common/skia_helper.cc [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/common/skia_helper.h [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/service/display/renderer_pixeltest.cc [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/service/display/skia_renderer.cc [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/service/display_embedder/gpu_display_provider.cc [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/service/display_embedder/skia_output_surface_impl.cc [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/service/display_embedder/skia_output_surface_impl.h [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc [modify] https://crrev.com/4cdc7234bfaf82cb7977c39de5d329589eeee38c/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
Comment 1 by weiliangc@chromium.org
, Sep 25