New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889118 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

USB port stops working after device sleep

Project Member Reported by ihf@chromium.org, Sep 25

Issue description

Lifu reports via email:

I have a Samsung Chromebook model XE303C12 (a.k.a Snow). Since 08/22 when I received a system update with version 70.0.3524.2 (Platform version: 10991.0.0), I noticed that Gnubby stops working if I put the device into hibernation mode then wake it up. I thought it was a problem of Gnubby so filed b/113820740. But Gnubby team said it could be a problem on Chromebook's side.

I've received another 2 updates after that, and none of them had ever solved the problem. And I realized that not only the Gnubby key, but any USB devices, stop working after the device goes into hibernation mode, including my USB mouse, keyboard, and even the Chromebook's built-in Webcam (yes, it's also a USB device, for some reason). Seems something was wrong with the whole USB drive.
 
Cc: alberto@chromium.org
Labels: Hotlist-ConOps-Channel-Beta M-71 Hotlist-ConOps-CrOS Hotlist-ConOps-Source-Feedback
Summary: USB port stops working after device sleep (was: [daisy] USB port stops working after device sleep)
I'm seeing an increase in reports from users that USB devices are not detected or no longer work. Seems like it happens after the device wakes back up from sleep.

M71 Dev reports:
https://listnr.corp.google.com/report/85686353944
https://listnr.corp.google.com/report/85690170149

M70 Reports:
https://listnr.corp.google.com/report/85710742340
https://listnr.corp.google.com/report/85699746057
https://listnr.corp.google.com/report/85695371815
https://listnr.corp.google.com/report/85653503277
No clear pattern seen in which devices are affecting -- seeing reports from Peppy, Eve, Falco, Nautilus, etc.
Cc: gwendal@chromium.org snanda@chromium.org
+gwendal, sameer

Sameer, who should take a look?
Cc: allendam@chromium.org
Allen, could be related to USBGuard.
Cc: -allendam@chromium.org allenwebb@chromium.org
Sorry, wrong Allen.
Labels: CodeComplete-1114119
Labels: -CodeComplete-1114119
Yes I can take a look at it, I applied that label to the wrong bug.
This looks like it might give us the information we need to troubleshoot the issue: https://listnr.corp.google.com/product/208/report/85691825873

Usbguard is supposed to be disabled by Finch in 70, but it looks like it is still running based on the reports we are getting. Additionally it looks like the daemon is being started at a time it shouldn't based on that report.
Here is the CL that disabled usbguard-daemon on Finch:
https://critique.corp.google.com/#review/212637238

Because of the way the finch flag works, usbguard generate-policy is still called by upstart here:
https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/sys-apps/usbguard/files/usbguard-wrapper.conf?rcl=08e9e06ae51c45cdf0bbff82e5cdefb031f1039c&l=41
This is the line that disables the daemon:
https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/sys-apps/usbguard/files/usbguard.conf?rcl=78bedb705b965236528ac1a904a865c58e030818&l=19

I downloaded veyron_minnie/R70-11021.28.0 and was not able to reproduce the problems people were seeing on m70, but Finch successfully disabled usbguard-daemon on my device. I did see the dmesg entries for generate policy.

"dmesg" entries that say "Device is not authorized for usage" are indicative of usbguard-daemon executing and blocking devices.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ef2e17aadaad1ecdf9055f645f885b16fce85d9

commit 6ef2e17aadaad1ecdf9055f645f885b16fce85d9
Author: Allen Webb <allenwebb@google.com>
Date: Thu Oct 18 16:04:19 2018

chrome_features: Set Usbguard feature flag to disabled by default.

This needs to be enabled by Finch instead of disabled by finch.
This in principle reverts but revision exceptions were blocking the merge:
https://chromium-review.googlesource.com/1176475

BUG= chromium:889118 

Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95
Reviewed-on: https://chromium-review.googlesource.com/c/1288709
Commit-Queue: Allen Webb <allenwebb@google.com>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600780}
[modify] https://crrev.com/6ef2e17aadaad1ecdf9055f645f885b16fce85d9/chrome/common/chrome_features.cc

Labels: Merge-Request-70 Merge-Request-71
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 18

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Owner: allenwebb@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e2f943fe1f766fb621d37ff92c75064facb557b

commit 3e2f943fe1f766fb621d37ff92c75064facb557b
Author: Allen Webb <allenwebb@google.com>
Date: Thu Oct 18 19:38:13 2018

chrome_features: Set Usbguard feature flag to disabled by default.

This needs to be enabled by Finch instead of disabled by finch.
This in principle reverts but revision exceptions were blocking the merge:
https://chromium-review.googlesource.com/1176475

BUG= chromium:889118 

Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95
Reviewed-on: https://chromium-review.googlesource.com/c/1288709
Commit-Queue: Allen Webb <allenwebb@google.com>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600780}(cherry picked from commit 6ef2e17aadaad1ecdf9055f645f885b16fce85d9)
Reviewed-on: https://chromium-review.googlesource.com/c/1288901
Cr-Commit-Position: refs/branch-heads/3538@{#1014}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/3e2f943fe1f766fb621d37ff92c75064facb557b/chrome/common/chrome_features.cc

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/3e2f943fe1f766fb621d37ff92c75064facb557b

Commit: 3e2f943fe1f766fb621d37ff92c75064facb557b
Author: allenwebb@google.com
Commiter: mnissler@chromium.org
Date: 2018-10-18 19:38:13 +0000 UTC

chrome_features: Set Usbguard feature flag to disabled by default.

This needs to be enabled by Finch instead of disabled by finch.
This in principle reverts but revision exceptions were blocking the merge:
https://chromium-review.googlesource.com/1176475

BUG= chromium:889118 

Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95
Reviewed-on: https://chromium-review.googlesource.com/c/1288709
Commit-Queue: Allen Webb <allenwebb@google.com>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600780}(cherry picked from commit 6ef2e17aadaad1ecdf9055f645f885b16fce85d9)
Reviewed-on: https://chromium-review.googlesource.com/c/1288901
Cr-Commit-Position: refs/branch-heads/3538@{#1014}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Project Member

Comment 17 by sheriffbot@chromium.org, Oct 19

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 22

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6398a01d977661366fb37f269fa2fc8a03cd437c

commit 6398a01d977661366fb37f269fa2fc8a03cd437c
Author: Allen Webb <allenwebb@google.com>
Date: Mon Oct 22 15:30:13 2018

chrome_features: Set Usbguard feature flag to disabled by default.

This needs to be enabled by Finch instead of disabled by finch.
This in principle reverts but revision exceptions were blocking the merge:
https://chromium-review.googlesource.com/1176475

BUG= chromium:889118 

Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95
Reviewed-on: https://chromium-review.googlesource.com/c/1288709
Commit-Queue: Allen Webb <allenwebb@google.com>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600780}(cherry picked from commit 6ef2e17aadaad1ecdf9055f645f885b16fce85d9)
Reviewed-on: https://chromium-review.googlesource.com/c/1288897
Cr-Commit-Position: refs/branch-heads/3578@{#207}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/6398a01d977661366fb37f269fa2fc8a03cd437c/chrome/common/chrome_features.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/6398a01d977661366fb37f269fa2fc8a03cd437c

Commit: 6398a01d977661366fb37f269fa2fc8a03cd437c
Author: allenwebb@google.com
Commiter: mnissler@chromium.org
Date: 2018-10-22 15:30:13 +0000 UTC

chrome_features: Set Usbguard feature flag to disabled by default.

This needs to be enabled by Finch instead of disabled by finch.
This in principle reverts but revision exceptions were blocking the merge:
https://chromium-review.googlesource.com/1176475

BUG= chromium:889118 

Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95
Reviewed-on: https://chromium-review.googlesource.com/c/1288709
Commit-Queue: Allen Webb <allenwebb@google.com>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600780}(cherry picked from commit 6ef2e17aadaad1ecdf9055f645f885b16fce85d9)
Reviewed-on: https://chromium-review.googlesource.com/c/1288897
Cr-Commit-Position: refs/branch-heads/3578@{#207}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e63afc2efcd09e66cdec1d25f38e003d1ce1e149

commit e63afc2efcd09e66cdec1d25f38e003d1ce1e149
Author: Allen Webb <allenwebb@google.com>
Date: Wed Oct 24 23:45:06 2018

usbguard: Fix upstart script start conditions.

"starting" was used in an upstart script for usbguard-wrapper.conf
resulting in upstart holding back usbguard.conf from starting even
on respawn. This lead to the issues reported in  crbug.com/889118 .
After this patch, usbguard daemon is able to respawn correctly.

BUG= chromium:889118 
TEST=Kill usbguard-daemon at the lock screen and verify it respawns

Change-Id: Iaeb137e93c0b72dfdab1988dd19f42ac1fe3d6a5
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1296796
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e63afc2efcd09e66cdec1d25f38e003d1ce1e149/sys-apps/usbguard/files/usbguard.conf
[modify] https://crrev.com/e63afc2efcd09e66cdec1d25f38e003d1ce1e149/sys-apps/usbguard/files/usbguard-wrapper.conf
[rename] https://crrev.com/e63afc2efcd09e66cdec1d25f38e003d1ce1e149/sys-apps/usbguard/usbguard-20180726-r14.ebuild

Status: Fixed (was: Started)

Sign in to add a comment