New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 889108 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Policy to change wallpaper not functioning

Reported by sunderma...@wdmcs.org, Sep 25

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10895.56.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.95 Safari/537.36
Platform: 10895.56.0 (Official Build) stable-channel relm

Steps to reproduce the problem:
1. Wallpaper was pushed through admin console in May 2018 through Device Management/Chrome/User Settings/Wallpaper
2. Wallpaper was removed (use Inherited) in August 2018.
3. Policy does not get removed from the device, but Chrome OS thinks there is no policy.  See screen shots:
https://photos.app.goo.gl/RdodVQfMjVkdRLCZ8
https://photos.app.goo.gl/ggB6sxxurrKbjkYMA

What is the expected behavior?
Policy says "Not Set" so it should allow the user to change the wallpaper.

What went wrong?
Users can't change their wallpaper after being pushed a wallpaper. Does not affect everyone. Of our approximately 2000 devices, I'm guessing 1500 have the problem.

Did this work before? Yes 66-ish?

Chrome version: 69.0.3497.95  Channel: stable
OS Version: 10895.56.0
Flash Version: 31.0.0.108 

Some other users have reported this on GSFE community, but it has not been wide spread. Only way I have found to fix is to wipe the device.

v67 is where we first noticed it in August. Even on v69 now, it still seems to be broken.
 
 Issue 889100  has been merged into this issue.
Cc: wzang@chromium.org
Components: -UI UI>Shell>Wallpaper
We are experiencing this on our domain as well. we have had a handful of students within the same org unit are receiving the policy properly whereas others are not. If needed we can provide logs or additional screen shots.
Thanks for filing the bug. My observation is: if the account happens to be logged in while the policy wallpaper is being removed from admin console, then the removal will take effect (after a few seconds' delay).

But if the account is logged out at the moment, it will not be able to remove the policy wallpaper even after it logs back in.

Is it the same with your observation?
The users are receiving the policy after multiple logout events. It
persists even though the chrome://policy page says it is not being applied.
Hi
Yes I think this is the case. It is occurring on about 3 chromebooks. I am
not sure whether they were logged in at the moment when I implemented the
policy. But we are seeing that they can not remove the policy even after
logging in/out.
Re #6: Thanks for verifying! I may have found the root cause for this, but looks like it must have been broken for a long time. If we're sure that it's working in "66-ish", then it may suggest a different issue.
I find that the solution is if I remove the user from the Chromebook and
have them sign in again then the wallpaper is removed.
Steve
Cc: x...@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e7690999538a6f27ddfed2d67c113470db82036

commit 4e7690999538a6f27ddfed2d67c113470db82036
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Oct 17 16:55:43 2018

cros: Notify CloudExternalDataPolicyObserver when policy doesn't exist

When the policy doesn't exist, an "OnExternalDataCleared" call could
be fired to notify clients, in case they still keep the old data from
a previous policy. It should be a no-op for clients that do not store
policy data.

Bug:  889108 
Change-Id: I6061f3be1b650f026ea88f8d353b710fb0b3b16d
Reviewed-on: https://chromium-review.googlesource.com/c/1266695
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600430}
[modify] https://crrev.com/4e7690999538a6f27ddfed2d67c113470db82036/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/4e7690999538a6f27ddfed2d67c113470db82036/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/4e7690999538a6f27ddfed2d67c113470db82036/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/4e7690999538a6f27ddfed2d67c113470db82036/chrome/browser/chromeos/login/users/wallpaper_policy_browsertest.cc
[modify] https://crrev.com/4e7690999538a6f27ddfed2d67c113470db82036/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc
[modify] https://crrev.com/4e7690999538a6f27ddfed2d67c113470db82036/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc

Cc: -wzang@chromium.org
Labels: Merge-Request-71 M-71
Owner: wzang@chromium.org
Status: Fixed (was: Unconfirmed)
Cc: bartfab@chromium.org omrilio@chromium.org
 Issue 753940  has been merged into this issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 18

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 18

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8a47e945be0db3edee510e6117a075543f5806c

commit e8a47e945be0db3edee510e6117a075543f5806c
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Oct 18 21:07:06 2018

[Merge to M71] cros: Notify CloudExternalDataPolicyObserver when policy doesn't exist

When the policy doesn't exist, an "OnExternalDataCleared" call could
be fired to notify clients, in case they still keep the old data from
a previous policy. It should be a no-op for clients that do not store
policy data.

Bug:  889108 
Change-Id: I6061f3be1b650f026ea88f8d353b710fb0b3b16d
Reviewed-on: https://chromium-review.googlesource.com/c/1266695
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600430}(cherry picked from commit 4e7690999538a6f27ddfed2d67c113470db82036)
Reviewed-on: https://chromium-review.googlesource.com/c/1289692
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#133}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/e8a47e945be0db3edee510e6117a075543f5806c/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/e8a47e945be0db3edee510e6117a075543f5806c/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/e8a47e945be0db3edee510e6117a075543f5806c/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/e8a47e945be0db3edee510e6117a075543f5806c/chrome/browser/chromeos/login/users/wallpaper_policy_browsertest.cc
[modify] https://crrev.com/e8a47e945be0db3edee510e6117a075543f5806c/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc
[modify] https://crrev.com/e8a47e945be0db3edee510e6117a075543f5806c/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc

Cc: wzang@chromium.org atwilson@chromium.org marcuskoehler@chromium.org
 Issue 889331  has been merged into this issue.
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/e8a47e945be0db3edee510e6117a075543f5806c

Commit: e8a47e945be0db3edee510e6117a075543f5806c
Author: wzang@chromium.org
Commiter: wzang@chromium.org
Date: 2018-10-18 21:07:06 +0000 UTC

[Merge to M71] cros: Notify CloudExternalDataPolicyObserver when policy doesn't exist

When the policy doesn't exist, an "OnExternalDataCleared" call could
be fired to notify clients, in case they still keep the old data from
a previous policy. It should be a no-op for clients that do not store
policy data.

Bug:  889108 
Change-Id: I6061f3be1b650f026ea88f8d353b710fb0b3b16d
Reviewed-on: https://chromium-review.googlesource.com/c/1266695
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600430}(cherry picked from commit 4e7690999538a6f27ddfed2d67c113470db82036)
Reviewed-on: https://chromium-review.googlesource.com/c/1289692
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#133}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment